DoctrineRepositoryTrait   A
last analyzed

Complexity

Total Complexity 2

Size/Duplication

Total Lines 24
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 0

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
wmc 2
c 0
b 0
f 0
lcom 0
cbo 0
dl 0
loc 24
ccs 0
cts 12
cp 0
rs 10

2 Methods

Rating   Name   Duplication   Size   Complexity  
A persist() 0 7 1
A remove() 0 7 1
1
<?php
2
3
namespace Majora\Framework\Repository\Doctrine;
4
5
use Majora\Framework\Model\CollectionableInterface;
6
7
/**
8
 * Base trait for doctrine repository.
9
 */
10
trait DoctrineRepositoryTrait
11
{
12
    /**
13
     * @see RepositoryInterface::persist()
14
     */
15
    public function persist(CollectionableInterface $majoraEntity)
16
    {
17
        $em = $this->getEntityManager();
0 ignored issues
show
Bug introduced by
It seems like getEntityManager() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
18
19
        $em->persist($majoraEntity);
20
        $em->flush();
21
    }
22
23
    /**
24
     * @see RepositoryInterface::remove()
25
     */
26
    public function remove(CollectionableInterface $majoraEntity)
27
    {
28
        $em = $this->getEntityManager();
0 ignored issues
show
Bug introduced by
It seems like getEntityManager() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
29
30
        $em->remove($majoraEntity);
31
        $em->flush();
32
    }
33
}
34