Majora\Framework\Loader\LazyLoaderTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	47
Duplicated Lines	21.28 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	loadDelegates()	10	36	5

<?php

namespace Majora\Framework\Loader;

use Majora\Framework\Model\LazyPropertiesInterface;

/**
 * Implements entity lazy loading delegates hydration.
 */
trait LazyLoaderTrait
{
    /**
     * Hydrate lazy loads delegate into given Collectionnable, if enabled and if
     * entity supports it.
     *
     * @param LazyPropertiesInterface $object (not hinted to help notation and custom exception)

There is no parameter named $object. Was it maybe removed?

     *
     * @return LazyPropertiesInterface
     */
    private function loadDelegates($entity)
    {
        if (!$this instanceof LazyLoaderInterface) {
            return $entity;
        }
        if (!$entity instanceof LazyPropertiesInterface) {
            throw new \InvalidArgumentException(sprintf('%s objects cannot be hydrated with properties loading delegates without implementing %s.',
                get_class($entity),
                LazyPropertiesInterface::class
            ));
        }

        // global handler (deprecated)

38% of this comment could be valid code. Did you maybe forget this after debugging?

        if (isset($proxies[$loaderClass = static::class])) {

The variable $proxies seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

This code seems to be duplicated across your project.

            @trigger_error(

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                sprintf('Global loader delegate is deprecated and will be removed in 1.6. Make "%s" loader invokable instead, entity to handle is given at first parameter.',
                    static::class
                ),
                E_USER_DEPRECATED
            );
            $proxies[$loaderClass]($entity);
            unset($proxies[$loaderClass]);
        }

        // define delegates into object
        $entity->registerLoaders(
            $this->getLoadingDelegates()
        );

        // global handler
        if (is_callable($this)) {
            $this($entity);
        }

        return $entity;
    }
}