EnablableLoaderTrait - Code Metrics - LinkValue/MajoraFrameworkExtraBundle - Measure and Improve Code Quality continuously with Scrutinizer

EnablableLoaderTrait A
last analyzed 2017-02-07 16:32 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	2
c	0
b	0
f	0
lcom	0
cbo	0
dl	0
loc	18
ccs	0
cts	8
cp	0
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	retrieveEnabled()	0	4	1
A	retrieveDisabled()	0	4	1

<?php

namespace Majora\Framework\Loader;

/**
 * Enablable trait for loaders.
 *
 * @see Majora\Framework\Model\EnablableTrait
 * @see Majora\Framework\Loader\EnablableLoaderInterface
 */
trait EnablableLoaderTrait
{
    /**
     * @see EnablableLoaderInterface::retrieveEnabled()
     */
    public function retrieveEnabled(array $filters = array(), $limit = null, $offset = null)
    {
        return $this->retrieveAll(array_replace($filters, array('enabled' => true)), $limit, $offset);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @see EnablableLoaderInterface::retrieveDisabled()
     */
    public function retrieveDisabled(array $filters = array(), $limit = null, $offset = null)
    {
        return $this->retrieveAll(array_replace($filters, array('enabled' => false)), $limit, $offset);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Majora\Framework\Loader;
4
5			/**
6			* Enablable trait for loaders.
7			*
8			* @see Majora\Framework\Model\EnablableTrait
9			* @see Majora\Framework\Loader\EnablableLoaderInterface
10			*/
11			trait EnablableLoaderTrait
12			{
13			/**
14			* @see EnablableLoaderInterface::retrieveEnabled()
15			*/
16			public function retrieveEnabled(array $filters = array(), $limit = null, $offset = null)
17			{
18			return $this->retrieveAll(array_replace($filters, array('enabled' => true)), $limit, $offset);
			0 ignored issues – show Bug introduced 2016-04-22 09:22 UTC by Report Bug Copy Issue Report It seems like `retrieveAll()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19			}
20
21			/**
22			* @see EnablableLoaderInterface::retrieveDisabled()
23			*/
24			public function retrieveDisabled(array $filters = array(), $limit = null, $offset = null)
25			{
26			return $this->retrieveAll(array_replace($filters, array('enabled' => false)), $limit, $offset);
			0 ignored issues – show Bug introduced 2016-04-22 09:22 UTC by Report Bug Copy Issue Report It seems like `retrieveAll()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			}
28			}
29

LinkValue / MajoraFrameworkExtraBundle

EnablableLoaderTrait A last analyzed 2017-02-07 16:32 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

EnablableLoaderTrait A
last analyzed 2017-02-07 16:32 UTC