App\Http\Controllers\Auth\RegisteredUserController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	3	1
A	validateHandle()	0	11	2
B	store()	0	50	6

<?php

namespace App\Http\Controllers\Auth;

use App\Http\Controllers\Controller;
use App\Models\User;
use App\Providers\RouteServiceProvider;
use Illuminate\Auth\Events\Registered;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Hash;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Mail;
use Illuminate\Support\Facades\Validator;

class RegisteredUserController extends Controller
{

    public function create()
    {
        return view('auth.register');
    }

    public function validateHandle(Request $request)
    {
        $validator = Validator::make($request->all(), [
            'littlelink_name' => 'required|string|max:50|unique:users|regex:/^[\p{L}0-9-_]+$/u',
        ]);
    
        if ($validator->fails()) {
            return response()->json(['valid' => false]);
        }
    
        return response()->json(['valid' => true]);
    }

    public function store(Request $request)
    {
        $request->validate([
            'name' => 'required|string|max:255',
            'littlelink_name' => 'required|string|max:50|unique:users|regex:/^[\p{L}0-9-_]+$/u',
            'email' => 'required|string|email|max:255|unique:users',
            'password' => 'required|string|min:8',
        ]);

        $name = $request->input('name');

The assignment to $name is dead and can be removed.

        if(env('MANUAL_USER_VERIFICATION') == true){
            $block = 'yes';
        } else {
            $block = 'no';
        }

        Auth::login($user = User::create([
            'name' => $request->name,
            'email' => $request->email,
            'littlelink_name' => $request->littlelink_name,
            'password' => Hash::make($request->password),
            'role' => 'user',
        ]));

        $user->block = $block;
        $user->save();


            $user = $request->name;
            $email = $request->email;
            
            if(env('REGISTER_AUTH') == 'verified'){
                if(env('MANUAL_USER_VERIFICATION') == true){
                try {
                Mail::send('auth.user-confirmation', ['user' => $user, 'email' => $email], function ($message) use ($user) {

The import $user is not used and could be removed.

                    $message->to(env('ADMIN_EMAIL'))
                            ->subject('New user registration');
                });
            } catch (\Exception $e) {}

Consider adding a comment why this CATCH block is empty.

        }
    
            try {
            $request->user()->sendEmailVerificationNotification();
            } catch (\Exception $e) {}

Consider adding a comment why this CATCH block is empty.

        }

        event(new Registered($user));

        return redirect(url('dashboard'));
    }
}