Linio\Component\SpreadsheetParser\Parser\ParserInterface

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
	__construct()	0	1	?
	open()	0	1	?
	getColumnNames()	0	1	?
	getData()	0	1	?
	close()	0	1	?

<?php

namespace Linio\Component\SpreadsheetParser\Parser;

interface ParserInterface
{
    /**
     * @param string $filePath
     * @param array $options
     */
    public function __construct($filePath, array $options = []);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    /**
     * @return bool
     */
    public function open();

function open() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

    /**
     * @return array
     */
    public function getColumnNames();

    /**
     * @param int $numRows
     *
     * @return array
     */
    public function getData($numRows = 0);

    /**
     * @return bool
     */
    public function close();

function close() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

}