SchemaBuilder::walk() - Code Metrics - LinioIT/input - Measure and Improve Code Quality continuously with Scrutinizer

SchemaBuilder::walk() A
last analyzed 2018-08-29 18:36 UTC

↳ Parent: SchemaBuilder

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.7333
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php

declare(strict_types=1);

namespace Linio\Component\Input;

use Linio\Component\Input\Node\BaseNode;

class SchemaBuilder
{
    public function build(InputHandler $inputHandler): array
    {
        $inputHandler->define();
        $schema = $this->walk($inputHandler->getRoot());

        return $schema;
    }

    protected function walk(BaseNode $node): array
    {
        if (!$node->hasChildren()) {
            return [];
        }

        foreach ($node->getChildren() as $field => $childNode) {
            $schema[$field]['type'] = $childNode->getTypeAlias();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $schema[$field]['required'] = $childNode->isRequired();
            $schema[$field]['default'] = $childNode->getDefault();
            $schema[$field]['nullable'] = $childNode->allowNull();
            $schema[$field]['children'] = $this->walk($childNode);
        }

        return $schema;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Linio\Component\Input;
6
7			use Linio\Component\Input\Node\BaseNode;
8
9			class SchemaBuilder
10			{
11			public function build(InputHandler $inputHandler): array
12			{
13			$inputHandler->define();
14			$schema = $this->walk($inputHandler->getRoot());
15
16			return $schema;
17			}
18
19			protected function walk(BaseNode $node): array
20			{
21			if (!$node->hasChildren()) {
22			return [];
23			}
24
25			foreach ($node->getChildren() as $field => $childNode) {
26			$schema[$field]['type'] = $childNode->getTypeAlias();
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-02-02 18:39 UTC by Report Bug Copy Issue Report `$schema` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$schema = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
27			$schema[$field]['required'] = $childNode->isRequired();
28			$schema[$field]['default'] = $childNode->getDefault();
29			$schema[$field]['nullable'] = $childNode->allowNull();
30			$schema[$field]['children'] = $this->walk($childNode);
31			}
32
33			return $schema;
			0 ignored issues – show Bug introduced 2017-02-02 18:39 UTC by Report Bug Copy Issue Report The variable `$schema` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
34			}
35			}
36

LinioIT / input

SchemaBuilder::walk() A last analyzed 2018-08-29 18:36 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

SchemaBuilder::walk() A
last analyzed 2018-08-29 18:36 UTC