Linio\Type\PreciseMoney

Complexity

Total Complexity

16

Size/Duplication

Total Lines	111
Duplicated Lines	19.82 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	add()	0	6	1
A	subtract()	0	6	1
A	multiply()	0	6	1
A	divide()	0	6	1
A	getPercentage()	7	7	1
A	applyPercentage()	0	6	1
A	getInterest()	15	15	1
A	applyInterest()	0	6	1
A	equals()	0	8	2
A	greaterThan()	0	4	1
A	lessThan()	0	4	1
A	getMoneyAmount()	0	6	1
A	getAmount()	0	4	1
A	setAmount()	0	4	1

<?php

declare(strict_types=1);

namespace Linio\Type;

class PreciseMoney extends Money
{
    const CALCULATION_SCALE = 10;

    public function __construct(float $amount = 0)
    {
        $this->amount = bcmul((string) $amount, '100', self::CALCULATION_SCALE);

The property $amount was declared of type integer, but bcmul((string) $amount, '100', self::CALCULATION_SCALE) is of type string. Maybe add a type cast?

    }

    public function add(Money $operand): Money
    {
        $result = bcadd($this->amount, (string) $operand->getAmount(), self::CALCULATION_SCALE);

        return Money::fromCents((float) $result);
    }

    public function subtract(Money $operand): Money
    {
        $result = bcsub($this->amount, (string) $operand->getAmount(), self::CALCULATION_SCALE);

        return Money::fromCents((float) $result);
    }

    public function multiply(float $multiplier): Money
    {
        $result = bcmul($this->amount, (string) $multiplier, self::CALCULATION_SCALE);

        return Money::fromCents((float) $result);
    }

    public function divide(float $divisor): Money
    {
        $result = bcdiv($this->amount, (string) $divisor, self::CALCULATION_SCALE);

        return Money::fromCents((float) $result);
    }

    public function getPercentage(float $percentage): Money

This method seems to be duplicated in your project.

    {
        $percentage = bcdiv((string) $percentage, '100', self::CALCULATION_SCALE);
        $result = bcmul($this->amount, (string) $percentage, self::CALCULATION_SCALE);

        return Money::fromCents((float) $result);
    }

    public function applyPercentage(float $percentage): Money
    {
        $percentage = $this->getPercentage($percentage);

        return $this->add($percentage);
    }

    public function getInterest(float $rate, int $duration): Money

This method seems to be duplicated in your project.

    {
        $interest = bcdiv((string) $rate, '100', self::CALCULATION_SCALE);
        $result = bcmul(
            bcmul(
                $this->amount,
                (string) $duration,
                self::CALCULATION_SCALE
            ),
            (string) $interest,
            self::CALCULATION_SCALE
        );

        return Money::fromCents((float) $result);
    }

    public function applyInterest(float $rate, int $duration): Money
    {
        $interest = $this->getInterest($rate, $duration);

        return $this->add($interest);
    }

    public function equals($other): bool
    {
        if (!($other instanceof Money)) {
            return false;
        }

        return bccomp((string) $this->amount, (string) $other->getAmount()) === 0;
    }

    public function greaterThan(Money $other): bool
    {
        return bccomp((string) $this->amount, (string) $other->getAmount()) === 1;
    }

    public function lessThan(Money $other): bool
    {
        return bccomp((string) $this->amount, (string) $other->getAmount()) === -1;
    }

    public function getMoneyAmount(): float
    {
        $money = bcdiv($this->amount, '100', self::CALCULATION_SCALE);

        return round($money, $this->scale);
    }

    public function getAmount(): int
    {
        return (int) round($this->amount);
    }

    public function setAmount(float $amount)
    {
        $this->amount = (string) $amount;

The property $amount was declared of type integer, but (string) $amount is of type string. Maybe add a type cast?

    }
}