Level-2 / Transphporm

src/SheetLoader/SheetLoader.php

Doc Comments +12 added lines

@@ -42,6 +42,9 @@ 
 	}
 
 
+	/**
+	 * @param \Transphporm\Template $template
+	 */
 	public function processRules($template, \Transphporm\Config $config) {
 		$rules = $this->getRules($config->getCssToXpath(), $config->getValueParser());
 
@@ -57,11 +60,20 @@ 
 	}
 
 	//Load the TSS
+
+	/**
+	 * @param \Transphporm\Parser\CssToXpath $cssToXpath
+	 * @param \Transphporm\Parser\Value $valueParser
+	 */
 	public function getRules($cssToXpath, $valueParser, $indexStart = 0) {
 		return $this->tss->getRules($cssToXpath, $valueParser, $this, $indexStart);
 	}
 
 	//Process a TSS rule e.g. `ul li {content: "foo"; format: bar}
+
+	/**
+	 * @param \Transphporm\Config $config
+	 */
 	private function executeTssRule($rule, $template, $config) {
 		$rule->touch();
 

Spacing +1 added lines, -1 removed lines

@@ -84,6 +84,6 @@
 
 
 	private function sortPseudo($a, $b) {
-		return count($a->pseudo) > count($b->pseudo)  ? 1 : -1;
+		return count($a->pseudo) > count($b->pseudo) ? 1 : -1;
 	}
 }

Braces +13 added lines, -5 removed lines

@@ -39,8 +39,9 @@ 
 			if ($token['type'] == \Transphporm\Parser\Tokenizer::NAME && $token['value'] == 'data') {
 				$tokens->next();
 				$newTokens = array_merge($newTokens, iterator_to_array($tokens->current()['value']));
+			} else {
+				$newTokens[] = $token;
 			}
-			else $newTokens[] = $token;
 		}
 
 		$this->tss->setCacheKey(new \Transphporm\Parser\Tokens($newTokens));
@@ -58,7 +59,9 @@ 
 		usort($rules, [$this, 'sortRules']);
 
 		foreach ($rules as $rule) {
-			if ($rule->shouldRun($this->time)) $this->executeTssRule($rule, $template, $config);
+			if ($rule->shouldRun($this->time)) {
+				$this->executeTssRule($rule, $template, $config);
+			}
 		}
 
 		//if (is_file($this->tss)) $this->write($this->tss, $rules, $this->import);
@@ -83,10 +86,15 @@ 
 
 	private function sortRules($a, $b) {
 		//If they have the same depth, compare on index
-		if ($a->query === $b->query) return $this->sortPseudo($a, $b);
+		if ($a->query === $b->query) {
+			return $this->sortPseudo($a, $b);
+		}
 
-		if ($a->depth === $b->depth) $property = 'index';
-		else $property = 'depth';
+		if ($a->depth === $b->depth) {
+			$property = 'index';
+		} else {
+			$property = 'depth';
+		}
 
 		return ($a->$property < $b->$property) ? -1 : 1;
 	}

Indentation +11 added lines, -11 removed lines

@@ -7,17 +7,17 @@
 namespace Transphporm\SheetLoader;
 //Separates out TSS file loading/caching from parsing
 class SheetLoader {
-    private $tss;
-    private $filePath;
-    private $time;
-    private $import = [];
-
-    public function __construct(\Transphporm\Cache $cache, \Transphporm\FilePath $filePath, TSSRules $tss, $time) {
-    	$this->cache = $cache;
-        $this->filePath = $filePath;
-        $this->tss = $tss;
-        $this->time = isset($time) ? $time : time();
-    }
+	private $tss;
+	private $filePath;
+	private $time;
+	private $import = [];
+
+	public function __construct(\Transphporm\Cache $cache, \Transphporm\FilePath $filePath, TSSRules $tss, $time) {
+		$this->cache = $cache;
+		$this->filePath = $filePath;
+		$this->tss = $tss;
+		$this->time = isset($time) ? $time : time();
+	}
 
 	//Allows controlling whether any updates are required to the template
 	//e.g. return false

src/Parser/Tokenizer/Brackets.php

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
 
 class Brackets implements \Transphporm\Parser\Tokenizable {
 
-	private $types =  [
+	private $types = [
 			Tokenizer::OPEN_BRACKET => ['(', ')'],
 			Tokenizer::OPEN_BRACE => ['{', '}'],
 			Tokenizer::OPEN_SQUARE_BRACKET => ['[', ']']

src/SheetLoader/TSSFile.php

Indentation +5 added lines, -5 removed lines

@@ -17,8 +17,8 @@ 
 		$this->fileName = $fileName;
 		$this->filePath = $filePath;
 		$this->cache = $cache;
-	    $this->time = isset($time) ? $time : time();
-	    $this->cacheName = $this->fileName;
+		$this->time = isset($time) ? $time : time();
+		$this->cacheName = $this->fileName;
 	}
 
 	private function getRulesFromCache($file) {
@@ -77,15 +77,15 @@ 
 	}
 
 	//write the sheet to cache
-    public function write($rules, $imports = []) {
+	public function write($rules, $imports = []) {
 		$existing = $this->cache->load($this->fileName, filemtime($this->fileName));
 		if (isset($existing['import']) && empty($imports)) $imports = $existing['import'];
 		$this->cache->write($this->cacheName, ['rules' => $rules, 'import' => $imports, 'minFreq' => $this->getMinUpdateFreq($rules), 'ctime' => $this->time, 'cacheKey' => $this->cacheKey]);
 
 		return $rules;
-    }
+	}
 
-    //Gets the minimum update-frequency for a sheet's rules
+	//Gets the minimum update-frequency for a sheet's rules
 	private function getMinUpdateFreq($rules) {
 		$min = \PHP_INT_MAX;
 

Braces +22 added lines, -8 removed lines

@@ -32,7 +32,9 @@ 
 		if ($rules) {
 			foreach ($rules['import'] as $file) {
 				//Check that the import file hasn't been changed since the cache was written
-				if (filemtime($file) > $rules['ctime']) return false;
+				if (filemtime($file) > $rules['ctime']) {
+					return false;
+				}
 			}
 		}
 
@@ -48,10 +50,14 @@ 
 
 		$rules = $this->getRulesFromCache($this->fileName);
 		//Nothing was cached or the TSS file has changed, update is required
-		if (empty($rules)) return true;
+		if (empty($rules)) {
+			return true;
+		}
 
 		//Find the sheet's minimum update-frequency, if it hasn't passed then no updates are required
-		if ($rules['ctime']+$rules['minFreq'] <= $this->time) return true;
+		if ($rules['ctime']+$rules['minFreq'] <= $this->time) {
+			return true;
+		}
 
 		return false;
 	}
@@ -63,15 +69,19 @@ 
 			$cacheKey = $parser->parseTokens($this->cacheKey)[0];
 			$this->cacheName = $cacheKey . $this->fileName;
 			return $cacheKey;
+		} else {
+			return $this->fileName;
 		}
-		else return $this->fileName;
 	}
 
 	public function getRules($cssToXpath, $valueParser, $sheetLoader, $indexStart) {
 		$rules = $this->getRulesFromCache($this->fileName)['rules'];
 		$this->filePath->addPath(dirname(realpath($this->fileName)));
-		if (empty($rules)) $tss = file_get_contents($this->fileName);
-		else return $rules;
+		if (empty($rules)) {
+			$tss = file_get_contents($this->fileName);
+		} else {
+			return $rules;
+		}
 
 		return $tss == null ? [] : (new \Transphporm\Parser\Sheet($tss, $cssToXpath, $valueParser, $this->filePath, $sheetLoader))->parse($indexStart);
 	}
@@ -79,7 +89,9 @@ 
 	//write the sheet to cache
     public function write($rules, $imports = []) {
 		$existing = $this->cache->load($this->fileName, filemtime($this->fileName));
-		if (isset($existing['import']) && empty($imports)) $imports = $existing['import'];
+		if (isset($existing['import']) && empty($imports)) {
+			$imports = $existing['import'];
+		}
 		$this->cache->write($this->cacheName, ['rules' => $rules, 'import' => $imports, 'minFreq' => $this->getMinUpdateFreq($rules), 'ctime' => $this->time, 'cacheKey' => $this->cacheKey]);
 
 		return $rules;
@@ -91,7 +103,9 @@ 
 
 		foreach ($rules as $rule) {
 			$ruleFreq = $rule->getUpdateFrequency();
-			if ($ruleFreq < $min) $min = $ruleFreq;
+			if ($ruleFreq < $min) {
+				$min = $ruleFreq;
+			}
 		}
 
 		return $min;

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
 		if ($this->cacheKey) {
 			$parser = new \Transphporm\Parser\Value($data);
 			$cacheKey = $parser->parseTokens($this->cacheKey)[0];
-			$this->cacheName = $cacheKey . $this->fileName;
+			$this->cacheName = $cacheKey.$this->fileName;
 			return $cacheKey;
 		}
 		else return $this->fileName;

src/TSSFunction/Constant.php

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
 	public function run(array $args, \DomElement $element) {
 		$const_name = strtoupper(trim($args[0]));
 		if (!defined($const_name)) {
-			throw new \Exception($const_name . ' is not a defined constant');
+			throw new \Exception($const_name.' is not a defined constant');
 		}
 		return constant($const_name);
 	}

src/Module/Functions.php

Indentation +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 		$templateFunction = new \Transphporm\TSSFunction\Template($config->getElementData(), $config->getCssToXpath(), $baseDir);
 		$functionSet->addFunction('template', $templateFunction);
 		$functionSet->addFunction('json', new \Transphporm\TSSFunction\Json($baseDir));
-        $functionSet->addFunction('constant', new \Transphporm\TSSFunction\Constant());
+		$functionSet->addFunction('constant', new \Transphporm\TSSFunction\Constant());
 
 		// Register HTML formatter here because it uses the template function
 		$config->registerFormatter(new \Transphporm\Formatter\HTMLFormatter($templateFunction));

src/Parser/Tokens.php

Spacing +2 added lines, -2 removed lines

@@ -39,7 +39,7 @@ 
 	}
 
 	public function add($token) {
-		if ($token instanceof Tokens) $this->tokens = array_merge($this->tokens,  $token->tokens);
+		if ($token instanceof Tokens) $this->tokens = array_merge($this->tokens, $token->tokens);
 		else $this->tokens[] = $token;
 	}
 
@@ -87,7 +87,7 @@ 
 			if ($token['type'] === $tokenType) $i++;
 			else $splitTokens[$i][] = $token;
 		}
-		return array_map(function ($tokens) {
+		return array_map(function($tokens) {
 			return new Tokens($tokens);
 		}, $splitTokens);
 		//return $splitTokens;

Braces +30 added lines, -11 removed lines

@@ -39,8 +39,11 @@ 
 	}
 
 	public function add($token) {
-		if ($token instanceof Tokens) $this->tokens = array_merge($this->tokens,  $token->tokens);
-		else $this->tokens[] = $token;
+		if ($token instanceof Tokens) {
+			$this->tokens = array_merge($this->tokens,  $token->tokens);
+		} else {
+			$this->tokens[] = $token;
+		}
 	}
 
 
@@ -54,9 +57,13 @@ 
 
 	private function getKeyToSlice($tokenType) {
 		$keys = $this->getKeysOfTokenType($tokenType);
-		if (empty($keys)) return false;
+		if (empty($keys)) {
+			return false;
+		}
 		$key = $keys[0];
-		for ($i = 0; $key < $this->iterator && isset($keys[$i]); $i++) $key = $keys[$i];
+		for ($i = 0; $key < $this->iterator && isset($keys[$i]); $i++) {
+			$key = $keys[$i];
+		}
 		return $key;
 	}
 
@@ -70,10 +77,17 @@ 
 
 	private function sliceTokens($tokenType, $type, $increment = false) {
 		$key = $this->getKeyToSlice($tokenType);
-		if ($key === false) return new Tokens([]);
-		if ($increment) $key++;
-		if ($type === "from") return new Tokens(array_slice($this->tokens, $key));
-		else return new Tokens(array_slice($this->tokens, $this->iterator, $key));
+		if ($key === false) {
+			return new Tokens([]);
+		}
+		if ($increment) {
+			$key++;
+		}
+		if ($type === "from") {
+			return new Tokens(array_slice($this->tokens, $key));
+		} else {
+			return new Tokens(array_slice($this->tokens, $this->iterator, $key));
+		}
 	}
 
 	public function skip($count) {
@@ -84,8 +98,11 @@ 
 		$splitTokens = [];
 		$i = 0;
 		foreach ($this->tokens as $token) {
-			if ($token['type'] === $tokenType) $i++;
-			else $splitTokens[$i][] = $token;
+			if ($token['type'] === $tokenType) {
+				$i++;
+			} else {
+				$splitTokens[$i][] = $token;
+			}
 		}
 		return array_map(function ($tokens) {
 			return new Tokens($tokens);
@@ -109,7 +126,9 @@ 
 
 	public function removeLine() {
 		$tokens = $this->tokens;
-		foreach ($tokens as &$token) unset($token['line']);
+		foreach ($tokens as &$token) {
+			unset($token['line']);
+		}
 		return new Tokens($tokens);
 	}
 

src/Formatter/Number.php

Spacing +3 added lines, -3 removed lines

@@ -14,12 +14,12 @@
 
 	public function decimal($num, $decimals) {
 		if (!is_numeric($num)) return $num;
-		return number_format((float)$num, $decimals, $this->locale['decimal_separator'], $this->locale['thousands_separator']);
+		return number_format((float) $num, $decimals, $this->locale['decimal_separator'], $this->locale['thousands_separator']);
 	}
 
 	public function currency($num) {
 		$num = $this->decimal($num, $this->locale['currency_decimals']);
-		if ($this->locale['currency_position'] === 'before') return $this->locale['currency'] . $num;
-		else return $num . $this->locale['currency'];
+		if ($this->locale['currency_position'] === 'before') return $this->locale['currency'].$num;
+		else return $num.$this->locale['currency'];
 	}
 }

Braces +8 added lines, -3 removed lines

@@ -13,13 +13,18 @@
 	}
 
 	public function decimal($num, $decimals) {
-		if (!is_numeric($num)) return $num;
+		if (!is_numeric($num)) {
+			return $num;
+		}
 		return number_format((float)$num, $decimals, $this->locale['decimal_separator'], $this->locale['thousands_separator']);
 	}
 
 	public function currency($num) {
 		$num = $this->decimal($num, $this->locale['currency_decimals']);
-		if ($this->locale['currency_position'] === 'before') return $this->locale['currency'] . $num;
-		else return $num . $this->locale['currency'];
+		if ($this->locale['currency_position'] === 'before') {
+			return $this->locale['currency'] . $num;
+		} else {
+			return $num . $this->locale['currency'];
+		}
 	}
 }

src/Hook/PostProcess.php

Braces +7 added lines, -3 removed lines

@@ -9,9 +9,13 @@
 class PostProcess implements \Transphporm\Hook {
 	public function run(\DomElement $element) {
 		$transphporm = $element->getAttribute('transphporm');
-		if ($transphporm === 'remove') $element->parentNode->removeChild($element);
-		else if ($transphporm === 'text') $element->parentNode->replaceChild($element->firstChild, $element);
-		else $element->removeAttribute('transphporm');
+		if ($transphporm === 'remove') {
+			$element->parentNode->removeChild($element);
+		} else if ($transphporm === 'text') {
+			$element->parentNode->replaceChild($element->firstChild, $element);
+		} else {
+			$element->removeAttribute('transphporm');
+		}
 	}
 
 	public function runOnImmutableElements(): bool {