Literals::isLiteral() - Code Metrics - Inspection of "Tokenizer rewrite" - Level-2/Transphporm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#175)

by Tom

created 2017-12-08 16:48 UTC

Literals::isLiteral() B

↳ Parent: Literals

Complexity

Conditions	5
Paths	7

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	3
nc	7
nop	2

<?php
namespace Transphporm\Parser\Tokenizer;
use \Transphporm\Parser\Tokenizer;
use \Transphporm\Parser\Tokens;

class Literals implements \Transphporm\Parser\Tokenize {

	public function tokenize(TokenizedString $str, Tokens $tokens) {
		$char = $str->identifyChar();
		if ($char === Tokenizer::NAME) {

			$name = $str->read();
			$j = 0;

			while ($this->isLiteral($j+1, $str)) {
				$name .= $str->read($j+1);
				$j++;
			}
			
			$str->move($j);

			$this->processLiterals($tokens, $name, $str);
		}
	}

	private function isLiteral($n, $str) {
		//Is it a normal literal character
		return ($str->has($n) && $str->identifyChar($n, $str) === Tokenizer::NAME
		//but a subtract can be part of a class name or a mathematical operation
				|| ($str->has($n) && $str->identifyChar($n) == Tokenizer::SUBTRACT && !is_numeric($str->read($n-1)))
			);
	}

	private function processLiterals($tokens, $name, $str) {
		if (is_numeric($name)) $tokens->add(['type' => Tokenizer::NUMERIC, 'value' => $name]);
		else if ($name == 'true') $tokens->add(['type' => Tokenizer::BOOL, 'value' => true]);
		else if ($name == 'false') $tokens->add(['type' => Tokenizer::BOOL, 'value' => false]);
		else $tokens->add(['type' => Tokenizer::NAME, 'value' => $name, 'line' => $str->lineNo()]);
	}
}

1			<?php
2			namespace Transphporm\Parser\Tokenizer;
3			use \Transphporm\Parser\Tokenizer;
4			use \Transphporm\Parser\Tokens;
5
6			class Literals implements \Transphporm\Parser\Tokenize {
7
8			public function tokenize(TokenizedString $str, Tokens $tokens) {
9			$char = $str->identifyChar();
10			if ($char === Tokenizer::NAME) {
11
12			$name = $str->read();
13			$j = 0;
14
15			while ($this->isLiteral($j+1, $str)) {
16			$name .= $str->read($j+1);
17			$j++;
18			}
19
20			$str->move($j);
21
22			$this->processLiterals($tokens, $name, $str);
23			}
24			}
25
26			private function isLiteral($n, $str) {
27			//Is it a normal literal character
28			return ($str->has($n) && $str->identifyChar($n, $str) === Tokenizer::NAME
29			//but a subtract can be part of a class name or a mathematical operation
30			\|\| ($str->has($n) && $str->identifyChar($n) == Tokenizer::SUBTRACT && !is_numeric($str->read($n-1)))
31			);
32			}
33
34			private function processLiterals($tokens, $name, $str) {
35			if (is_numeric($name)) $tokens->add(['type' => Tokenizer::NUMERIC, 'value' => $name]);
36			else if ($name == 'true') $tokens->add(['type' => Tokenizer::BOOL, 'value' => true]);
37			else if ($name == 'false') $tokens->add(['type' => Tokenizer::BOOL, 'value' => false]);
38			else $tokens->add(['type' => Tokenizer::NAME, 'value' => $name, 'line' => $str->lineNo()]);
39			}
40			}

Level-2 / Transphporm

Pull Request — master (#175)

Literals::isLiteral() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like