Level-2 / Transphporm

src/Rule.php

Spacing +4 added lines, -4 removed lines

@@ -10,8 +10,8 @@ 
 
 	const S = 1;
 	const M = 60;
-	const H = self::M*60;
-	const D = self::H*24;
+	const H = self::M * 60;
+	const D = self::H * 24;
 
 
 	public function __construct($query, $pseudo, $depth, $index, array $properties = []) {
@@ -39,9 +39,9 @@ 
 		$num = (int) $frequency;
 		$unit = strtoupper(trim(str_replace($num, '', $frequency)));
 			
-		$offset = $num * constant(self::class . '::' . $unit);
+		$offset = $num * constant(self::class.'::'.$unit);
 
-		if ($time > $this->lastRun + $offset) return true;
+		if ($time > $this->lastRun+$offset) return true;
 		else return false;
 	}
 

Braces +15 added lines, -6 removed lines

@@ -35,24 +35,33 @@
 	}
 
 	private function timeFrequency($frequency, $time = null) {
-		if ($time === null) $time = time();
+		if ($time === null) {
+			$time = time();
+		}
 		$num = (int) $frequency;
 		$unit = strtoupper(trim(str_replace($num, '', $frequency)));
 			
 		$offset = $num * constant(self::class . '::' . $unit);
 
-		if ($time > $this->lastRun + $offset) return true;
-		else return false;
+		if ($time > $this->lastRun + $offset) {
+			return true;
+		} else {
+			return false;
+		}
 	}
 
 	public function shouldRun($time = null) {
 		if (isset($this->properties['update-frequency']) && $this->lastRun !== 0) {
 			$frequency = $this->properties['update-frequency'];
 			$static = ['always' => true, 'never' => false];
-			if (isset($static[$frequency])) return $static[$frequency];
-			else return $this->timeFrequency($frequency, $time);
+			if (isset($static[$frequency])) {
+				return $static[$frequency];
+			} else {
+				return $this->timeFrequency($frequency, $time);
+			}
 
+		} else {
+			return true;
 		}
-		else return true;
 	}
 }
\ No newline at end of file

src/Builder.php

Spacing +5 added lines, -5 removed lines

@@ -37,7 +37,7 @@ 
 
 		$cachedOutput = $this->loadTemplate();
 		//To be a valid XML document it must have a root element, automatically wrap it in <template> to ensure it does
-		$template = new Template($this->isValidDoc($cachedOutput['body']) ? $cachedOutput['body'] : '<template>' . $cachedOutput['body'] . '</template>' );
+		$template = new Template($this->isValidDoc($cachedOutput['body']) ? $cachedOutput['body'] : '<template>'.$cachedOutput['body'].'</template>');
 
 		//Allow $time to be set via arguments to spoof time passage during tests
 		foreach ($this->getRules($template) as $rule) {
@@ -78,11 +78,11 @@ 
 	//N.b. only files can be cached
 	private function getRules($template) {		
 		if (is_file($this->tss)) {
-			$this->baseDir = dirname(realpath($this->tss)) . DIRECTORY_SEPARATOR;
+			$this->baseDir = dirname(realpath($this->tss)).DIRECTORY_SEPARATOR;
 			//The cache for the key: the filename and template prefix
 			//Each template may have a different prefix which changes the parsed TSS,
 			//Because of this the cache needs to be generated for each template prefix.
-			$key = $this->tss . $template->getPrefix() . $this->baseDir;
+			$key = $this->tss.$template->getPrefix().$this->baseDir;
 			//Try to load the cached rules, if not set in the cache (or expired) parse the supplied sheet
 			$rules = $this->cache->load($key, filemtime($this->tss));
 			if (!$rules) return $this->cache->write($key, (new Sheet(file_get_contents($this->tss), $this->baseDir, $template->getPrefix()))->parse());
@@ -107,8 +107,8 @@ 
 
 	private function getLocale() {
 		if (is_array($this->locale)) return $this->locale;
-		else if (strlen($this->locale) > 0) return json_decode(file_get_contents(__DIR__ . DIRECTORY_SEPARATOR . 'Formatter' . DIRECTORY_SEPARATOR . 'Locale' . DIRECTORY_SEPARATOR . $this->locale . '.json'), true);
-		else return json_decode(file_get_contents(__DIR__ . DIRECTORY_SEPARATOR . 'Formatter' . DIRECTORY_SEPARATOR . 'Locale' . DIRECTORY_SEPARATOR . 'enGB.json'), true);
+		else if (strlen($this->locale) > 0) return json_decode(file_get_contents(__DIR__.DIRECTORY_SEPARATOR.'Formatter'.DIRECTORY_SEPARATOR.'Locale'.DIRECTORY_SEPARATOR.$this->locale.'.json'), true);
+		else return json_decode(file_get_contents(__DIR__.DIRECTORY_SEPARATOR.'Formatter'.DIRECTORY_SEPARATOR.'Locale'.DIRECTORY_SEPARATOR.'enGB.json'), true);
 	}
 
 	public function registerProperties($object) {

Braces +25 added lines, -10 removed lines

@@ -40,7 +40,9 @@ 
 
 		//Allow $time to be set via arguments to spoof time passage during tests
 		foreach ($this->getRules($template) as $rule) {
-			if ($rule->shouldRun($this->time)) $this->executeTssRule($rule, $template, $data);			
+			if ($rule->shouldRun($this->time)) {
+				$this->executeTssRule($rule, $template, $data);
+			}
 		}
 		
 		$result = ['body' => $template->output($document), 'headers' => array_merge($cachedOutput['headers'], $headers)];
@@ -57,7 +59,9 @@ 
 		$formatter->register(new Formatter\Date($locale));
 		$formatter->register(new Formatter\StringFormatter());
 		
-		foreach ($this->formatters as $format) $formatter->register($format);
+		foreach ($this->formatters as $format) {
+			$formatter->register($format);
+		}
 
 		$this->registerProperty('content', new Property\Content($data, $headers, $formatter));
 		$this->registerProperty('repeat', new Property\Repeat($data));
@@ -75,7 +79,9 @@ 
 	private function executeTssRule($rule, $template, $data) {
 		$rule->touch();
 		$hook = new Hook\Rule($rule->properties, new Hook\PseudoMatcher($rule->pseudo, $data), $data);
-		foreach ($this->registeredProperties as $name => $property) $hook->registerProperty($name, $property);
+		foreach ($this->registeredProperties as $name => $property) {
+			$hook->registerProperty($name, $property);
+		}
 		$template->addHook($rule->query, $hook);
 	}
 
@@ -84,8 +90,9 @@ 
 		if (trim($this->template)[0] !== '<') {			
 			$xml = $this->cache->load($this->template, filemtime($this->template));
 			return $xml ? $xml : ['body' => file_get_contents($this->template), 'headers' => []];
+		} else {
+			return ['body' => $this->template, 'headers' => []];
 		}
-		else return ['body' => $this->template, 'headers' => []];	
 	}
 
 	//Load the TSS rules either from a file or as a string
@@ -99,10 +106,14 @@ 
 			$key = $this->tss . $template->getPrefix() . $this->baseDir;
 			//Try to load the cached rules, if not set in the cache (or expired) parse the supplied sheet
 			$rules = $this->cache->load($key, filemtime($this->tss));
-			if (!$rules) return $this->cache->write($key, (new Sheet(file_get_contents($this->tss), $this->baseDir, $template->getPrefix()))->parse());
-			else return $rules;
+			if (!$rules) {
+				return $this->cache->write($key, (new Sheet(file_get_contents($this->tss), $this->baseDir, $template->getPrefix()))->parse());
+			} else {
+				return $rules;
+			}
+		} else {
+			return (new Sheet($this->tss, $this->baseDir, $template->getPrefix()))->parse();
 		}
-		else return (new Sheet($this->tss, $this->baseDir, $template->getPrefix()))->parse();
 	}
 
 	public function setCache(\ArrayAccess $cache) {
@@ -110,9 +121,13 @@ 
 	}
 
 	private function getLocale() {
-		if (is_array($this->locale)) return $this->locale;
-		else if (strlen($this->locale) > 0) return json_decode(file_get_contents(__DIR__ . DIRECTORY_SEPARATOR . 'Formatter' . DIRECTORY_SEPARATOR . 'Locale' . DIRECTORY_SEPARATOR . $this->locale . '.json'), true);
-		else return json_decode(file_get_contents(__DIR__ . DIRECTORY_SEPARATOR . 'Formatter' . DIRECTORY_SEPARATOR . 'Locale' . DIRECTORY_SEPARATOR . 'enGB.json'), true);
+		if (is_array($this->locale)) {
+			return $this->locale;
+		} else if (strlen($this->locale) > 0) {
+			return json_decode(file_get_contents(__DIR__ . DIRECTORY_SEPARATOR . 'Formatter' . DIRECTORY_SEPARATOR . 'Locale' . DIRECTORY_SEPARATOR . $this->locale . '.json'), true);
+		} else {
+			return json_decode(file_get_contents(__DIR__ . DIRECTORY_SEPARATOR . 'Formatter' . DIRECTORY_SEPARATOR . 'Locale' . DIRECTORY_SEPARATOR . 'enGB.json'), true);
+		}
 	}
 
 	public function registerProperty($name, Property $property) {

src/Hook/PostProcess.php

Braces +5 added lines, -2 removed lines

@@ -9,8 +9,11 @@
 class PostProcess implements \Transphporm\Hook {
 	public function run(\DomElement $element) {
 		$transphporm = $element->getAttribute('transphporm');
-		if ($transphporm === 'remove') $element->parentNode->removeChild($element);
-		else $element->removeAttribute('transphporm');
+		if ($transphporm === 'remove') {
+			$element->parentNode->removeChild($element);
+		} else {
+			$element->removeAttribute('transphporm');
+		}
 	}
 
 }
\ No newline at end of file

src/Hook/Formatter.php

Braces +6 added lines, -2 removed lines

@@ -8,11 +8,15 @@
 	}
 
 	public function format($value, $rules) {
-		if (!isset($rules['format'])) return $value;
+		if (!isset($rules['format'])) {
+			return $value;
+		}
 		$format = new \Transphporm\StringExtractor($rules['format']);
 		$options = explode(' ', $format);
 		$functionName = array_shift($options);
-		foreach ($options as &$f) $f = trim($format->rebuild($f), '"');
+		foreach ($options as &$f) {
+			$f = trim($format->rebuild($f), '"');
+		}
 
 		return $this->processFormat($options, $functionName, $value);		
 	}

src/Property/Display.php

Braces +5 added lines, -2 removed lines

@@ -7,7 +7,10 @@
 namespace Transphporm\Property;
 class Display implements \Transphporm\Property {
 	public function run($value, \DomElement $element, \Transphporm\Hook\Rule $rule) {
-		if (strtolower($value[0]) === 'none') $element->setAttribute('transphporm', 'remove');
-		else $element->setAttribute('transphporm', 'show');
+		if (strtolower($value[0]) === 'none') {
+			$element->setAttribute('transphporm', 'remove');
+		} else {
+			$element->setAttribute('transphporm', 'show');
+		}
 	}
 }
\ No newline at end of file

src/Property/Bind.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 		$this->data = $data;
 	}
 
-	public function run($value, \DomElement $element, \Transphporm\Hook\Rule $rule)  {
+	public function run($value, \DomElement $element, \Transphporm\Hook\Rule $rule) {
 		$this->data->bind($element, $value);
 	}
 }
\ No newline at end of file

src/Property/Content.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
 
 	private function pseudoBefore($value, $element, $rule) {
 		if (in_array('before', $rule->getPseudoMatcher()->getPseudo())) {
-			$element->firstChild->nodeValue = implode('', $value) . $element->firstChild->nodeValue;
+			$element->firstChild->nodeValue = implode('', $value).$element->firstChild->nodeValue;
 			return true;
 		}
 	}

Braces +8 added lines, -3 removed lines

@@ -22,8 +22,11 @@ 
 			//Remove the current contents
 			$this->removeAllChildren($element);
 			//Now make a text node
-			if ($this->getContentMode($rule->getRules()) === 'replace') $this->replaceContent($element, $value);
-			else $this->appendContent($element, $value);
+			if ($this->getContentMode($rule->getRules()) === 'replace') {
+				$this->replaceContent($element, $value);
+			} else {
+				$this->appendContent($element, $value);
+			}
 		}
 	}
 
@@ -88,6 +91,8 @@ 
 	}
 
 	private function removeAllChildren($element) {
-		while ($element->hasChildNodes()) $element->removeChild($element->firstChild);
+		while ($element->hasChildNodes()) {
+			$element->removeChild($element->firstChild);
+		}
 	}
 }
\ No newline at end of file

src/Property/Repeat.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 		$this->data = $data;
 	}
 
-	public function run($value, \DomElement $element, \Transphporm\Hook\Rule $rule)  {
+	public function run($value, \DomElement $element, \Transphporm\Hook\Rule $rule) {
 		if ($element->getAttribute('transphporm') === 'added') return $element->parentNode->removeChild($element);
 
 		foreach ($value as $key => $iteration) {

Braces +6 added lines, -2 removed lines

@@ -13,7 +13,9 @@ 
 	}
 
 	public function run($value, \DomElement $element, \Transphporm\Hook\Rule $rule)  {
-		if ($element->getAttribute('transphporm') === 'added') return $element->parentNode->removeChild($element);
+		if ($element->getAttribute('transphporm') === 'added') {
+			return $element->parentNode->removeChild($element);
+		}
 
 		foreach ($value as $key => $iteration) {
 			$clone = $element->cloneNode(true);
@@ -37,7 +39,9 @@ 
 
 	private function createHook($newRules, $rule) {
 		$hook = new \Transphporm\Hook\Rule($newRules, $rule->getPseudoMatcher(), $this->data);
-		foreach ($rule->getProperties() as $name => $property) $hook->registerProperty($name, $property);
+		foreach ($rule->getProperties() as $name => $property) {
+			$hook->registerProperty($name, $property);
+		}
 		return $hook;
 	}
 }
\ No newline at end of file

Doc Comments +3 added lines

@@ -35,6 +35,9 @@
 		return false;
 	}
 
+	/**
+	 * @param \Transphporm\Hook\Rule $rule
+	 */
 	private function createHook($newRules, $rule) {
 		$hook = new \Transphporm\Hook\Rule($newRules, $rule->getPseudoMatcher(), $this->data);
 		foreach ($rule->getProperties() as $name => $property) $hook->registerProperty($name, $property);