Transphporm\TSSFunction\Math

Complexity

Total Complexity

8

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	run()	0	5	2
B	getModeResult()	0	12	5

<?php

namespace Transphporm\TSSFunction;

class Math implements \Transphporm\TSSFunction {
    private $mode;

    const ADD = 1;
    const SUBTRACT = 2;
    const MULTIPLY = 3;
    const DIVIDE = 4;

    public function __construct($mode) {
        $this->mode = $mode;
    }

    public function run(array $args, \DomElement $element) {
        $result = $args[0];
        for ($i = 1; $i < count($args); $i++) $result = $this->getModeResult($args[$i], $result);

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

        return $result;
    }

    private function getModeResult($val, $prev) {
        switch ($this->mode) {
            case Math::ADD:
                return $prev+$val;
            case Math::SUBTRACT:
                return $prev-$val;
            case Math::MULTIPLY:
                return $prev*$val;
            case MATH::DIVIDE:
                return $prev/$val;
        }
    }
}