Completed
Pull Request — master (#236)
by
unknown
03:52
created
src/Property/ContentPseudo/BeforeAfter.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -4,6 +4,9 @@
 block discarded – undo
4 4
 	private $insertLocation;
5 5
 	private $content;
6 6
 
7
+	/**
8
+	 * @param string $insertLocation
9
+	 */
7 10
 	public function __construct($insertLocation, \Transphporm\Property\Content $content) {
8 11
 		$this->insertLocation = $insertLocation;
9 12
 		$this->content = $content;
Please login to merge, or discard this patch.
src/Property/ContentPseudo/Attr.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -5,10 +5,10 @@
 block discarded – undo
5 5
 		$implodedValue = implode('', $value);
6 6
 
7 7
 		if ($pseudoMatcher->hasFunction('before')) {
8
-			$attrValue = $implodedValue . $element->getAttribute($pseudoArgs);
8
+			$attrValue = $implodedValue.$element->getAttribute($pseudoArgs);
9 9
 		}
10 10
 		else if ($pseudoMatcher->hasFunction('after')) {
11
-			$attrValue = $element->getAttribute($pseudoArgs) . $implodedValue;
11
+			$attrValue = $element->getAttribute($pseudoArgs).$implodedValue;
12 12
 		}
13 13
 		else {
14 14
 			$attrValue = implode('', $value);
Please login to merge, or discard this patch.
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -6,11 +6,9 @@
 block discarded – undo
6 6
 
7 7
 		if ($pseudoMatcher->hasFunction('before')) {
8 8
 			$attrValue = $implodedValue . $element->getAttribute($pseudoArgs);
9
-		}
10
-		else if ($pseudoMatcher->hasFunction('after')) {
9
+		} else if ($pseudoMatcher->hasFunction('after')) {
11 10
 			$attrValue = $element->getAttribute($pseudoArgs) . $implodedValue;
12
-		}
13
-		else {
11
+		} else {
14 12
 			$attrValue = implode('', $value);
15 13
 		}
16 14
 
Please login to merge, or discard this patch.
src/Property/ContentPseudo.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,5 +2,5 @@
 block discarded – undo
2 2
 namespace Transphporm\Property;
3 3
 
4 4
 interface ContentPseudo {
5
-    public function run($value, $pseudoArgs, $element, \Transphporm\Hook\PseudoMatcher $pseudoMatcher);
5
+	public function run($value, $pseudoArgs, $element, \Transphporm\Hook\PseudoMatcher $pseudoMatcher);
6 6
 }
Please login to merge, or discard this patch.
src/RunException.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -6,9 +6,9 @@
 block discarded – undo
6 6
  * @version         1.2                                                             */
7 7
 namespace Transphporm;
8 8
 class RunException extends \Exception {
9
-    public function __construct($operationType, $operationName, \Exception $previous = null) {
10
-        $message = 'TSS Error: Problem carrying out ' . $operationType . ' "' . $operationName . '"';
9
+	public function __construct($operationType, $operationName, \Exception $previous = null) {
10
+		$message = 'TSS Error: Problem carrying out ' . $operationType . ' "' . $operationName . '"';
11 11
 
12
-        parent::__construct($message, 0, $previous);
13
-    }
12
+		parent::__construct($message, 0, $previous);
13
+	}
14 14
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@
 block discarded – undo
7 7
 namespace Transphporm;
8 8
 class RunException extends \Exception {
9 9
     public function __construct($operationType, $operationName, \Exception $previous = null) {
10
-        $message = 'TSS Error: Problem carrying out ' . $operationType . ' "' . $operationName . '"';
10
+        $message = 'TSS Error: Problem carrying out '.$operationType.' "'.$operationName.'"';
11 11
 
12 12
         parent::__construct($message, 0, $previous);
13 13
     }
Please login to merge, or discard this patch.
src/TSSValidator.php 2 patches
Braces   +12 added lines, -6 removed lines patch added patch discarded remove patch
@@ -13,14 +13,17 @@  discard block
 block discarded – undo
13 13
         $this->error = null;
14 14
         $tokens = $this->tokenize($tss);
15 15
 
16
-        foreach ($tokens as $token)
17
-            if (!$this->validateRule($token)) return false;
16
+        foreach ($tokens as $token) {
17
+                    if (!$this->validateRule($token)) return false;
18
+        }
18 19
 
19 20
         return true;
20 21
     }
21 22
 
22 23
     private function validateRule($token) {
23
-        if ($token['type'] !== Tokenizer::OPEN_BRACE) return true;
24
+        if ($token['type'] !== Tokenizer::OPEN_BRACE) {
25
+        	return true;
26
+        }
24 27
 
25 28
         return $this->checkBraces($token) && $this->checkSemicolons($token)
26 29
             && $this->checkParenthesis($token);
@@ -33,8 +36,9 @@  discard block
 block discarded – undo
33 36
     private function checkSemicolons($braceToken) {
34 37
         $splitTokens = $braceToken['value']->splitOnToken(Tokenizer::COLON);
35 38
         array_shift($splitTokens); array_pop($splitTokens);
36
-        foreach ($splitTokens as $tokens)
37
-            if (!in_array(Tokenizer::SEMI_COLON, array_column(iterator_to_array($tokens), 'type'))) return false;
39
+        foreach ($splitTokens as $tokens) {
40
+                    if (!in_array(Tokenizer::SEMI_COLON, array_column(iterator_to_array($tokens), 'type'))) return false;
41
+        }
38 42
 
39 43
         return true;
40 44
     }
@@ -44,7 +48,9 @@  discard block
 block discarded – undo
44 48
     }
45 49
 
46 50
     private function tokenize($tss) {
47
-        if (is_file($tss)) $tss = file_get_contents($tss);
51
+        if (is_file($tss)) {
52
+        	$tss = file_get_contents($tss);
53
+        }
48 54
         return (new Parser\Tokenizer($tss))->getTokens();
49 55
     }
50 56
 }
Please login to merge, or discard this patch.
Indentation   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -7,44 +7,44 @@
 block discarded – undo
7 7
 namespace Transphporm;
8 8
 use Transphporm\Parser\Tokenizer;
9 9
 class TSSValidator {
10
-    private $error;
10
+	private $error;
11 11
 
12
-    public function validate($tss) {
13
-        $this->error = null;
14
-        $tokens = $this->tokenize($tss);
12
+	public function validate($tss) {
13
+		$this->error = null;
14
+		$tokens = $this->tokenize($tss);
15 15
 
16
-        foreach ($tokens as $token)
17
-            if (!$this->validateRule($token)) return false;
16
+		foreach ($tokens as $token)
17
+			if (!$this->validateRule($token)) return false;
18 18
 
19
-        return true;
20
-    }
19
+		return true;
20
+	}
21 21
 
22
-    private function validateRule($token) {
23
-        if ($token['type'] !== Tokenizer::OPEN_BRACE) return true;
22
+	private function validateRule($token) {
23
+		if ($token['type'] !== Tokenizer::OPEN_BRACE) return true;
24 24
 
25
-        return $this->checkBraces($token) && $this->checkSemicolons($token)
26
-            && $this->checkParenthesis($token);
27
-    }
25
+		return $this->checkBraces($token) && $this->checkSemicolons($token)
26
+			&& $this->checkParenthesis($token);
27
+	}
28 28
 
29
-    private function checkBraces($token) {
30
-        return strpos($token['string'], '{') === false;
31
-    }
29
+	private function checkBraces($token) {
30
+		return strpos($token['string'], '{') === false;
31
+	}
32 32
 
33
-    private function checkSemicolons($braceToken) {
34
-        $splitTokens = $braceToken['value']->splitOnToken(Tokenizer::COLON);
35
-        array_shift($splitTokens); array_pop($splitTokens);
36
-        foreach ($splitTokens as $tokens)
37
-            if (!in_array(Tokenizer::SEMI_COLON, array_column(iterator_to_array($tokens), 'type'))) return false;
33
+	private function checkSemicolons($braceToken) {
34
+		$splitTokens = $braceToken['value']->splitOnToken(Tokenizer::COLON);
35
+		array_shift($splitTokens); array_pop($splitTokens);
36
+		foreach ($splitTokens as $tokens)
37
+			if (!in_array(Tokenizer::SEMI_COLON, array_column(iterator_to_array($tokens), 'type'))) return false;
38 38
 
39
-        return true;
40
-    }
39
+		return true;
40
+	}
41 41
 
42
-    private function checkParenthesis($token) {
43
-        return substr_count($token['string'], '(') === substr_count($token['string'], ')');
44
-    }
42
+	private function checkParenthesis($token) {
43
+		return substr_count($token['string'], '(') === substr_count($token['string'], ')');
44
+	}
45 45
 
46
-    private function tokenize($tss) {
47
-        if (is_file($tss)) $tss = file_get_contents($tss);
48
-        return (new Parser\Tokenizer($tss))->getTokens();
49
-    }
46
+	private function tokenize($tss) {
47
+		if (is_file($tss)) $tss = file_get_contents($tss);
48
+		return (new Parser\Tokenizer($tss))->getTokens();
49
+	}
50 50
 }
Please login to merge, or discard this patch.
src/FilePath.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,15 +19,15 @@
 block discarded – undo
19 19
 
20 20
 	public function getFilePath($filePath) {
21 21
 		if (is_file($filePath)) return $filePath;
22
-		else if (is_file($this->baseDir . DIRECTORY_SEPARATOR . $filePath)) return $this->baseDir . DIRECTORY_SEPARATOR . $filePath;
22
+		else if (is_file($this->baseDir.DIRECTORY_SEPARATOR.$filePath)) return $this->baseDir.DIRECTORY_SEPARATOR.$filePath;
23 23
 		else return $this->loadFromPaths($filePath);
24 24
 	}
25 25
 
26 26
 	private function loadFromPaths($filePath) {
27 27
 		foreach ($this->paths as $path) {
28
-			if (is_file($path . DIRECTORY_SEPARATOR . $filePath)) return $path . DIRECTORY_SEPARATOR . $filePath;
28
+			if (is_file($path.DIRECTORY_SEPARATOR.$filePath)) return $path.DIRECTORY_SEPARATOR.$filePath;
29 29
 		}
30 30
 
31
-		throw new \Exception('File ' . $filePath . ' not found in paths (' . implode(', ', $this->paths) . ')');
31
+		throw new \Exception('File '.$filePath.' not found in paths ('.implode(', ', $this->paths).')');
32 32
 	}
33 33
 }
Please login to merge, or discard this patch.
Braces   +10 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,14 +18,20 @@
 block discarded – undo
18 18
 	}
19 19
 
20 20
 	public function getFilePath($filePath) {
21
-		if (is_file($filePath)) return $filePath;
22
-		else if (is_file($this->baseDir . DIRECTORY_SEPARATOR . $filePath)) return $this->baseDir . DIRECTORY_SEPARATOR . $filePath;
23
-		else return $this->loadFromPaths($filePath);
21
+		if (is_file($filePath)) {
22
+			return $filePath;
23
+		} else if (is_file($this->baseDir . DIRECTORY_SEPARATOR . $filePath)) {
24
+			return $this->baseDir . DIRECTORY_SEPARATOR . $filePath;
25
+		} else {
26
+			return $this->loadFromPaths($filePath);
27
+		}
24 28
 	}
25 29
 
26 30
 	private function loadFromPaths($filePath) {
27 31
 		foreach ($this->paths as $path) {
28
-			if (is_file($path . DIRECTORY_SEPARATOR . $filePath)) return $path . DIRECTORY_SEPARATOR . $filePath;
32
+			if (is_file($path . DIRECTORY_SEPARATOR . $filePath)) {
33
+				return $path . DIRECTORY_SEPARATOR . $filePath;
34
+			}
29 35
 		}
30 36
 
31 37
 		throw new \Exception('File ' . $filePath . ' not found in paths (' . implode(', ', $this->paths) . ')');
Please login to merge, or discard this patch.
src/Template.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 			$this->save = function($content = null) {
39 39
 				return $this->document->saveHtml($content);
40 40
 			};
41
-			$this->document->loadHtml('<' . '?xml encoding="UTF-8">' . $doc,  LIBXML_HTML_NODEFDTD | LIBXML_HTML_NOIMPLIED);
41
+			$this->document->loadHtml('<'.'?xml encoding="UTF-8">'.$doc, LIBXML_HTML_NODEFDTD | LIBXML_HTML_NOIMPLIED);
42 42
 
43 43
 		}
44 44
 		else {
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 		if ($document) return $this->document;
90 90
 
91 91
 		//Print the doctype... saveHtml inexplicably does not support $doc->doctype as an argument
92
-		$output = ($this->document->doctype) ? $this->document->saveXml($this->document->doctype) . "\n" : '';
92
+		$output = ($this->document->doctype) ? $this->document->saveXml($this->document->doctype)."\n" : '';
93 93
 
94 94
 		if ($this->document->documentElement->tagName !== 'template') $output .= call_user_func($this->save, $this->document->documentElement);
95 95
 		else $output = $this->printDocument();
Please login to merge, or discard this patch.
Braces   +12 added lines, -6 removed lines patch added patch discarded remove patch
@@ -41,8 +41,7 @@  discard block
 block discarded – undo
41 41
 			};
42 42
 			$this->document->loadHtml('<' . '?xml encoding="UTF-8">' . $doc,  LIBXML_HTML_NODEFDTD | LIBXML_HTML_NOIMPLIED);
43 43
 
44
-		}
45
-		else {
44
+		} else {
46 45
 			$this->document->loadXml($doc);
47 46
 			//XML was loaded, save as XML.
48 47
 			$this->save = function($content = null) {
@@ -79,7 +78,9 @@  discard block
 block discarded – undo
79 78
 	/** Prints out the current DomDocument as HTML */
80 79
 	private function printDocument() {
81 80
 		$output = '';
82
-		foreach ($this->document->documentElement->childNodes as $node) $output .= call_user_func($this->save, $node);
81
+		foreach ($this->document->documentElement->childNodes as $node) {
82
+			$output .= call_user_func($this->save, $node);
83
+		}
83 84
 		return $output;
84 85
 	}
85 86
 
@@ -91,13 +92,18 @@  discard block
 block discarded – undo
91 92
 		//Generate the document by taking only the childnodes of the template, ignoring the <template> and </template> tags
92 93
 		//TODO: Is there a faster way of doing this without string manipulation on the output or this loop through childnodes?
93 94
 		 //Either return a whole DomDocument or return the output HTML
94
-		if ($document) return $this->document;
95
+		if ($document) {
96
+			return $this->document;
97
+		}
95 98
 
96 99
 		//Print the doctype... saveHtml inexplicably does not support $doc->doctype as an argument
97 100
 		$output = ($this->document->doctype) ? $this->document->saveXml($this->document->doctype) . "\n" : '';
98 101
 
99
-		if ($this->document->documentElement->tagName !== 'template') $output .= call_user_func($this->save, $this->document->documentElement);
100
-		else $output = $this->printDocument();
102
+		if ($this->document->documentElement->tagName !== 'template') {
103
+			$output .= call_user_func($this->save, $this->document->documentElement);
104
+		} else {
105
+			$output = $this->printDocument();
106
+		}
101 107
 
102 108
 		//repair empty tags. Browsers break on <script /> and <div /> so can't avoid LIBXML_NOEMPTYTAG but they also break on <base></base> so repair them
103 109
 		$output = str_replace(['></img>', '></br>', '></meta>', '></base>', '></link>', '></hr>', '></input>'], ' />', $output);
Please login to merge, or discard this patch.
src/TSSFunction/Json.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,13 +17,13 @@
 block discarded – undo
17 17
 
18 18
 		if ($this->isJsonFile($json)) {
19 19
 			$path = $this->filePath->getFilePath($json);
20
-			if (!file_exists($path)) throw new \Exception('File does not exist at: ' . $path);
20
+			if (!file_exists($path)) throw new \Exception('File does not exist at: '.$path);
21 21
 			$json = file_get_contents($path);
22 22
 		}
23 23
 
24 24
 		$map = json_decode($json, true);
25 25
 
26
-		if (!is_array($map)) throw new \Exception('Could not decode json: ' . json_last_error_msg());
26
+		if (!is_array($map)) throw new \Exception('Could not decode json: '.json_last_error_msg());
27 27
 
28 28
 		return $map;
29 29
 	}
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,13 +17,17 @@
 block discarded – undo
17 17
 
18 18
 		if ($this->isJsonFile($json)) {
19 19
 			$path = $this->filePath->getFilePath($json);
20
-			if (!file_exists($path)) throw new \Exception('File does not exist at: ' . $path);
20
+			if (!file_exists($path)) {
21
+				throw new \Exception('File does not exist at: ' . $path);
22
+			}
21 23
 			$json = file_get_contents($path);
22 24
 		}
23 25
 
24 26
 		$map = json_decode($json, true);
25 27
 
26
-		if (!is_array($map)) throw new \Exception('Could not decode json: ' . json_last_error_msg());
28
+		if (!is_array($map)) {
29
+			throw new \Exception('Could not decode json: ' . json_last_error_msg());
30
+		}
27 31
 
28 32
 		return $map;
29 33
 	}
Please login to merge, or discard this patch.
src/Hook/ElementData.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,9 @@
 block discarded – undo
25 25
 	/** Returns the data that has been bound to $element, or, if no data is bound to $element climb the DOM tree to find the data bound to a parent node*/
26 26
 	public function getData(\DomElement $element = null, $type = 'data') {
27 27
 		while ($element) {
28
-			if (isset($this->elementMap[$element]) && array_key_exists($type, $this->elementMap[$element])) return $this->elementMap[$element][$type];
28
+			if (isset($this->elementMap[$element]) && array_key_exists($type, $this->elementMap[$element])) {
29
+				return $this->elementMap[$element][$type];
30
+			}
29 31
 			$element = $element->parentNode;
30 32
 		}
31 33
 		return $this->data;
Please login to merge, or discard this patch.