SheetCache::write() - Code Metrics - Inspection of "#191 - superficially supports data() in @cacheKey" - Level-2/Transphporm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02c8a1...58faf5 )

by Tom

created 2018-05-14 16:19 UTC

SheetCache::write() A

↳ Parent: SheetCache

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	3
eloc	6
nc	3
nop	3

<?php
/* @description     Transformation Style Sheets - Revolutionising PHP templating    *
 * @author          Tom Butler [email protected]                                             *
 * @copyright       2017 Tom Butler <[email protected]> | https://r.je/                      *
 * @license         http://www.opensource.org/licenses/bsd-license.php  BSD License *
 * @version         1.2                                                             */
namespace Transphporm;
//Separates out TSS file loading/caching from parsing
class SheetCache {
	private $cacheKey;
	private $cacheName;
	private $cache;

	public function __construct(Cache $cache) {
		$this->cache = $cache;
	}

	private function getRulesFromCache($file) {

		//Try to load the cached rules, if not set in the cache (or expired) parse the supplied sheet
		$rules = $this->cache->load($this->cacheName, filemtime($file));

		$this->cacheKey = $this->cacheKey ?? $rules['cacheKey'] ?? null;

		if ($rules) {
			foreach ($rules['import'] as $file) {
				//Check that the import file hasn't been changed since the cache was written
				if (filemtime($file) > $rules['ctime']) return false;
			}
		}
		return $rules;
	}

	public function getCacheKey($tss, $data) {

		//Read the rules so that $this->cacheKey is set
		if (is_file($tss)) $this->getRulesFromCache($tss);
		if ($this->cacheKey) {
			$parser = new Parser\Value($data);
			$parsedKey = $parser->parseTokens($this->cacheKey)[0];
			$this->cacheName = $parsedKey . $this->tss;
class MyClass { }

$x = new MyClass();
$x->foo = true;
			return $parsedKey;
		}
		else return '';
	}


	//write the sheet to cache
    public function write($file, $rules, $imports = []) {
		if (is_file($file)) {
			$existing = $this->cache->load($file, filemtime($file));
			if (isset($existing['import'])) $imports = $existing['import'];
			$this->cache->write($this->cacheName, ['rules' => $rules, 'import' => $imports, 'minFreq' => $this->getMinUpdateFreq($rules), 'ctime' => $this->time, 'cacheKey' => $this->cacheKey]);
class MyClass { }

$x = new MyClass();
$x->foo = true;
		}
		return $rules;
    }

    public function setKey($key) {
    	$this->cacheKey = $key;
    }

}

1		<?php
2		/* @description Transformation Style Sheets - Revolutionising PHP templating *
3		* @author Tom Butler [email protected] *
4		* @copyright 2017 Tom Butler <[email protected]> \| https://r.je/ *
5		* @license http://www.opensource.org/licenses/bsd-license.php BSD License *
6		* @version 1.2 */
7		namespace Transphporm;
8		//Separates out TSS file loading/caching from parsing
9		class SheetCache {
10		private $cacheKey;
11		private $cacheName;
12		private $cache;
13
14		public function __construct(Cache $cache) {
15		$this->cache = $cache;
16		}
17
18	View Code Duplication	private function getRulesFromCache($file) {
		0 ignored issues – show Duplication introduced 2018-05-14 16:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		//Try to load the cached rules, if not set in the cache (or expired) parse the supplied sheet
20		$rules = $this->cache->load($this->cacheName, filemtime($file));
21
22		$this->cacheKey = $this->cacheKey ?? $rules['cacheKey'] ?? null;
23
24		if ($rules) {
25		foreach ($rules['import'] as $file) {
26		//Check that the import file hasn't been changed since the cache was written
27		if (filemtime($file) > $rules['ctime']) return false;
28		}
29		}
30		return $rules;
31		}
32
33	View Code Duplication	public function getCacheKey($tss, $data) {
		0 ignored issues – show Duplication introduced 2018-05-14 16:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		//Read the rules so that $this->cacheKey is set
35		if (is_file($tss)) $this->getRulesFromCache($tss);
36		if ($this->cacheKey) {
37		$parser = new Parser\Value($data);
38		$parsedKey = $parser->parseTokens($this->cacheKey)[0];
39		$this->cacheName = $parsedKey . $this->tss;
		0 ignored issues – show Bug introduced 2018-05-14 16:21 UTC by Report Bug Copy Issue Report The property `tss` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
40		return $parsedKey;
41		}
42		else return '';
43		}
44
45
46		//write the sheet to cache
47		public function write($file, $rules, $imports = []) {
48		if (is_file($file)) {
49		$existing = $this->cache->load($file, filemtime($file));
50		if (isset($existing['import'])) $imports = $existing['import'];
51		$this->cache->write($this->cacheName, ['rules' => $rules, 'import' => $imports, 'minFreq' => $this->getMinUpdateFreq($rules), 'ctime' => $this->time, 'cacheKey' => $this->cacheKey]);
		0 ignored issues – show Bug introduced 2018-05-14 16:21 UTC by Report Bug Copy Issue Report The property `time` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2018-05-14 16:21 UTC by Report Bug Copy Issue Report The method `getMinUpdateFreq()` does not seem to exist on `object<Transphporm\SheetCache>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
52		}
53		return $rules;
54		}
55
56		public function setKey($key) {
57		$this->cacheKey = $key;
58		}
59
60		}

Level-2 / Transphporm

Push — master ( 02c8a1...58faf5 )

SheetCache::write() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like