Level-2 / Transphporm

src/Hook/ElementData.php

Braces +3 added lines, -1 removed lines

@@ -31,7 +31,9 @@
 	/** Returns the data that has been bound to $element, or, if no data is bound to $element climb the DOM tree to find the data bound to a parent node*/
 	public function getData(\DomElement $element = null, $type = 'data') {
 		while ($element) {
-			if (isset($this->elementMap[$element]) && isset($this->elementMap[$element][$type])) return $this->elementMap[$element][$type];
+			if (isset($this->elementMap[$element]) && isset($this->elementMap[$element][$type])) {
+				return $this->elementMap[$element][$type];
+			}
 			$element = $element->parentNode;
 		}
 		return $this->data;

src/Parser/Tokenizer.php

Spacing +1 added lines, -1 removed lines

@@ -105,7 +105,7 @@
 			$string = $this->extractString($i);
 			$length = strlen($string)+1;
 			$char = $this->getChar($char);
-			$string = str_replace('\\' . $char, $char, $string);
+			$string = str_replace('\\'.$char, $char, $string);
 			$tokens[] = ['type' => self::STRING, 'value' => $string];
 			return $length;
 		}

Braces +25 added lines, -10 removed lines

@@ -76,10 +76,15 @@ 
 				$name .= $this->str[$i+1];
 				$i++;
 			}
-			if (is_numeric($name)) $tokens[] = ['type' => self::NUMERIC, 'value' => $name];
-			else if ($name == 'true') $tokens[] = ['type' => self::BOOL, 'value' => true];
-			else if ($name == 'false') $tokens[] = ['type' => self::BOOL, 'value' => false];
-			else $tokens[] = ['type' => self::NAME, 'value' => $name];
+			if (is_numeric($name)) {
+				$tokens[] = ['type' => self::NUMERIC, 'value' => $name];
+			} else if ($name == 'true') {
+				$tokens[] = ['type' => self::BOOL, 'value' => true];
+			} else if ($name == 'false') {
+				$tokens[] = ['type' => self::BOOL, 'value' => false];
+			} else {
+				$tokens[] = ['type' => self::NAME, 'value' => $name];
+			}
 		}
 	}
 
@@ -114,7 +119,9 @@ 
 	private function extractString($pos) {
 		$char = $this->str[$pos];
 		$end = strpos($this->str, $char, $pos+1);
-		while ($end !== false && $this->str[$end-1] == '\\') $end = strpos($this->str, $char, $end+1);
+		while ($end !== false && $this->str[$end-1] == '\\') {
+			$end = strpos($this->str, $char, $end+1);
+		}
 
 		return substr($this->str, $pos+1, $end-$pos-1);
 	}
@@ -123,18 +130,26 @@ 
 		$close = strpos($this->str, $closeBracket, $open);
 
 		$cPos = $open+1;
-		while (($cPos = strpos($this->str, $startBracket, $cPos+1)) !== false && $cPos < $close) $close = strpos($this->str, $closeBracket, $close+1);
+		while (($cPos = strpos($this->str, $startBracket, $cPos+1)) !== false && $cPos < $close) {
+			$close = strpos($this->str, $closeBracket, $close+1);
+		}
 		return substr($this->str, $open+1, $close-$open-1);
 	}
 
 	private function identifyChar($chr) {
-		if (isset($this->chars[$chr])) return $this->chars[$chr];
-		else return self::NAME;
+		if (isset($this->chars[$chr])) {
+			return $this->chars[$chr];
+		} else {
+			return self::NAME;
+		}
 	}
 
 	private function getChar($num) {
 		$chars = array_reverse($this->chars);
-		if (isset($chars[$num])) return $chars[$num];
-		else return false;
+		if (isset($chars[$num])) {
+			return $chars[$num];
+		} else {
+			return false;
+		}
 	}
 }

src/Property/Repeat.php

Braces +15 added lines, -5 removed lines

@@ -15,13 +15,19 @@ 
 	}
 
 	public function run(array $values, \DomElement $element, array $rules, \Transphporm\Hook\PseudoMatcher $pseudoMatcher, array $properties = []) {
-		if ($element->getAttribute('transphporm') === 'added') return $element->parentNode->removeChild($element);
+		if ($element->getAttribute('transphporm') === 'added') {
+			return $element->parentNode->removeChild($element);
+		}
 		$max = $this->getMax($values);
 		$count = 0;
 
-		if (empty($values[0])) $values[0] = [];
+		if (empty($values[0])) {
+			$values[0] = [];
+		}
 		foreach ($values[0] as $key => $iteration) {
-			if ($count+1 > $max) break;
+			if ($count+1 > $max) {
+				break;
+			}
 			$clone = $this->cloneElement($element, $iteration, $key, $count++);
 			//Re-run the hook on the new element, but use the iterated data
 			//Don't run repeat on the clones element or it will loop forever
@@ -45,7 +51,9 @@ 
 
 	private function tagElement($element, $count) {
 		//Mark all but one of the nodes as having been added by transphporm, when the hook is run again, these are removed
-		if ($count > 0) $element->setAttribute('transphporm', 'added');
+		if ($count > 0) {
+			$element->setAttribute('transphporm', 'added');
+		}
 	}
 
 	private function getMax($values) {
@@ -54,7 +62,9 @@ 
 
 	private function createHook($newRules, $pseudoMatcher, $properties) {
 		$hook = new \Transphporm\Hook\PropertyHook($newRules, $pseudoMatcher, new \Transphporm\Parser\Value($this->functionSet));
-		foreach ($properties as $name => $property) $hook->registerProperty($name, $property);
+		foreach ($properties as $name => $property) {
+			$hook->registerProperty($name, $property);
+		}
 		return $hook;
 	}
 }

src/Property/Display.php

Braces +7 added lines, -3 removed lines

@@ -7,8 +7,12 @@
 namespace Transphporm\Property;
 class Display implements \Transphporm\Property {
 	public function run(array $values, \DomElement $element, array $rules, \Transphporm\Hook\PseudoMatcher $pseudoMatcher, array $properties = []) {
-		if ($pseudoMatcher->hasFunction('attr')) $element->removeAttribute($pseudoMatcher->getFuncArgs('attr'));
-		else if (strtolower($values[0]) === 'none') $element->setAttribute('transphporm', 'remove');
-		else $element->setAttribute('transphporm', 'show');
+		if ($pseudoMatcher->hasFunction('attr')) {
+			$element->removeAttribute($pseudoMatcher->getFuncArgs('attr'));
+		} else if (strtolower($values[0]) === 'none') {
+			$element->setAttribute('transphporm', 'remove');
+		} else {
+			$element->setAttribute('transphporm', 'show');
+		}
 	}
 }
\ No newline at end of file

src/Pseudo/Attribute.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
 
 		$valueParser = new \Transphporm\Parser\Value($this->functionSet);
 
-		$criteria = $name . '(' . $criteria;
+		$criteria = $name.'('.$criteria;
 
 		$pos = strpos($pseudo, '!');
 		if ($pos === false) $pos = strpos($pseudo, '=');

Braces +11 added lines, -4 removed lines

@@ -15,10 +15,14 @@ 
 	public function match($pseudo, \DomElement $element) {
 
 		$pos = strpos($pseudo, '[');
-		if ($pos === false) return true;
+		if ($pos === false) {
+			return true;
+		}
 
 		$name = substr($pseudo, 0, $pos);
-		if (!$this->functionSet->hasFunction($name)) return true;
+		if (!$this->functionSet->hasFunction($name)) {
+			return true;
+		}
 
 		$bracketMatcher = new \Transphporm\Parser\BracketMatcher($pseudo);
 		$criteria = $bracketMatcher->match('[', ']');
@@ -28,11 +32,14 @@ 
 		$criteria = $name . '(' . $criteria;
 
 		$pos = strpos($pseudo, '!');
-		if ($pos === false) $pos = strpos($pseudo, '=');
+		if ($pos === false) {
+			$pos = strpos($pseudo, '=');
+		}
 		if ($pos === false) {
 			$criteria .= ')=true';
+		} else {
+			$criteria = substr_replace($criteria, ')', $pos, 0);
 		}
-		else $criteria = substr_replace($criteria, ')', $pos, 0);
 
 		return $valueParser->parse($criteria, $element)[0];
 	}

src/TSSFunction/Data.php

Spacing +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
  * @version         1.0                                                             */
 namespace Transphporm\TSSFunction;
 /* Handles data() and iteration() function calls from the stylesheet */
-class Data implements \Transphporm\TSSFunction{
+class Data implements \Transphporm\TSSFunction {
 	private $data;
 	private $dataKey;
 	private $functionSet;

Braces +5 added lines, -2 removed lines

@@ -18,8 +18,11 @@
 	}
 
 	public function run(array $args, \DomElement $element = null) {
-		if ($this->dataKey === "root") $data = $this->data->getData(null, 'data');
-		else $data = $this->data->getData($element, $this->dataKey);
+		if ($this->dataKey === "root") {
+			$data = $this->data->getData(null, 'data');
+		} else {
+			$data = $this->data->getData($element, $this->dataKey);
+		}
 		$parser = new \Transphporm\Parser\Value($this->functionSet, true);
 		$return = $parser->parseTokens($args, $data);
 		return $return[0];

src/TSSFunction/Json.php

Indentation +15 added lines, -15 removed lines

@@ -1,25 +1,25 @@
 <?php
 namespace Transphporm\TSSFunction;
 class Json implements \Transphporm\TSSFunction {
-    private $baseDir;
+	private $baseDir;
 
-    public function __construct(&$baseDir) {
-        $this->baseDir = &$baseDir;
-    }
+	public function __construct(&$baseDir) {
+		$this->baseDir = &$baseDir;
+	}
 
-    public function run(array $args, \DomElement $element = null) {
-        $json = $args[0];
+	public function run(array $args, \DomElement $element = null) {
+		$json = $args[0];
 
-        if (trim($json)[0] != '{') {
-            $path = $this->baseDir . $json;
-            if (!file_exists($path)) throw new \Exception('File does not exist at: ' . $path);
-            $json = file_get_contents($json);
-        }
+		if (trim($json)[0] != '{') {
+			$path = $this->baseDir . $json;
+			if (!file_exists($path)) throw new \Exception('File does not exist at: ' . $path);
+			$json = file_get_contents($json);
+		}
 
-        $map = json_decode($json, true);
+		$map = json_decode($json, true);
 
-        if (!is_array($map)) throw new \Exception('Could not decode json: ' . json_last_error_msg());
+		if (!is_array($map)) throw new \Exception('Could not decode json: ' . json_last_error_msg());
 
-        return $map;
-    }
+		return $map;
+	}
 }

Spacing +3 added lines, -3 removed lines

@@ -11,14 +11,14 @@
         $json = $args[0];
 
         if (trim($json)[0] != '{') {
-            $path = $this->baseDir . $json;
-            if (!file_exists($path)) throw new \Exception('File does not exist at: ' . $path);
+            $path = $this->baseDir.$json;
+            if (!file_exists($path)) throw new \Exception('File does not exist at: '.$path);
             $json = file_get_contents($json);
         }
 
         $map = json_decode($json, true);
 
-        if (!is_array($map)) throw new \Exception('Could not decode json: ' . json_last_error_msg());
+        if (!is_array($map)) throw new \Exception('Could not decode json: '.json_last_error_msg());
 
         return $map;
     }

Braces +6 added lines, -2 removed lines

@@ -12,13 +12,17 @@
 
         if (trim($json)[0] != '{') {
             $path = $this->baseDir . $json;
-            if (!file_exists($path)) throw new \Exception('File does not exist at: ' . $path);
+            if (!file_exists($path)) {
+            	throw new \Exception('File does not exist at: ' . $path);
+            }
             $json = file_get_contents($json);
         }
 
         $map = json_decode($json, true);
 
-        if (!is_array($map)) throw new \Exception('Could not decode json: ' . json_last_error_msg());
+        if (!is_array($map)) {
+        	throw new \Exception('Could not decode json: ' . json_last_error_msg());
+        }
 
         return $map;
     }

src/Parser/Value.php

Doc Comments +4 added lines

@@ -155,6 +155,10 @@
 
 	//Extracts $last from $data. If "last" is "bar" from value "foo.bar",
 	//$data contains "foo" and this function reads $data[$bar] or $data->$bar
+
+	/**
+	 * @param ValueResult|null $result
+	 */
 	private function extractLast($result) {
 		if ($this->autoLookup && isset($this->data->{$this->last})) {
 			return $this->result->processValue($this->data->{$this->last});

Braces +36 added lines, -22 removed lines

@@ -51,7 +51,9 @@ 
 		$this->data = $data;
 		$this->last = null;
 
-		if (empty($tokens)) return [$this->data];
+		if (empty($tokens)) {
+			return [$this->data];
+		}
 		
 		foreach ($tokens as $token) {
 			$this->{$this->tokenFuncs[$token['type']]}($token);	
@@ -66,27 +68,36 @@ 
 
 		if ($this->result->getMode() == Tokenizer::NOT && $token['type'] == Tokenizer::EQUALS) {
 			$this->result->setMode(Tokenizer::NOT);
+		} else {
+			$this->result->setMode($token['type']);
 		}
-		else $this->result->setMode($token['type']);
 	}
 
 
 	//Reads the last selected value from $data regardless if it's an array or object and overrides $this->data with the new value
 	private function moveLastToData() {
-		if (isset($this->data->{$this->last})) $this->data = $this->data->{$this->last};
-		else if (is_array($this->data) && isset($this->data[$this->last])) $this->data = $this->data[$this->last];
+		if (isset($this->data->{$this->last})) {
+			$this->data = $this->data->{$this->last};
+		} else if (is_array($this->data) && isset($this->data[$this->last])) {
+			$this->data = $this->data[$this->last];
+		}
 	}
 
 	//Dot moves $data to the next object in $data foo.bar moves the $data pointer from `foo` to `bar`
 	private function processDot($token) {
-		if ($this->last !== null) $this->moveLastToData();
-		else $this->data = $this->result->pop();
+		if ($this->last !== null) {
+			$this->moveLastToData();
+		} else {
+			$this->data = $this->result->pop();
+		}
 
 		$this->last = null;
 	}
 
 	private function processSquareBracket($token) {
-		if ($this->last !== null) $this->moveLastToData();
+		if ($this->last !== null) {
+			$this->moveLastToData();
+		}
 		$parser = new Value($this->baseData, $this->autoLookup);
 		$this->last = $parser->parseTokens($token['value'], null)[0];
 	}
@@ -108,15 +119,15 @@ 
 	private function processBrackets($token) {
 		if ($this->baseData instanceof \Transphporm\Functionset && $this->baseData->hasFunction($this->last)) {
 			$this->callTransphpormFunctions($token);
-		}
-		else if ($this->data instanceof \Transphporm\Functionset) {
+		} else if ($this->data instanceof \Transphporm\Functionset) {
 			$this->result = $this->result->processValue($this->data->{$this->last}($token['value']));
 			$this->last = null;
-		}
-		else {
+		} else {
 			$parser = new Value($this->baseData, $this->autoLookup);
 			$args = $parser->parseTokens($token['value'], $this->data);
-			if ($args[0] == $this->data) $args = [];
+			if ($args[0] == $this->data) {
+				$args = [];
+			}
 			$funcResult = $this->callFunc($this->last, $args, $this->data);
 			$this->result->processValue($funcResult);
 			$this->last = null;
@@ -127,9 +138,12 @@ 
 		$this->result->processValue($this->baseData->{$this->last}($token['value']));
 		foreach ($this->result->getResult() as $i => $value) {
 			if (is_array($this->data)) {
-				if (isset($this->data[$value])) $this->result[$i] = $this->data[$value];
+				if (isset($this->data[$value])) {
+					$this->result[$i] = $this->data[$value];
+				}
+			} else if (is_scalar($value) && isset($this->data->$value)) {
+				$this->result[$i] = $this->data->$value;
 			}
-			else if (is_scalar($value) && isset($this->data->$value)) $this->result[$i] = $this->data->$value;
 		}
 		$this->last = null;
 	}
@@ -139,12 +153,10 @@ 
 		if ($this->last !== null) {
 			try {
 				$this->extractLast($this->result);
-			}
-			catch (\UnexpectedValueException $e) {
+			} catch (\UnexpectedValueException $e) {
 				if (!$this->autoLookup) {
 					$this->result->processValue($this->last);
-				}
-				else {
+				} else {
 					$this->result->clear();
 					$this->result[0] = false;
 				}
@@ -158,8 +170,7 @@ 
 	private function extractLast($result) {
 		if ($this->autoLookup && isset($this->data->{$this->last})) {
 			return $this->result->processValue($this->data->{$this->last});
-		}
-		else if (is_array($this->data) && isset($this->data[$this->last])) {
+		} else if (is_array($this->data) && isset($this->data[$this->last])) {
 			return $this->result->processValue($this->data[$this->last]);
 		}
 		throw new \UnexpectedValueException('Not found');
@@ -170,7 +181,10 @@ 
 	}
 
 	private function callFuncOnObject($obj, $func, $args) {
-		if (isset($obj->$func) && is_callable($obj->$func)) return call_user_func_array($obj->$func, $args);
-		else return call_user_func_array([$obj, $func], $args);
+		if (isset($obj->$func) && is_callable($obj->$func)) {
+			return call_user_func_array($obj->$func, $args);
+		} else {
+			return call_user_func_array([$obj, $func], $args);
+		}
 	}
 }
\ No newline at end of file

src/Config.php

Braces +6 added lines, -2 removed lines

@@ -67,12 +67,16 @@
 	}
 
 	public function loadProperties(Hook\PropertyHook $hook) {
-		foreach ($this->properties as $name => $property) $hook->registerProperty($name, $property);
+		foreach ($this->properties as $name => $property) {
+			$hook->registerProperty($name, $property);
+		}
 	}
 
 	public function createPseudoMatcher($pseudo) {
 		$pseudoMatcher = new Hook\PseudoMatcher($pseudo);
-		foreach ($this->pseudo as $pseudoFunction) $pseudoMatcher->registerFunction($pseudoFunction);
+		foreach ($this->pseudo as $pseudoFunction) {
+			$pseudoMatcher->registerFunction($pseudoFunction);
+		}
 		return $pseudoMatcher;
 	}