Transphporm\TSSFunction\Math

Complexity

Total Complexity

8

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	run()	0	5	2
A	getModeResult()	0	3	1
A	add()	0	3	1
A	sub()	0	3	1
A	mult()	0	3	1
A	div()	0	3	1

<?php

namespace Transphporm\TSSFunction;

class Math implements \Transphporm\TSSFunction {
    private $mode;

    const ADD = 'add';
    const SUBTRACT = 'sub';
    const MULTIPLY = 'mult';
    const DIVIDE = 'div';

    public function __construct($mode) {
        $this->mode = $mode;
    }

    public function run(array $args, \DomElement $element) {
        $result = $args[0];
        for ($i = 1; $i < count($args); $i++) $result = $this->getModeResult($args[$i], $result);

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

        return $result;
    }

    private function getModeResult($val, $prev) {
        return $this->{$this->mode}($val, $prev);
    }

    private function add($val, $prev) {
        return $prev+$val;
    }

    private function sub($val, $prev) {
        return $prev-$val;
    }

    private function mult($val, $prev) {
        return $prev*$val;
    }

    private function div($val, $prev) {
        return $prev/$val;
    }
}