Passed
Push — master ( c6db1f...36e64a )
by Richard
01:42
created
maphper/maphper.php 1 patch
Braces   +25 added lines, -9 removed lines patch added patch discarded remove patch
@@ -61,7 +61,9 @@  discard block
 block discarded – undo
61 61
 
62 62
 		$siblings = new \ArrayObject();
63 63
 
64
-		foreach ($results as &$result) $result = $this->entity->create($result, $this->relations, $siblings);
64
+		foreach ($results as &$result) {
65
+			$result = $this->entity->create($result, $this->relations, $siblings);
66
+		}
65 67
 
66 68
 		return $results;
67 69
 	}
@@ -78,13 +80,17 @@  discard block
 block discarded – undo
78 80
 	private function processFilters($value) {
79 81
 		//When saving to a mapper with filters, write the filters back into the object being stored
80 82
 		foreach ($this->settings['filter'] as $key => $filterValue) {
81
-			if (empty($value->$key) && !is_array($filterValue)) $value->$key = $filterValue;
83
+			if (empty($value->$key) && !is_array($filterValue)) {
84
+				$value->$key = $filterValue;
85
+			}
82 86
 		}
83 87
 		return $value;
84 88
 	}
85 89
 
86 90
 	public function offsetSet($offset, $valueObj) {
87
-		if ($valueObj instanceof \Maphper\Relation) throw new \Exception();
91
+		if ($valueObj instanceof \Maphper\Relation) {
92
+			throw new \Exception();
93
+		}
88 94
 
89 95
 		//Extract private properties from the object
90 96
 		$visibilityOverride = new \Maphper\Lib\VisibilityOverride($valueObj);
@@ -92,7 +98,9 @@  discard block
 block discarded – undo
92 98
 
93 99
 		$value = $this->processFilters($value);
94 100
 		$pk = $this->dataSource->getPrimaryKey();
95
-		if ($offset !== null) $value->{$pk[0]} = $offset;
101
+		if ($offset !== null) {
102
+			$value->{$pk[0]} = $offset;
103
+		}
96 104
 		$valueCopy = clone $value;
97 105
 		$value = $this->entity->wrap($this->relations, $value);
98 106
 		$this->dataSource->save($value);
@@ -104,7 +112,9 @@  discard block
 block discarded – undo
104 112
 	}
105 113
 
106 114
 	public function offsetExists($offset) {
107
-		if (count($this->dataSource->getPrimaryKey()) > 1) return new MultiPk($this, $offset, $this->dataSource->getPrimaryKey());
115
+		if (count($this->dataSource->getPrimaryKey()) > 1) {
116
+			return new MultiPk($this, $offset, $this->dataSource->getPrimaryKey());
117
+		}
108 118
         if (!empty($this->settings['filter'])) {
109 119
             $data = $this->dataSource->findByField(array_merge($this->settings['filter'], [$this->dataSource->getPrimaryKey()[0] => $offset]));
110 120
             return isset($data[0]);
@@ -117,7 +127,9 @@  discard block
 block discarded – undo
117 127
 	}
118 128
 
119 129
 	public function offsetGet($offset) {
120
-		if (count($this->dataSource->getPrimaryKey()) > 1) return new MultiPk($this, $offset, $this->dataSource->getPrimaryKey());
130
+		if (count($this->dataSource->getPrimaryKey()) > 1) {
131
+			return new MultiPk($this, $offset, $this->dataSource->getPrimaryKey());
132
+		}
121 133
         if (!empty($this->settings['filter'])) {
122 134
             $data = $this->dataSource->findByField(array_merge($this->settings['filter'], [$this->dataSource->getPrimaryKey()[0] => $offset]));
123 135
             return $this->entity->create(isset($data[0]) ? $data[0] : null, $this->relations);
@@ -128,11 +140,15 @@  discard block
 block discarded – undo
128 140
 	public function __call($method, $args) {
129 141
 		if (array_key_exists($method, $this->settings)) {
130 142
 			$maphper = new Maphper($this->dataSource, $this->settings, $this->relations);
131
-			if (is_array($maphper->settings[$method])) $maphper->settings[$method] = $args[0] + $maphper->settings[$method];
132
-			else $maphper->settings[$method] = $args[0];
143
+			if (is_array($maphper->settings[$method])) {
144
+				$maphper->settings[$method] = $args[0] + $maphper->settings[$method];
145
+			} else {
146
+				$maphper->settings[$method] = $args[0];
147
+			}
133 148
 			return $maphper;
149
+		} else {
150
+			throw new \Exception('Method Maphper::' . $method . ' does not exist');
134 151
 		}
135
-		else throw new \Exception('Method Maphper::' . $method . ' does not exist');
136 152
 	}
137 153
 
138 154
 	public function findAggregate($function, $field, $group = null) {
Please login to merge, or discard this patch.
maphper/lib/visibilityoverride.php 1 patch
Braces   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -9,12 +9,13 @@
 block discarded – undo
9 9
 		if ($object instanceof \stdclass) {
10 10
 			$this->readClosure = function() use ($object) { return $object;	};
11 11
 			$this->writeClosure = function ($field, $value) use ($object) { $object->$field = $value; };
12
-		}
13
-		else {
12
+		} else {
14 13
 			$this->readClosure = function() {
15 14
 				$data = new \stdClass;
16 15
 				foreach ($this as $k => $v)	{
17
-					if (is_scalar($v) || is_null($v) || (is_object($v) && $v instanceof \DateTime))	$data->$k = $v;
16
+					if (is_scalar($v) || is_null($v) || (is_object($v) && $v instanceof \DateTime)) {
17
+						$data->$k = $v;
18
+					}
18 19
 				}
19 20
 				return $data;
20 21
 			};
Please login to merge, or discard this patch.
maphper/Optimiser/MySql.php 1 patch
Braces   +13 added lines, -7 removed lines patch added patch discarded remove patch
@@ -11,16 +11,21 @@  discard block
 block discarded – undo
11 11
 		foreach ($columns as $column) {
12 12
 			$parts = explode('.', $column->Field_name);
13 13
 			$name = $this->quote(end($parts));
14
-			if ($column->Min_value === null && $column->Max_value === null) $this->pdo->query('ALTER TABLE ' . $this->quote($table) . ' DROP COLUMN ' . $name);
15
-			else {
14
+			if ($column->Min_value === null && $column->Max_value === null) {
15
+				$this->pdo->query('ALTER TABLE ' . $this->quote($table) . ' DROP COLUMN ' . $name);
16
+			} else {
16 17
 				$type = $column->Optimal_fieldtype;
17 18
 				if ($column->Max_length < 11) {
18 19
 					//Check for dates
19 20
 					$count = $this->pdo->query('SELECT count(*) as `count` FROM ' . $this->quote($table) . ' WHERE STR_TO_DATE(' . $name . ',\'%Y-%m-%d %H:%i:s\') IS NULL OR STR_TO_DATE(' . $name . ',\'%Y-%m-%d %H:%i:s\') != ' . $name . ' LIMIT 1')->fetch(\PDO::FETCH_OBJ)->count;
20
-					if ($count == 0) $type = 'DATETIME';
21
+					if ($count == 0) {
22
+						$type = 'DATETIME';
23
+					}
21 24
 
22 25
 					$count = $this->pdo->query('SELECT count(*) as `count` FROM ' . $this->quote($table) . ' WHERE STR_TO_DATE(' . $name . ',\'%Y-%m-%d\') IS NULL OR STR_TO_DATE(' . $name . ',\'%Y-%m-%d\') != ' . $name . ' LIMIT 1')->fetch(\PDO::FETCH_OBJ)->count;
23
-					if ($count == 0) $type = 'DATE';
26
+					if ($count == 0) {
27
+						$type = 'DATE';
28
+					}
24 29
 				}
25 30
 
26 31
 				//If it's text, work out if it would be better to be something else
@@ -30,8 +35,7 @@  discard block
 block discarded – undo
30 35
 					if ($count == 0) {
31 36
 						$type = 'INT(11)';
32 37
 						$runAgain = true;
33
-					}
34
-					else {
38
+					} else {
35 39
 						//See if it's decimal
36 40
 						$count = $this->pdo->query('SELECT count(*) FROM ' . $table . ' WHERE concat(\'\', ' . $name . ' * 1) != ' . $name . ')')->fetch(\PDO::FETCH_OBJ)->count;
37 41
 						if ($count == 0) {
@@ -45,6 +49,8 @@  discard block
 block discarded – undo
45 49
 			}
46 50
 		}
47 51
 		//Sometimes a second pass is needed, if a column has gone from varchar -> int(11) a better int type may be needed
48
-		if ($runAgain) $this->optimiseColumns($table);
52
+		if ($runAgain) {
53
+			$this->optimiseColumns($table);
54
+		}
49 55
 	}
50 56
 }
51 57
\ No newline at end of file
Please login to merge, or discard this patch.
maphper/datasource/databaseoptions.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -10,7 +10,9 @@  discard block
 block discarded – undo
10 10
 	}
11 11
 
12 12
 	public function getAdapter() {
13
-		if (!($this->db instanceof \PDO)) return $this->db;
13
+		if (!($this->db instanceof \PDO)) {
14
+			return $this->db;
15
+		}
14 16
 
15 17
 		$adapter = '\\Maphper\\DataSource\\' . ucfirst($this->db->getAttribute(\PDO::ATTR_DRIVER_NAME)) . 'Adapter';
16 18
 
@@ -18,7 +20,9 @@  discard block
 block discarded – undo
18 20
 	}
19 21
 
20 22
 	public function getEditMode() {
21
-		if (!isset($this->options['editmode'])) return false;
23
+		if (!isset($this->options['editmode'])) {
24
+			return false;
25
+		}
22 26
 
23 27
 		return $this->options['editmode'] === true ? Database::EDIT_STRUCTURE | Database::EDIT_INDEX | Database::EDIT_OPTIMISE : $this->options['editmode'];
24 28
 	}
Please login to merge, or discard this patch.
maphper/datasource/mysqladapter.php 1 patch
Braces   +38 added lines, -17 removed lines patch added patch discarded remove patch
@@ -16,10 +16,13 @@  discard block
 block discarded – undo
16 16
 
17 17
 	private function getCachedStmt($sql) {
18 18
 		$queryId = md5($sql);
19
-		if (isset($this->queryCache[$queryId])) $stmt = $this->queryCache[$queryId];
20
-		else {
19
+		if (isset($this->queryCache[$queryId])) {
20
+			$stmt = $this->queryCache[$queryId];
21
+		} else {
21 22
 			$stmt = $this->pdo->prepare($sql, [\PDO::ATTR_CURSOR => \PDO::CURSOR_FWDONLY]);
22
-			if ($stmt) $this->queryCache[$queryId] = $stmt;
23
+			if ($stmt) {
24
+				$this->queryCache[$queryId] = $stmt;
25
+			}
23 26
 		}
24 27
 		return $stmt;
25 28
 	}
@@ -29,15 +32,23 @@  discard block
 block discarded – undo
29 32
 		$args = $query->getArgs();
30 33
         $stmt->execute($args);
31 34
 
32
-		if (strpos(trim($query->getSql()), 'SELECT') === 0) return $stmt->fetchAll(\PDO::FETCH_OBJ);
33
-		else return $stmt;
35
+		if (strpos(trim($query->getSql()), 'SELECT') === 0) {
36
+			return $stmt->fetchAll(\PDO::FETCH_OBJ);
37
+		} else {
38
+			return $stmt;
39
+		}
34 40
 	}
35 41
 
36 42
 	private function getType($val) {
37
-		if ($val instanceof \DateTime) return 'DATETIME';
38
-		else if (is_int($val)) return  'INT(11)';
39
-		else if (is_double($val)) return 'DECIMAL(9,' . strlen($val) - strrpos($val, '.') - 1 . ')';
40
-		else if (is_string($val)) return strlen($val) < 192 ? 'VARCHAR(191)' : 'LONGBLOB';
43
+		if ($val instanceof \DateTime) {
44
+			return 'DATETIME';
45
+		} else if (is_int($val)) {
46
+			return  'INT(11)';
47
+		} else if (is_double($val)) {
48
+			return 'DECIMAL(9,' . strlen($val) - strrpos($val, '.') - 1 . ')';
49
+		} else if (is_string($val)) {
50
+			return strlen($val) < 192 ? 'VARCHAR(191)' : 'LONGBLOB';
51
+		}
41 52
 		return 'VARCHAR(191)';
42 53
 	}
43 54
 
@@ -46,8 +57,11 @@  discard block
 block discarded – undo
46 57
 		$parts = [];
47 58
 		foreach ($primaryKey as $key) {
48 59
 			$pk = $data->$key;
49
-			if ($pk == null) $parts[] = $key . ' INT(11) NOT NULL AUTO_INCREMENT';
50
-			else $parts[] = $key . ' ' . $this->getType($pk) . ' NOT NULL';
60
+			if ($pk == null) {
61
+				$parts[] = $key . ' INT(11) NOT NULL AUTO_INCREMENT';
62
+			} else {
63
+				$parts[] = $key . ' ' . $this->getType($pk) . ' NOT NULL';
64
+			}
51 65
 		}
52 66
 
53 67
 		$pkField = implode(', ', $parts) . ', PRIMARY KEY(' . implode(', ', $primaryKey) . ')';
@@ -58,15 +72,20 @@  discard block
 block discarded – undo
58 72
 		$this->createTable($table, $primaryKey, $data);
59 73
 
60 74
 		foreach ($data as $key => $value) {
61
-			if (is_array($value) || (is_object($value) && !($value instanceof \DateTime))) continue;
62
-			if (in_array($key, $primaryKey)) continue;
75
+			if (is_array($value) || (is_object($value) && !($value instanceof \DateTime))) {
76
+				continue;
77
+			}
78
+			if (in_array($key, $primaryKey)) {
79
+				continue;
80
+			}
63 81
 
64 82
 			$type = $this->getType($value);
65 83
 
66 84
 			try {
67
-				if (!$this->pdo->query('ALTER TABLE ' . $table . ' ADD ' . $this->quote($key) . ' ' . $type)) throw new \Exception('Could not alter table');
68
-			}
69
-			catch (\Exception $e) {
85
+				if (!$this->pdo->query('ALTER TABLE ' . $table . ' ADD ' . $this->quote($key) . ' ' . $type)) {
86
+					throw new \Exception('Could not alter table');
87
+				}
88
+			} catch (\Exception $e) {
70 89
 				$this->pdo->query('ALTER TABLE ' . $table . ' MODIFY ' . $this->quote($key) . ' ' . $type);
71 90
 			}
72 91
 		}
@@ -84,7 +103,9 @@  discard block
 block discarded – undo
84 103
 		$keyName = $this->quote(implode('_', $fields));
85 104
 
86 105
 		$results = $this->pdo->query('SHOW INDEX FROM ' . $this->quote($table) . ' WHERE Key_Name = "' . $keyName . '"');
87
-		if ($results && count($results->fetchAll()) == 0)  $this->pdo->query('CREATE INDEX ' . $keyName . ' ON ' . $this->quote($table) . ' (' . implode(', ', $fields) . ')');
106
+		if ($results && count($results->fetchAll()) == 0) {
107
+			$this->pdo->query('CREATE INDEX ' . $keyName . ' ON ' . $this->quote($table) . ' (' . implode(', ', $fields) . ')');
108
+		}
88 109
 	}
89 110
 
90 111
 	public function optimiseColumns($table) {
Please login to merge, or discard this patch.
maphper/datasource/sqliteadapter.php 1 patch
Braces   +46 added lines, -22 removed lines patch added patch discarded remove patch
@@ -15,10 +15,13 @@  discard block
 block discarded – undo
15 15
 
16 16
     private function getCachedStmt($sql) {
17 17
 		$queryId = md5($sql);
18
-		if (isset($this->queryCache[$queryId])) $stmt = $this->queryCache[$queryId];
19
-		else {
18
+		if (isset($this->queryCache[$queryId])) {
19
+			$stmt = $this->queryCache[$queryId];
20
+		} else {
20 21
 			$stmt = $this->pdo->prepare($sql, [\PDO::ATTR_CURSOR => \PDO::CURSOR_FWDONLY]);
21
-			if ($stmt) $this->queryCache[$queryId] = $stmt;
22
+			if ($stmt) {
23
+				$this->queryCache[$queryId] = $stmt;
24
+			}
22 25
 		}
23 26
 		return $stmt;
24 27
 	}
@@ -29,7 +32,9 @@  discard block
 block discarded – undo
29 32
 		$args = $query->getArgs();
30 33
 
31 34
         //Handle SQLite when PDO_ERRMODE is set to SILENT
32
-        if ($stmt === false) throw new \Exception('Invalid query');
35
+        if ($stmt === false) {
36
+        	throw new \Exception('Invalid query');
37
+        }
33 38
 
34 39
         $stmt->execute($args);
35 40
         if ($stmt->errorCode() !== '00000' && $stmt->errorInfo()[2] == 'database schema has changed') {
@@ -37,8 +42,11 @@  discard block
 block discarded – undo
37 42
 			return $this->query($query);
38 43
         }
39 44
 
40
-        if (substr($query->getSql(), 0, 6) === 'SELECT') return $stmt->fetchAll(\PDO::FETCH_OBJ);
41
-        else return $stmt;
45
+        if (substr($query->getSql(), 0, 6) === 'SELECT') {
46
+        	return $stmt->fetchAll(\PDO::FETCH_OBJ);
47
+        } else {
48
+        	return $stmt;
49
+        }
42 50
 	}
43 51
 	
44 52
 	public function lastInsertId() {
@@ -46,12 +54,19 @@  discard block
 block discarded – undo
46 54
 	}
47 55
 	
48 56
 	private function getType($val) {
49
-		if ($val instanceof \DateTime) return 'DATETIME';
50
-		else if (is_int($val)) return  'INTEGER';
51
-		else if (is_double($val)) return 'DECIMAL(9,' . strlen($val) - strrpos($val, '.') - 1 . ')';
52
-		else if (is_string($val) && strlen($val) < 256) return 'VARCHAR(255)';
53
-		else if (is_string($val) && strlen($val) > 256) return 'LONGBLOG';
54
-		else return 'VARCHAR(255)';		
57
+		if ($val instanceof \DateTime) {
58
+			return 'DATETIME';
59
+		} else if (is_int($val)) {
60
+			return  'INTEGER';
61
+		} else if (is_double($val)) {
62
+			return 'DECIMAL(9,' . strlen($val) - strrpos($val, '.') - 1 . ')';
63
+		} else if (is_string($val) && strlen($val) < 256) {
64
+			return 'VARCHAR(255)';
65
+		} else if (is_string($val) && strlen($val) > 256) {
66
+			return 'LONGBLOG';
67
+		} else {
68
+			return 'VARCHAR(255)';
69
+		}
55 70
 	}
56 71
 
57 72
 	private function tableExists($name) {
@@ -85,8 +100,7 @@  discard block
 block discarded – undo
85 100
 				$this->pdo->query('INSERT INTO ' . $this->quote($table . $affix) . '(' . $columns . ') SELECT ' . $columns . ' FROM ' . $this->quote($table));
86 101
 				$this->pdo->query('DROP TABLE IF EXISTS ' . $table );
87 102
 			}
88
-		}
89
-		catch (\PDOException $e) {
103
+		} catch (\PDOException $e) {
90 104
 			// No data to copy
91 105
 			echo $e->getMessage();
92 106
 		}
@@ -100,8 +114,11 @@  discard block
 block discarded – undo
100 114
 		$parts = [];
101 115
 		foreach ($primaryKey as $key) {
102 116
 			$pk = $data->$key;
103
-			if ($pk == null) $parts[] = $key . ' INTEGER'; 
104
-			else $parts[] = $key . ' ' . $this->getType($pk) . ' NOT NULL';					
117
+			if ($pk == null) {
118
+				$parts[] = $key . ' INTEGER';
119
+			} else {
120
+				$parts[] = $key . ' ' . $this->getType($pk) . ' NOT NULL';
121
+			}
105 122
 		}
106 123
 		
107 124
 		$pkField = implode(', ', $parts) . ', PRIMARY KEY(' . implode(', ', $primaryKey) . ')';
@@ -110,8 +127,12 @@  discard block
 block discarded – undo
110 127
 		$this->pdo->query('CREATE TABLE ' . $table . ' (' . $pkField . ')');
111 128
 					
112 129
 		foreach ($data as $key => $value) {
113
-			if (is_array($value) || (is_object($value) && !($value instanceof \DateTime))) continue;
114
-			if (in_array($key, $primaryKey)) continue;
130
+			if (is_array($value) || (is_object($value) && !($value instanceof \DateTime))) {
131
+				continue;
132
+			}
133
+			if (in_array($key, $primaryKey)) {
134
+				continue;
135
+			}
115 136
 
116 137
 			$type = $this->getType($value);
117 138
 		
@@ -121,10 +142,14 @@  discard block
 block discarded – undo
121 142
 	
122 143
 
123 144
 	public function addIndex($table, array $fields) {
124
-		if (empty($fields)) return false;
145
+		if (empty($fields)) {
146
+			return false;
147
+		}
125 148
 		
126 149
 		//SQLite doesn't support ASC/DESC indexes, remove the keywords
127
-		foreach ($fields as &$field) $field = str_ireplace([' desc', ' asc'], '', $field);
150
+		foreach ($fields as &$field) {
151
+			$field = str_ireplace([' desc', ' asc'], '', $field);
152
+		}
128 153
 		sort($fields);
129 154
 		$fields = array_map('strtolower', $fields);
130 155
 		$fields = array_map('trim', $fields);
@@ -133,8 +158,7 @@  discard block
 block discarded – undo
133 158
 		
134 159
 		try {
135 160
 			$this->pdo->query('CREATE INDEX IF NOT EXISTS  ' . $keyName . ' ON ' . $table . ' (' . implode(', ', $fields) . ')');
136
-		}
137
-		catch (\Exception $e) {
161
+		} catch (\Exception $e) {
138 162
 			
139 163
 		}
140 164
 	}
Please login to merge, or discard this patch.
maphper/lib/selectbuilder.php 1 patch
Braces   +59 added lines, -32 removed lines patch added patch discarded remove patch
@@ -9,17 +9,23 @@  discard block
 block discarded – undo
9 9
 
10 10
 		if (isset($options['offset'])) {
11 11
 			$offset = ' OFFSET ' . $options['offset'];
12
-			if (!$limit) $limit = ' LIMIT  1000';
12
+			if (!$limit) {
13
+				$limit = ' LIMIT  1000';
14
+			}
15
+		} else {
16
+			$offset = '';
13 17
 		}
14
-		else $offset = '';
15 18
 
16 19
 		$order = isset($options['order']) ? ' ORDER BY ' . $options['order'] : '';
17 20
 		return new Query('SELECT * FROM ' . $table . ' ' . $where . $order . $limit . $offset, $args);
18 21
 	}
19 22
 
20 23
 	public function aggregate($table, $function, $field, $where, $args, $group) {
21
-		if ($group == true) $groupBy = ' GROUP BY ' . $field;
22
-		else $groupBy = '';
24
+		if ($group == true) {
25
+			$groupBy = ' GROUP BY ' . $field;
26
+		} else {
27
+			$groupBy = '';
28
+		}
23 29
 		return new Query('SELECT ' . $function . '(' . $field . ') as val, ' . $field . '   FROM ' . $table . ($where[0] != null ? ' WHERE ' : '') . implode(' AND ', $where) . ' ' . $groupBy, $args);
24 30
 	}
25 31
 
@@ -31,70 +37,91 @@  discard block
 block discarded – undo
31 37
 
32 38
 		foreach ($fields as $key => $value) {
33 39
             if ($value instanceof \DateTime) {
34
-    			if ($value->format('H:i:s')  == '00:00:00') $value = $value->format('Y-m-d');
35
-    			else $value = $value->format('Y-m-d H:i:s');
40
+    			if ($value->format('H:i:s')  == '00:00:00') {
41
+    				$value = $value->format('Y-m-d');
42
+    			} else {
43
+    				$value = $value->format('Y-m-d H:i:s');
44
+    			}
36 45
     		}
37 46
 
38 47
 			if (is_numeric($key) && is_array($value)) {
39 48
 				$result = $this->createSql($value, $key);
40
-				foreach ($result['args'] as $arg_key => $arg) $args[$arg_key] = $arg;
41
-				foreach ($result['sql'] as $arg) $sql[] = $arg;
42
-			}
43
-			else if (\Maphper\Maphper::FIND_BETWEEN & $mode) {
49
+				foreach ($result['args'] as $arg_key => $arg) {
50
+					$args[$arg_key] = $arg;
51
+				}
52
+				foreach ($result['sql'] as $arg) {
53
+					$sql[] = $arg;
54
+				}
55
+			} else if (\Maphper\Maphper::FIND_BETWEEN & $mode) {
44 56
 				$sql[] = $key . '>= :' . $key . 'from';
45 57
 				$sql[] = $key . ' <= :' . $key . 'to';
46 58
 
47 59
 				$args[$key . 'from'] = $value[0];
48 60
 				$args[$key . 'to'] = $value[1];
49
-			}
50
-			else if (!is_numeric($key) && is_array($value)) {
61
+			} else if (!is_numeric($key) && is_array($value)) {
51 62
 				$inSql = [];
52 63
 				$count = count($value);
53 64
 				for ($i = 0; $i < $count; $i++) {
54 65
 					$args[$key . $i] = $value[$i];
55 66
 					$inSql[] = ':' . $key . $i;
56 67
 				}
57
-				if (count($inSql) == 0) return [];
58
-				else $sql[] = $key . ' IN ( ' .  implode(', ', $inSql) . ')';
59
-			}
60
-			else if ($value === NULL) {
68
+				if (count($inSql) == 0) {
69
+					return [];
70
+				} else {
71
+					$sql[] = $key . ' IN ( ' .  implode(', ', $inSql) . ')';
72
+				}
73
+			} else if ($value === NULL) {
61 74
 				$nullSql = $key . ' IS ';
62
-				if (\Maphper\Maphper::FIND_NOT & $mode) $nullSql .= 'NOT ';
75
+				if (\Maphper\Maphper::FIND_NOT & $mode) {
76
+					$nullSql .= 'NOT ';
77
+				}
63 78
 				$sql[] = $nullSql . 'NULL';
64
-			}
65
-			else {
79
+			} else {
66 80
 
67 81
 				if (\Maphper\Maphper::FIND_LIKE & $mode) {
68 82
 					$operator = 'LIKE';
69 83
 					$value = '%' . $value . '%';
70
-				}
71
-				else if (\Maphper\Maphper::FIND_STARTS & $mode) {
84
+				} else if (\Maphper\Maphper::FIND_STARTS & $mode) {
72 85
 					$operator = 'LIKE';
73 86
 					$value = $value . '%';
87
+				} else {
88
+					$operator = $this->getOperator($mode);
74 89
 				}
75
-				else $operator = $this->getOperator($mode);
76 90
 
77 91
 				$args[$key] = $value;
78 92
 				$sql[] = $key . ' ' . $operator . ' :' . $key;
79 93
 			}
80 94
 		}
81 95
 
82
-		if (\Maphper\Maphper::FIND_OR & $mode) $query = implode(' OR  ', $sql);
83
-		else $query = implode(' AND ', $sql);
84
-		if (!empty($query)) $query = '(' . $query . ')';
96
+		if (\Maphper\Maphper::FIND_OR & $mode) {
97
+			$query = implode(' OR  ', $sql);
98
+		} else {
99
+			$query = implode(' AND ', $sql);
100
+		}
101
+		if (!empty($query)) {
102
+			$query = '(' . $query . ')';
103
+		}
85 104
 		return ['args' => $args, 'sql' => [$query]];
86 105
 	}
87 106
 
88 107
     private function getOperator($mode) {
89 108
         $operator = "";
90 109
 
91
-        if (\Maphper\Maphper::FIND_NOCASE & $mode) $operator = 'LIKE';
92
-        else if (\Maphper\Maphper::FIND_BIT & $mode) $operator = '&';
93
-        else if (\Maphper\Maphper::FIND_GREATER & $mode) $operator = '>';
94
-        else if (\Maphper\Maphper::FIND_LESS & $mode) $operator = '<';
95
-        else if (\Maphper\Maphper::FIND_NOT & $mode) $operator = '!=';
96
-
97
-        if (\Maphper\Maphper::FIND_EXACT & $mode) $operator .= '=';
110
+        if (\Maphper\Maphper::FIND_NOCASE & $mode) {
111
+        	$operator = 'LIKE';
112
+        } else if (\Maphper\Maphper::FIND_BIT & $mode) {
113
+        	$operator = '&';
114
+        } else if (\Maphper\Maphper::FIND_GREATER & $mode) {
115
+        	$operator = '>';
116
+        } else if (\Maphper\Maphper::FIND_LESS & $mode) {
117
+        	$operator = '<';
118
+        } else if (\Maphper\Maphper::FIND_NOT & $mode) {
119
+        	$operator = '!=';
120
+        }
121
+
122
+        if (\Maphper\Maphper::FIND_EXACT & $mode) {
123
+        	$operator .= '=';
124
+        }
98 125
 
99 126
         return $operator;
100 127
     }
Please login to merge, or discard this patch.
maphper/datasource/database.php 1 patch
Braces   +58 added lines, -30 removed lines patch added patch discarded remove patch
@@ -31,7 +31,9 @@  discard block
 block discarded – undo
31 31
 
32 32
 		$this->alterDb = $this->options->getEditMode();
33 33
 
34
-		if (self::EDIT_OPTIMISE & $this->alterDb && rand(0,500) == 1) $this->adapter->optimiseColumns($table);
34
+		if (self::EDIT_OPTIMISE & $this->alterDb && rand(0,500) == 1) {
35
+			$this->adapter->optimiseColumns($table);
36
+		}
35 37
 	}
36 38
 
37 39
 	public function getPrimaryKey() {
@@ -47,20 +49,24 @@  discard block
 block discarded – undo
47 49
 		if (!isset($this->cache[$id])) {
48 50
 			try {
49 51
 				$result = $this->adapter->query($this->selectBuilder->select($this->table, [$this->getPrimaryKey()[0] . ' = :id'], [':id' => $id], ['limit' => 1]));
50
-			}
51
-			catch (\Exception $e) {
52
+			} catch (\Exception $e) {
52 53
 				$this->errors[] = $e;
53 54
 			}
54 55
 
55
-			if (isset($result[0])) 	$this->cache[$id] = $result[0];
56
-			else return null;
56
+			if (isset($result[0])) {
57
+				$this->cache[$id] = $result[0];
58
+			} else {
59
+				return null;
60
+			}
57 61
 		}
58 62
 		return $this->cache[$id];
59 63
 	}
60 64
 
61 65
 	public function findAggregate($function, $field, $group = null, array $criteria = [], array $options = []) {
62 66
 		//Cannot count/sum/max multiple fields, pick the first one. This should only come into play when trying to count() a mapper with multiple primary keys
63
-		if (is_array($field)) $field = $field[0];
67
+		if (is_array($field)) {
68
+			$field = $field[0];
69
+		}
64 70
 		$query = $this->selectBuilder->createSql($criteria, \Maphper\Maphper::FIND_EXACT | \Maphper\Maphper::FIND_AND);
65 71
 
66 72
 		try {
@@ -68,22 +74,27 @@  discard block
 block discarded – undo
68 74
 			$this->addIndex(explode(',', $group));
69 75
 			$result = $this->adapter->query($this->selectBuilder->aggregate($this->table, $function, $field, $query['sql'], $query['args'], $group));
70 76
 
71
-			if (isset($result[0]) && $group == null) return $result[0]->val;
72
-			else if ($group != null) {
77
+			if (isset($result[0]) && $group == null) {
78
+				return $result[0]->val;
79
+			} else if ($group != null) {
73 80
 				$ret = [];
74
-				foreach ($result as $res) $ret[$res->$field] = $res->val;
81
+				foreach ($result as $res) {
82
+					$ret[$res->$field] = $res->val;
83
+				}
75 84
 				return $ret;
85
+			} else {
86
+				return 0;
76 87
 			}
77
-			else return 0;
78
-		}
79
-		catch (\Exception $e) {
88
+		} catch (\Exception $e) {
80 89
 			$this->errors[] = $e;
81 90
 			return $group ? [] : 0;
82 91
 		}
83 92
 	}
84 93
 
85 94
 	private function addIndex($args) {
86
-		if (self::EDIT_INDEX & $this->alterDb) $this->adapter->addIndex($this->table, $args);
95
+		if (self::EDIT_INDEX & $this->alterDb) {
96
+			$this->adapter->addIndex($this->table, $args);
97
+		}
87 98
 	}
88 99
 
89 100
 	public function findByField(array $fields, $options = []) {
@@ -91,7 +102,9 @@  discard block
 block discarded – undo
91 102
 		if (!isset($this->resultCache[$cacheId])) {
92 103
 			$query = $this->selectBuilder->createSql($fields, \Maphper\Maphper::FIND_EXACT | \Maphper\Maphper::FIND_AND);
93 104
 
94
-			if (!isset($options['order'])) $options['order'] = $this->defaultSort;
105
+			if (!isset($options['order'])) {
106
+				$options['order'] = $this->defaultSort;
107
+			}
95 108
 
96 109
 			$query['sql'] = array_filter($query['sql']);
97 110
 
@@ -99,8 +112,7 @@  discard block
 block discarded – undo
99 112
 				$this->resultCache[$cacheId] = $this->adapter->query($this->selectBuilder->select($this->table, $query['sql'], $query['args'], $options));
100 113
 				$this->addIndex(array_keys($query['args']));
101 114
 				$this->addIndex(explode(',', $options['order']));
102
-			}
103
-			catch (\Exception $e) {
115
+			} catch (\Exception $e) {
104 116
 				$this->errors[] = $e;
105 117
 				$this->resultCache[$cacheId] = [];
106 118
 			}
@@ -109,9 +121,14 @@  discard block
 block discarded – undo
109 121
 	}
110 122
 
111 123
 	public function deleteByField(array $fields, array $options = [], $mode = null) {
112
-		if ($mode == null) $mode = \Maphper\Maphper::FIND_EXACT | \Maphper\Maphper::FIND_AND;
113
-		if (isset($options['limit']) != null) $limit = ' LIMIT ' . $options['limit'];
114
-		else $limit = '';
124
+		if ($mode == null) {
125
+			$mode = \Maphper\Maphper::FIND_EXACT | \Maphper\Maphper::FIND_AND;
126
+		}
127
+		if (isset($options['limit']) != null) {
128
+			$limit = ' LIMIT ' . $options['limit'];
129
+		} else {
130
+			$limit = '';
131
+		}
115 132
 
116 133
 		$query = $this->selectBuilder->createSql($fields, $mode);
117 134
         $query['sql'] = array_filter($query['sql']);
@@ -142,10 +159,13 @@  discard block
 block discarded – undo
142 159
             $result = $this->insert($this->table, $this->primaryKey, $data);
143 160
 
144 161
 			//If there was an error but PDO is silent, trigger the catch block anyway
145
-			if ($result->errorCode() !== '00000') throw new \Exception('Could not insert into ' . $this->table);
146
-		}
147
-		catch (\Exception $e) {
148
-			if (!$tryagain) throw $e;
162
+			if ($result->errorCode() !== '00000') {
163
+				throw new \Exception('Could not insert into ' . $this->table);
164
+			}
165
+		} catch (\Exception $e) {
166
+			if (!$tryagain) {
167
+				throw $e;
168
+			}
149 169
 
150 170
 			$this->adapter->alterDatabase($this->table, $this->primaryKey, $data);
151 171
 			$this->save($data, false);
@@ -158,28 +178,34 @@  discard block
 block discarded – undo
158 178
 	}
159 179
 
160 180
     private function updatePK($data, $new) {
161
-        if ($new && count($this->primaryKey) == 1) $data->{$this->primaryKey[0]} = $this->adapter->lastInsertId();
181
+        if ($new && count($this->primaryKey) == 1) {
182
+        	$data->{$this->primaryKey[0]} = $this->adapter->lastInsertId();
183
+        }
162 184
     }
163 185
 
164 186
     private function checkIfUpdateWorked($data) {
165 187
         $updateWhere = $this->crudBuilder->update($this->table, $this->primaryKey, $data);
166 188
         $matched = $this->findByField($updateWhere->getArgs());
167 189
 
168
-        if (count($matched) == 0) throw new \InvalidArgumentException('Record inserted into table ' . $this->table . ' fails table constraints');
190
+        if (count($matched) == 0) {
191
+        	throw new \InvalidArgumentException('Record inserted into table ' . $this->table . ' fails table constraints');
192
+        }
169 193
     }
170 194
 
171 195
     private function updateCache($data) {
172 196
         $pkValue = $data->{$this->primaryKey[0]};
173
-		if (isset($this->cache[$pkValue])) $this->cache[$pkValue] = (object) array_merge((array)$this->cache[$pkValue], (array)$data);
174
-		else $this->cache[$pkValue] = $data;
197
+		if (isset($this->cache[$pkValue])) {
198
+			$this->cache[$pkValue] = (object) array_merge((array)$this->cache[$pkValue], (array)$data);
199
+		} else {
200
+			$this->cache[$pkValue] = $data;
201
+		}
175 202
     }
176 203
 
177 204
 	private function insert($table, array $primaryKey, $data) {
178 205
 		$error = 0;
179 206
 		try {
180 207
 			$result = $this->adapter->query($this->crudBuilder->insert($table, $data));
181
-		}
182
-		catch (\Exception $e) {
208
+		} catch (\Exception $e) {
183 209
 			$error = 1;
184 210
 		}
185 211
 
@@ -192,7 +218,9 @@  discard block
 block discarded – undo
192 218
 
193 219
     private function tryUpdate($table, array $primaryKey, $data) {
194 220
         $result = $this->adapter->query($this->crudBuilder->update($table, $primaryKey, $data));
195
-        if ($result->rowCount() === 0) $this->checkIfUpdateWorked($data);
221
+        if ($result->rowCount() === 0) {
222
+        	$this->checkIfUpdateWorked($data);
223
+        }
196 224
 
197 225
         return $result;
198 226
     }
Please login to merge, or discard this patch.