| @@ -20,8 +20,7 @@ | ||
| 20 | 20 |  		if (count($this->pk) == 1) { | 
| 21 | 21 | $pk = end($this->pk); | 
| 22 | 22 | return $this->array[$this->iterator]->$pk; | 
| 23 | - } | |
| 24 | -		else { | |
| 23 | +		} else { | |
| 25 | 24 | $current = $this->current(); | 
| 26 | 25 |  			return array_map(function($pkName) use ($current) { | 
| 27 | 26 | return $current->$pkName; | 
| @@ -19,10 +19,15 @@ discard block | ||
| 19 | 19 | //For dates with times set, search on time, if the time is not set, search on date only. | 
| 20 | 20 | //E.g. searching for all records posted on '2015-11-14' should return all records that day, not just the ones posted at 00:00:00 on that day | 
| 21 | 21 |  			if ($value instanceof \DateTime) { | 
| 22 | -				if ($value->format('H:i:s')  == '00:00:00') $value = $value->format('Y-m-d'); | |
| 23 | -				else $value = $value->format('Y-m-d H:i:s'); | |
| 22 | +				if ($value->format('H:i:s')  == '00:00:00') { | |
| 23 | +					$value = $value->format('Y-m-d'); | |
| 24 | +				} else { | |
| 25 | +					$value = $value->format('Y-m-d H:i:s'); | |
| 26 | + } | |
| 27 | + } | |
| 28 | +			if (is_object($value)) { | |
| 29 | + continue; | |
| 24 | 30 | } | 
| 25 | - if (is_object($value)) continue; | |
| 26 | 31 |  			if ($prependField){ | 
| 27 | 32 | $sql[] = $this->quote($field) . ' = :' . $field; | 
| 28 | 33 |  			} else { | 
| @@ -41,7 +46,9 @@ discard block | ||
| 41 | 46 |  	public function update($table, array $primaryKey, $data) { | 
| 42 | 47 | $query = $this->buildSaveQuery($data, true); | 
| 43 | 48 | $where = []; | 
| 44 | - foreach($primaryKey as $field) $where[] = $this->quote($field) . ' = :' . $field; | |
| 49 | +		foreach($primaryKey as $field) { | |
| 50 | + $where[] = $this->quote($field) . ' = :' . $field; | |
| 51 | + } | |
| 45 | 52 |  		return new Query('UPDATE ' . $this->quote($table) . ' SET ' . implode(', ', $query['sql']). ' WHERE '. implode(' AND ', $where), $query['args']); | 
| 46 | 53 | } | 
| 47 | 54 | } | 
| @@ -8,7 +8,7 @@ | ||
| 8 | 8 |  	public function delete($table, $criteria, $args, $limit = null, $offset = null, $order = null) { | 
| 9 | 9 | $limit = $limit ? ' LIMIT ' . $limit : ''; | 
| 10 | 10 | $offset = $offset ? ' OFFSET ' . $offset : ''; | 
| 11 | - $order = $order ? ' ORDER BY ' . $order : ''; | |
| 11 | + $order = $order ? ' ORDER BY ' . $order : ''; | |
| 12 | 12 |  		return new Query('DELETE FROM ' . $table . ' WHERE ' . ($criteria ?: '1 = 1 ') . $order . $limit . $offset, $args); | 
| 13 | 13 | } | 
| 14 | 14 | |
| @@ -25,8 +25,11 @@ | ||
| 25 | 25 | |
| 26 | 26 |  	public function offsetGet($key) { | 
| 27 | 27 | $depth = $this->getDepth()+1; | 
| 28 | - if (count($this->primaryKey)-1 == $depth) return $this->mapper->filter([$this->primaryKey[$depth] => $key])->item(0); | |
| 29 | - else return new MultiPk($this->mapper, $key, $this->primaryKey, $this); | |
| 28 | +		if (count($this->primaryKey)-1 == $depth) { | |
| 29 | + return $this->mapper->filter([$this->primaryKey[$depth] => $key])->item(0); | |
| 30 | +		} else { | |
| 31 | + return new MultiPk($this->mapper, $key, $this->primaryKey, $this); | |
| 32 | + } | |
| 30 | 33 | } | 
| 31 | 34 | |
| 32 | 35 |  	public function offsetSet($key, $value) { | 
| @@ -4,7 +4,7 @@ | ||
| 4 | 4 | private $parent; | 
| 5 | 5 | private $primaryKey; | 
| 6 | 6 | private $lookup; | 
| 7 | - private $mapper; | |
| 7 | + private $mapper; | |
| 8 | 8 | |
| 9 | 9 |  	public function __construct(Maphper $mapper, $lookup, array $primaryKey, MultiPk $parent = null) { | 
| 10 | 10 | $this->parent = $parent; | 
| @@ -6,7 +6,9 @@ discard block | ||
| 6 | 6 | private $localField; | 
| 7 | 7 | |
| 8 | 8 |  	public function __construct(\Maphper\Maphper $mapper, $parentField, $localField, array $critiera = []) { | 
| 9 | - if ($critiera) $mapper->filter($critiera); | |
| 9 | +		if ($critiera) { | |
| 10 | + $mapper->filter($critiera); | |
| 11 | + } | |
| 10 | 12 | $this->mapper = $mapper; | 
| 11 | 13 | $this->parentField = $parentField; | 
| 12 | 14 | $this->localField = $localField; | 
| @@ -14,17 +16,24 @@ discard block | ||
| 14 | 16 | |
| 15 | 17 | |
| 16 | 18 |  	public function getData($parentObject) { | 
| 17 | -		if (!isset($parentObject->{$this->parentField})) $mapper = $this->mapper; | |
| 18 | -		else $mapper = $this->mapper->filter([$this->localField => $parentObject->{$this->parentField}]); | |
| 19 | +		if (!isset($parentObject->{$this->parentField})) { | |
| 20 | + $mapper = $this->mapper; | |
| 21 | +		} else { | |
| 22 | +			$mapper = $this->mapper->filter([$this->localField => $parentObject->{$this->parentField}]); | |
| 23 | + } | |
| 19 | 24 | |
| 20 | 25 | return $mapper; | 
| 21 | 26 | } | 
| 22 | 27 | |
| 23 | 28 | |
| 24 | 29 |  	public function overwrite($key, &$mapper) { | 
| 25 | -		if (!isset($key->{$this->parentField})) return false; | |
| 30 | +		if (!isset($key->{$this->parentField})) { | |
| 31 | + return false; | |
| 32 | + } | |
| 26 | 33 |  		foreach ($mapper as $k => $val) { | 
| 27 | -			if (!empty($val->{$this->localField}) && $val->{$this->localField} == $key->{$this->parentField}) continue; | |
| 34 | +			if (!empty($val->{$this->localField}) && $val->{$this->localField} == $key->{$this->parentField}) { | |
| 35 | + continue; | |
| 36 | + } | |
| 28 | 37 |  			$val->{$this->localField} = $key->{$this->parentField}; | 
| 29 | 38 | $this->mapper[] = $val; | 
| 30 | 39 | } | 
| @@ -31,7 +31,9 @@ discard block | ||
| 31 | 31 |  	public function overwrite($parentObject, &$data) { | 
| 32 | 32 | $this->results = $data; | 
| 33 | 33 | $this->object = $parentObject; | 
| 34 | - foreach ($data as $dt) $this[] = $dt; | |
| 34 | +		foreach ($data as $dt) { | |
| 35 | + $this[] = $dt; | |
| 36 | + } | |
| 35 | 37 | } | 
| 36 | 38 | |
| 37 | 39 | //bit hacky, breaking encapsulation, but simplest way to work out the info for the other side of the many:many relationship. | 
| @@ -92,15 +94,13 @@ discard block | ||
| 92 | 94 |  			$record->$valueField = $this->object->{$relatedField}; | 
| 93 | 95 | $this->intermediateMapper[] = $record; | 
| 94 | 96 | |
| 95 | - } | |
| 96 | -		else { | |
| 97 | +		} else { | |
| 97 | 98 | $record = $value; | 
| 98 | 99 |  			if (isset($record->{$this->parentField}) && isset($value->{$this->intermediateName}) && | 
| 99 | 100 |  					$record->{$this->parentField} == $value->{$this->intermediateName}->{$this->localField} && | 
| 100 | 101 |  					$record->$valueField == $this->object->{$relatedField}) { | 
| 101 | 102 | return; | 
| 102 | - } | |
| 103 | -			else { | |
| 103 | +			} else { | |
| 104 | 104 |  				$record->{$this->parentField} = $value->{$this->intermediateName}->{$this->localField}; | 
| 105 | 105 |  				$record->$valueField = $this->object->{$relatedField}; | 
| 106 | 106 | $this->intermediateMapper[] = $record; | 
| @@ -74,7 +74,7 @@ | ||
| 74 | 74 | |
| 75 | 75 |  	public function __get($name) { | 
| 76 | 76 | if ($this->lazyLoad()) return $this->lazyLoad()->$name; | 
| 77 | - else return null; | |
| 77 | + else return null; | |
| 78 | 78 | } | 
| 79 | 79 | |
| 80 | 80 |  	public function __isset($name) { | 
| @@ -30,7 +30,9 @@ discard block | ||
| 30 | 30 |  	private function lazyLoad() { | 
| 31 | 31 |  		if (!isset($this->data)) { | 
| 32 | 32 | |
| 33 | -			if ($this->parentObject == null) throw new \Exception('Error, no object set'); | |
| 33 | +			if ($this->parentObject == null) { | |
| 34 | +				throw new \Exception('Error, no object set'); | |
| 35 | + } | |
| 34 | 36 | |
| 35 | 37 | $this->eagerLoad(); | 
| 36 | 38 | |
| @@ -47,8 +49,11 @@ discard block | ||
| 47 | 49 | |
| 48 | 50 | $recordsToLoad = array_unique($recordsToLoad); | 
| 49 | 51 | //Fetch the results so they're in the cache for the corresponding maphper object | 
| 50 | - if ($this->criteria) $results = $this->mapper->filter($this->criteira)->filter([$this->localField => $recordsToLoad]); | |
| 51 | - else $results = $this->mapper->filter([$this->localField => $recordsToLoad]); | |
| 52 | +		if ($this->criteria) { | |
| 53 | + $results = $this->mapper->filter($this->criteira)->filter([$this->localField => $recordsToLoad]); | |
| 54 | +		} else { | |
| 55 | + $results = $this->mapper->filter([$this->localField => $recordsToLoad]); | |
| 56 | + } | |
| 52 | 57 | |
| 53 | 58 | $cache = []; | 
| 54 | 59 |  		foreach ($results as $result) { | 
| @@ -68,13 +73,18 @@ discard block | ||
| 68 | 73 | } | 
| 69 | 74 | |
| 70 | 75 |  	public function __call($func, array $args = []) { | 
| 71 | - if ($this->lazyLoad() == null) return ''; | |
| 76 | +		if ($this->lazyLoad() == null) { | |
| 77 | + return ''; | |
| 78 | + } | |
| 72 | 79 | return call_user_func_array([$this->lazyLoad(), $func], $args); | 
| 73 | 80 | } | 
| 74 | 81 | |
| 75 | 82 |  	public function __get($name) { | 
| 76 | - if ($this->lazyLoad()) return $this->lazyLoad()->$name; | |
| 77 | - else return null; | |
| 83 | +		if ($this->lazyLoad()) { | |
| 84 | + return $this->lazyLoad()->$name; | |
| 85 | +		} else { | |
| 86 | + return null; | |
| 87 | + } | |
| 78 | 88 | } | 
| 79 | 89 | |
| 80 | 90 |  	public function __isset($name) { | 
| @@ -7,17 +7,17 @@ | ||
| 7 | 7 | private $intermediateName; | 
| 8 | 8 | |
| 9 | 9 |    public function __construct(\Maphper\Iterator $iterator, $intermediateName = null) { | 
| 10 | - $this->iterator = $iterator; | |
| 11 | - $this->intermediateName = $intermediateName; | |
| 10 | + $this->iterator = $iterator; | |
| 11 | + $this->intermediateName = $intermediateName; | |
| 12 | 12 | } | 
| 13 | 13 | |
| 14 | 14 |    public function current() { | 
| 15 | -    if ($this->intermediateName) return $this->iterator->current()->{$this->intermediateName}; | |
| 15 | +	if ($this->intermediateName) return $this->iterator->current()->{$this->intermediateName}; | |
| 16 | 16 | return $this->iterator->current(); | 
| 17 | 17 | } | 
| 18 | 18 | |
| 19 | 19 |  	public function key() { | 
| 20 | - return $this->iterator->key(); | |
| 20 | + return $this->iterator->key(); | |
| 21 | 21 | } | 
| 22 | 22 | |
| 23 | 23 |  	public function next() { | 
| @@ -12,7 +12,9 @@ | ||
| 12 | 12 | } | 
| 13 | 13 | |
| 14 | 14 |    public function current() { | 
| 15 | -    if ($this->intermediateName) return $this->iterator->current()->{$this->intermediateName}; | |
| 15 | +    if ($this->intermediateName) { | |
| 16 | +    	return $this->iterator->current()->{$this->intermediateName}; | |
| 17 | + } | |
| 16 | 18 | return $this->iterator->current(); | 
| 17 | 19 | } | 
| 18 | 20 | |
| @@ -6,25 +6,35 @@ | ||
| 6 | 6 | |
| 7 | 7 |  	public function replaceDates($obj, $reset = true) { | 
| 8 | 8 | //prevent infinite recursion, only process each object once | 
| 9 | - if ($this->checkCache($obj, $reset)) return $obj; | |
| 9 | +		if ($this->checkCache($obj, $reset)) { | |
| 10 | + return $obj; | |
| 11 | + } | |
| 10 | 12 | |
| 11 | - if (is_array($obj) || (is_object($obj) && ($obj instanceof \Iterator))) foreach ($obj as &$o) $o = $this->replaceDates($o, false); | |
| 13 | +		if (is_array($obj) || (is_object($obj) && ($obj instanceof \Iterator))) { | |
| 14 | + foreach ($obj as &$o) $o = $this->replaceDates($o, false); | |
| 15 | + } | |
| 12 | 16 |  		if (is_string($obj) && isset($obj[0]) && is_numeric($obj[0]) && strlen($obj) <= 20) { | 
| 13 | 17 |  			try { | 
| 14 | 18 | $date = new \DateTime($obj); | 
| 15 | -				if ($date->format('Y-m-d H:i:s') == substr($obj, 0, 20) || $date->format('Y-m-d') == substr($obj, 0, 10)) $obj = $date; | |
| 16 | - } | |
| 17 | -			catch (\Exception $e) {	//Doesn't need to do anything as the try/catch is working out whether $obj is a date | |
| 19 | +				if ($date->format('Y-m-d H:i:s') == substr($obj, 0, 20) || $date->format('Y-m-d') == substr($obj, 0, 10)) { | |
| 20 | + $obj = $date; | |
| 21 | + } | |
| 22 | +			} catch (\Exception $e) {	//Doesn't need to do anything as the try/catch is working out whether $obj is a date | |
| 18 | 23 | } | 
| 19 | 24 | } | 
| 20 | 25 | return $obj; | 
| 21 | 26 | } | 
| 22 | 27 | |
| 23 | 28 |  	private function checkCache($obj, $reset) { | 
| 24 | - if ($reset) $this->processCache = new \SplObjectStorage(); | |
| 29 | +		if ($reset) { | |
| 30 | + $this->processCache = new \SplObjectStorage(); | |
| 31 | + } | |
| 25 | 32 | |
| 26 | - if (is_object($obj) && $this->processCache->contains($obj)) return $obj; | |
| 27 | - else if (is_object($obj)) $this->processCache->attach($obj, true); | |
| 33 | +		if (is_object($obj) && $this->processCache->contains($obj)) { | |
| 34 | + return $obj; | |
| 35 | +		} else if (is_object($obj)) { | |
| 36 | + $this->processCache->attach($obj, true); | |
| 37 | + } | |
| 28 | 38 | |
| 29 | 39 | return false; | 
| 30 | 40 | } | 
| @@ -23,7 +23,9 @@ | ||
| 23 | 23 |  		foreach ($relations as $name => $relation) { | 
| 24 | 24 |  			if (isset($object->$name) && !($object->$name instanceof \Maphper\Relation) ) { | 
| 25 | 25 | //After overwriting the relation, does the parent object ($object) need overwriting as well? | 
| 26 | - if ($relation->overwrite($object, $object->$name)) $this->parent[] = $object; | |
| 26 | +				if ($relation->overwrite($object, $object->$name)) { | |
| 27 | + $this->parent[] = $object; | |
| 28 | + } | |
| 27 | 29 | } | 
| 28 | 30 | |
| 29 | 31 | $object->$name = $relation->getData($object, $siblings); |