ArrayFilter::processFilter() - Code Metrics - Inspection of "Move array filter functions into their own class" - Level-2/Maphper - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 02cf1a...e288dc )

by Richard

created 2017-12-30 21:18 UTC

ArrayFilter::processFilter() B

↳ Parent: ArrayFilter

Complexity

Conditions	11
Paths	9

Size

Total Lines	9
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
eloc	8
nc	9
nop	3
dl	0
loc	9
rs	7.0499
c	0
b	0
f	0

How to fix Complexity

<?php
namespace Maphper\Lib;
use Maphper\Maphper;

class ArrayFilter {
    private $array;

    public function __construct(array $array) {
        $this->array = $array;
    }

    public function filter($fields) {
        $filteredArray = array_filter($this->array, $this->getSearchFieldFunction($fields, \Maphper\Maphper::FIND_EXACT | \Maphper\Maphper::FIND_AND));
        // Need to reset indexes
        $filteredArray = array_values($filteredArray);
        return $filteredArray;
    }

    private function getSearchFieldFunction($fields, $mode) {
        return function ($data) use ($fields, $mode) {
            foreach ($fields as $key => $val) {
                $currentFieldResult = $this->getIfFieldMatches($key, $val, $data, $mode);

                if (Maphper::FIND_OR & $mode && $currentFieldResult === true) return true;
                else if (!(Maphper::FIND_OR & $mode) && $currentFieldResult === false) return false;
            }
            return !(Maphper::FIND_OR & $mode);
        };
    }

    private function getIfFieldMatches($key, $val, $data, $mode) {
        if (is_numeric($key) && is_array($val)) {
            return $this->getSearchFieldFunction($val, $key)($data);
        }
        else if (!isset($data->$key)) return false;
        else if (!(Maphper::FIND_BETWEEN & $mode) && !is_numeric($key) && is_array($val))
            return in_array($data->$key, $val);
        else
            return $this->processFilter($mode, $val, $data->$key);
    }

    private function processFilter($mode, $expected, $actual) {
        if (Maphper::FIND_NOT & $mode) return $expected != $actual;
        else if (Maphper::FIND_GREATER & $mode && Maphper::FIND_EXACT & $mode) return $expected <= $actual;
        else if (Maphper::FIND_LESS & $mode && Maphper::FIND_EXACT & $mode) return $expected >= $actual;
        else if (Maphper::FIND_GREATER & $mode) return $expected < $actual;
        else if (Maphper::FIND_LESS & $mode) return $expected > $actual;
        else if (Maphper::FIND_BETWEEN & $mode) return $expected[0] <= $actual && $actual <= $expected[1];
        else if (Maphper::FIND_NOCASE & $mode) return strtolower($expected) == strtolower($actual);
        return $expected == $actual;
    }
}


1			<?php
2			namespace Maphper\Lib;
3			use Maphper\Maphper;
4
5			class ArrayFilter {
6			private $array;
7
8			public function __construct(array $array) {
9			$this->array = $array;
10			}
11
12			public function filter($fields) {
13			$filteredArray = array_filter($this->array, $this->getSearchFieldFunction($fields, \Maphper\Maphper::FIND_EXACT \| \Maphper\Maphper::FIND_AND));
14			// Need to reset indexes
15			$filteredArray = array_values($filteredArray);
16			return $filteredArray;
17			}
18
19			private function getSearchFieldFunction($fields, $mode) {
20			return function ($data) use ($fields, $mode) {
21			foreach ($fields as $key => $val) {
22			$currentFieldResult = $this->getIfFieldMatches($key, $val, $data, $mode);
23
24			if (Maphper::FIND_OR & $mode && $currentFieldResult === true) return true;
25			else if (!(Maphper::FIND_OR & $mode) && $currentFieldResult === false) return false;
26			}
27			return !(Maphper::FIND_OR & $mode);
28			};
29			}
30
31			private function getIfFieldMatches($key, $val, $data, $mode) {
32			if (is_numeric($key) && is_array($val)) {
33			return $this->getSearchFieldFunction($val, $key)($data);
34			}
35			else if (!isset($data->$key)) return false;
36			else if (!(Maphper::FIND_BETWEEN & $mode) && !is_numeric($key) && is_array($val))
37			return in_array($data->$key, $val);
38			else
39			return $this->processFilter($mode, $val, $data->$key);
40			}
41
42			private function processFilter($mode, $expected, $actual) {
43			if (Maphper::FIND_NOT & $mode) return $expected != $actual;
44			else if (Maphper::FIND_GREATER & $mode && Maphper::FIND_EXACT & $mode) return $expected <= $actual;
45			else if (Maphper::FIND_LESS & $mode && Maphper::FIND_EXACT & $mode) return $expected >= $actual;
46			else if (Maphper::FIND_GREATER & $mode) return $expected < $actual;
47			else if (Maphper::FIND_LESS & $mode) return $expected > $actual;
48			else if (Maphper::FIND_BETWEEN & $mode) return $expected[0] <= $actual && $actual <= $expected[1];
49			else if (Maphper::FIND_NOCASE & $mode) return strtolower($expected) == strtolower($actual);
50			return $expected == $actual;
51			}
52			}
53

Level-2 / Maphper

Push — master ( 02cf1a...e288dc )

ArrayFilter::processFilter() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like