Level-2 / Maphper

Maphper/DataSource/DatabaseSelect.php

Braces +46 added lines, -22 removed lines

@@ -25,17 +25,22 @@ 
 		if (($this->cacheMode && !isset($this->idCache[$id])) || !$this->cacheMode) {
 			try {
 				$result = $this->selectQuery($this->selectBuilder->select($this->table, $pk . ' = :id', [':id' => $id], ['limit' => 1]));
-			}
-			catch (\Exception $e) {
+			} catch (\Exception $e) {
                 // Don't issue an error if it cannot be found since we return null
 			}
 
-			if (isset($result[0])) $result = $result[0];
-			else return null;
+			if (isset($result[0])) {
+				$result = $result[0];
+			} else {
+				return null;
+			}
 		}
 
-    if (!$this->cacheMode) return $result;
-		else return $this->idCache[$id] = $result;
+    if (!$this->cacheMode) {
+    	return $result;
+    } else {
+			return $this->idCache[$id] = $result;
+		}
 	}
 
     public function findByField(array $fields, $options = []) {
@@ -44,22 +49,27 @@ 
     if (($this->cacheMode && !isset($this->resultCache[$cacheId])) || !$this->cacheMode) {
 			$query = $this->whereBuilder->createSql($fields);
 
-			if (!isset($options['order'])) $options['order'] = $this->defaultSort;
+			if (!isset($options['order'])) {
+				$options['order'] = $this->defaultSort;
+			}
 
 			try {
 				$result = $this->selectQuery($this->selectBuilder->select($this->table, $query['sql'], $query['args'], $options));
 				$this->databaseModify->addIndex(array_keys($query['args']));
 				$this->databaseModify->addIndex(explode(',', $options['order']));
-			}
-			catch (\Exception $e) {
+			} catch (\Exception $e) {
 				$this->errors[] = $e;
 				$result = [];
 			}
 		}
 
     if ($this->cacheMode) {
-      if (isset($result)) $this->resultCache[$cacheId] = $result;
-      if (isset($this->resultCache[$cacheId])) return $this->resultCache[$cacheId];
+      if (isset($result)) {
+      	$this->resultCache[$cacheId] = $result;
+      }
+      if (isset($this->resultCache[$cacheId])) {
+      	return $this->resultCache[$cacheId];
+      }
     }
 
     return $result;
@@ -67,7 +77,9 @@ 
 
     public function findAggregate($function, $field, $group = null, array $criteria = [], array $options = []) {
 		//Cannot count/sum/max multiple fields, pick the first one. This should only come into play when trying to count() a mapper with multiple primary keys
-		if (is_array($field)) $field = $field[0];
+		if (is_array($field)) {
+			$field = $field[0];
+		}
 		$query = $this->whereBuilder->createSql($criteria);
 
 		try {
@@ -76,8 +88,7 @@ 
 			$result = $this->selectQuery($this->selectBuilder->aggregate($this->table, $function, $field, $query['sql'], $query['args'], $group));
 
 			return $this->determineAggregateResult($result, $group, $field);
-		}
-		catch (\Exception $e) {
+		} catch (\Exception $e) {
 			return $group ? [] : 0;
 		}
 	}
@@ -85,11 +96,15 @@ 
     private function determineAggregateResult($result, $group, $field) {
         if ($group != null) {
             $ret = [];
-            foreach ($result as $res) $ret[$res->$field] = $res->val;
+            foreach ($result as $res) {
+            	$ret[$res->$field] = $res->val;
+            }
             return $ret;
+        } else if (isset($result[0])) {
+        	return $result[0]->val;
+        } else {
+        	return 0;
         }
-        else if (isset($result[0])) return $result[0]->val;
-        else return 0;
     }
 
     private function selectQuery(\Maphper\Lib\Query $query) {
@@ -97,21 +112,30 @@ 
     }
 
     public function clearResultCache() {
-        if ($this->cacheMode) $this->resultCache = [];
+        if ($this->cacheMode) {
+        	$this->resultCache = [];
+        }
     }
 
     public function clearIDCache() {
-        if ($this->cacheMode) $this->idCache = [];
+        if ($this->cacheMode) {
+        	$this->idCache = [];
+        }
     }
 
     public function updateCache($data, $pkValue) {
         if ($this->cacheMode) {
-  		    if (isset($this->cache[$pkValue])) $this->cache[$pkValue] = (object) array_merge((array)$this->cache[$pkValue], (array)$data);
-  		    else $this->cache[$pkValue] = $data;
+  		    if (isset($this->cache[$pkValue])) {
+  		    	$this->cache[$pkValue] = (object) array_merge((array)$this->cache[$pkValue], (array)$data);
+  		    } else {
+  		    	$this->cache[$pkValue] = $data;
+  		    }
         }
     }
 
     public function deleteIDFromCache($id) {
-        if ($this->cacheMode) unset($this->idCache[$id]);
+        if ($this->cacheMode) {
+        	unset($this->idCache[$id]);
+        }
     }
 }