Level-2 / Maphper

Maphper/DataSource/DatabaseSelect.php

Braces +52 added lines, -22 removed lines

@@ -24,12 +24,21 @@ 
 
     private function cacheUpdateRequired($id) {
       if ($this->cacheMode > 0) {
-        if (!isset($this->idCacheTime[$id])) return true; // Cache time has not been set for first time
+        if (!isset($this->idCacheTime[$id])) {
+        	return true;
+        }
+        // Cache time has not been set for first time
 
-        if (time() - $this->idCacheTime[$id] > $this->cacheMode) return true; // Cache time has expired
+        if (time() - $this->idCacheTime[$id] > $this->cacheMode) {
+        	return true;
+        }
+        // Cache time has expired
       }
 
-      if (!isset($this->idCache[$id])) return true; // Cache has not been set for first time
+      if (!isset($this->idCache[$id])) {
+      	return true;
+      }
+      // Cache has not been set for first time
 
       return false;
     }
@@ -38,16 +47,21 @@ 
 		if ($this->cacheMode < 0 || $this->cacheUpdateRequired($id)) {
 			try {
 				$result = $this->selectQuery($this->selectBuilder->select($this->table, $pk . ' = :id', [':id' => $id], ['limit' => 1]));
-			}
-			catch (\Exception $e) {
+			} catch (\Exception $e) {
                 // Don't issue an error if it cannot be found since we return null
 			}
 
-			if (isset($result[0])) $result = $result[0];
-			else return null;
+			if (isset($result[0])) {
+				$result = $result[0];
+			} else {
+				return null;
+			}
 		}
 
-    if ($this->cacheMode < 0) return $result; // Cache mode is off
+    if ($this->cacheMode < 0) {
+    	return $result;
+    }
+    // Cache mode is off
 
     if ($this->cacheUpdateRequired()) {
       $this->idCache[$id] = $result;
@@ -63,20 +77,24 @@ 
     if ($this->cacheMode < 0 || $this->cacheUpdateRequired($cacheId)) {
 			$query = $this->whereBuilder->createSql($fields);
 
-			if (!isset($options['order'])) $options['order'] = $this->defaultSort;
+			if (!isset($options['order'])) {
+				$options['order'] = $this->defaultSort;
+			}
 
 			try {
 				$result = $this->selectQuery($this->selectBuilder->select($this->table, $query['sql'], $query['args'], $options));
 				$this->databaseModify->addIndex(array_keys($query['args']));
 				$this->databaseModify->addIndex(explode(',', $options['order']));
-			}
-			catch (\Exception $e) {
+			} catch (\Exception $e) {
 				$this->errors[] = $e;
 				$result = [];
 			}
 		}
 
-    if ($this->cacheMode < 0) return $result; // Cache mode is off
+    if ($this->cacheMode < 0) {
+    	return $result;
+    }
+    // Cache mode is off
 
     if ($this->cacheUpdateRequired($cacheId)) {
       $this->idCache[$cacheId] = $result;
@@ -88,7 +106,9 @@ 
 
     public function findAggregate($function, $field, $group = null, array $criteria = [], array $options = []) {
 		//Cannot count/sum/max multiple fields, pick the first one. This should only come into play when trying to count() a mapper with multiple primary keys
-		if (is_array($field)) $field = $field[0];
+		if (is_array($field)) {
+			$field = $field[0];
+		}
 		$query = $this->whereBuilder->createSql($criteria);
 
 		try {
@@ -97,8 +117,7 @@ 
 			$result = $this->selectQuery($this->selectBuilder->aggregate($this->table, $function, $field, $query['sql'], $query['args'], $group));
 
 			return $this->determineAggregateResult($result, $group, $field);
-		}
-		catch (\Exception $e) {
+		} catch (\Exception $e) {
 			return $group ? [] : 0;
 		}
 	}
@@ -106,11 +125,15 @@ 
     private function determineAggregateResult($result, $group, $field) {
         if ($group != null) {
             $ret = [];
-            foreach ($result as $res) $ret[$res->$field] = $res->val;
+            foreach ($result as $res) {
+            	$ret[$res->$field] = $res->val;
+            }
             return $ret;
+        } else if (isset($result[0])) {
+        	return $result[0]->val;
+        } else {
+        	return 0;
         }
-        else if (isset($result[0])) return $result[0]->val;
-        else return 0;
     }
 
     private function selectQuery(\Maphper\Lib\Query $query) {
@@ -118,17 +141,24 @@ 
     }
 
     public function clearResultCache() {
-        if ($this->cacheMode >= 0) $this->resultCache = [];
+        if ($this->cacheMode >= 0) {
+        	$this->resultCache = [];
+        }
     }
 
     public function clearIDCache() {
-        if ($this->cacheMode >= 0) $this->idCache = [];
+        if ($this->cacheMode >= 0) {
+        	$this->idCache = [];
+        }
     }
 
     public function updateCache($data, $pkValue) {
         if ($this->cacheMode >= 0) {
-  		    if (isset($this->cache[$pkValue])) $this->cache[$pkValue] = (object) array_merge((array)$this->cache[$pkValue], (array)$data);
-  		    else $this->cache[$pkValue] = $data;
+  		    if (isset($this->cache[$pkValue])) {
+  		    	$this->cache[$pkValue] = (object) array_merge((array)$this->cache[$pkValue], (array)$data);
+  		    } else {
+  		    	$this->cache[$pkValue] = $data;
+  		    }
         }
     }