Level-2 / Maphper

maphper/datasource/database.php

Spacing +4 added lines, -4 removed lines

@@ -25,13 +25,13 @@ 
 		$this->crudBuilder = new \Maphper\Lib\CrudBuilder();
 		$this->selectBuilder = new \Maphper\Lib\SelectBuilder();
 
-		$this->fields = implode(',', array_map([$this->adapter, 'quote'], (array) $this->options->read('fields')));
+		$this->fields = implode(',', array_map([$this->adapter, 'quote'], (array)$this->options->read('fields')));
 
-		$this->defaultSort = $this->options->read('defaultSort') !== false ? $this->options->read('defaultSort')  : implode(', ', $this->primaryKey);
+		$this->defaultSort = $this->options->read('defaultSort') !== false ? $this->options->read('defaultSort') : implode(', ', $this->primaryKey);
 
 		$this->alterDb = $this->options->getEditMode();
 
-		if (self::EDIT_OPTIMISE & $this->alterDb && rand(0,500) == 1) $this->adapter->optimiseColumns($table);
+		if (self::EDIT_OPTIMISE & $this->alterDb && rand(0, 500) == 1) $this->adapter->optimiseColumns($table);
 	}
 
 	public function getPrimaryKey() {
@@ -167,7 +167,7 @@ 
 
     private function updateCache($data) {
         $pkValue = $data->{$this->primaryKey[0]};
-		if (isset($this->cache[$pkValue])) $this->cache[$pkValue] = (object) array_merge((array)$this->cache[$pkValue], (array)$data);
+		if (isset($this->cache[$pkValue])) $this->cache[$pkValue] = (object)array_merge((array)$this->cache[$pkValue], (array)$data);
 		else $this->cache[$pkValue] = $data;
     }
 

Braces +57 added lines, -30 removed lines

@@ -31,7 +31,9 @@ 
 
 		$this->alterDb = $this->options->getEditMode();
 
-		if (self::EDIT_OPTIMISE & $this->alterDb && rand(0,500) == 1) $this->adapter->optimiseColumns($table);
+		if (self::EDIT_OPTIMISE & $this->alterDb && rand(0,500) == 1) {
+			$this->adapter->optimiseColumns($table);
+		}
 	}
 
 	public function getPrimaryKey() {
@@ -47,20 +49,24 @@ 
 		if (!isset($this->cache[$id])) {
 			try {
 				$result = $this->adapter->query($this->selectBuilder->select($this->table, [$this->getPrimaryKey()[0] . ' = :id'], [':id' => $id], ['limit' => 1]));
-			}
-			catch (\Exception $e) {
+			} catch (\Exception $e) {
 				$this->errors[] = $e;
 			}
 
-			if (isset($result[0])) 	$this->cache[$id] = $result[0];
-			else return null;
+			if (isset($result[0])) {
+				$this->cache[$id] = $result[0];
+			} else {
+				return null;
+			}
 		}
 		return $this->cache[$id];
 	}
 
 	public function findAggregate($function, $field, $group = null, array $criteria = [], array $options = []) {
 		//Cannot count/sum/max multiple fields, pick the first one. This should only come into play when trying to count() a mapper with multiple primary keys
-		if (is_array($field)) $field = $field[0];
+		if (is_array($field)) {
+			$field = $field[0];
+		}
 		$query = $this->selectBuilder->createSql($criteria, \Maphper\Maphper::FIND_EXACT | \Maphper\Maphper::FIND_AND);
 
 		try {
@@ -68,22 +74,27 @@ 
 			$this->addIndex(explode(',', $group));
 			$result = $this->adapter->query($this->selectBuilder->aggregate($this->table, $function, $field, $query['sql'], $query['args'], $group));
 
-			if (isset($result[0]) && $group == null) return $result[0]->val;
-			else if ($group != null) {
+			if (isset($result[0]) && $group == null) {
+				return $result[0]->val;
+			} else if ($group != null) {
 				$ret = [];
-				foreach ($result as $res) $ret[$res->$field] = $res->val;
+				foreach ($result as $res) {
+					$ret[$res->$field] = $res->val;
+				}
 				return $ret;
+			} else {
+				return 0;
 			}
-			else return 0;
-		}
-		catch (\Exception $e) {
+		} catch (\Exception $e) {
 			$this->errors[] = $e;
 			return $group ? [] : 0;
 		}
 	}
 
 	private function addIndex($args) {
-		if (self::EDIT_INDEX & $this->alterDb) $this->adapter->addIndex($this->table, $args);
+		if (self::EDIT_INDEX & $this->alterDb) {
+			$this->adapter->addIndex($this->table, $args);
+		}
 	}
 
 	public function findByField(array $fields, $options = []) {
@@ -91,7 +102,9 @@ 
 		if (!isset($this->resultCache[$cacheId])) {
 			$query = $this->selectBuilder->createSql($fields, \Maphper\Maphper::FIND_EXACT | \Maphper\Maphper::FIND_AND);
 
-			if (!isset($options['order'])) $options['order'] = $this->defaultSort;
+			if (!isset($options['order'])) {
+				$options['order'] = $this->defaultSort;
+			}
 
 			$query['sql'] = array_filter($query['sql']);
 
@@ -99,8 +112,7 @@ 
 				$this->resultCache[$cacheId] = $this->adapter->query($this->selectBuilder->select($this->table, $query['sql'], $query['args'], $options));
 				$this->addIndex(array_keys($query['args']));
 				$this->addIndex(explode(',', $options['order']));
-			}
-			catch (\Exception $e) {
+			} catch (\Exception $e) {
 				$this->errors[] = $e;
 				$this->resultCache[$cacheId] = [];
 			}
@@ -109,9 +121,14 @@ 
 	}
 
 	public function deleteByField(array $fields, array $options = [], $mode = null) {
-		if ($mode == null) $mode = \Maphper\Maphper::FIND_EXACT | \Maphper\Maphper::FIND_AND;
-		if (isset($options['limit']) != null) $limit = ' LIMIT ' . $options['limit'];
-		else $limit = '';
+		if ($mode == null) {
+			$mode = \Maphper\Maphper::FIND_EXACT | \Maphper\Maphper::FIND_AND;
+		}
+		if (isset($options['limit']) != null) {
+			$limit = ' LIMIT ' . $options['limit'];
+		} else {
+			$limit = '';
+		}
 
 		$query = $this->selectBuilder->createSql($fields, $mode);
         $query['sql'] = array_filter($query['sql']);
@@ -142,17 +159,21 @@ 
             $result = $this->insert($this->table, $this->primaryKey, $data);
 
 			//If there was an error but PDO is silent, trigger the catch block anyway
-			if ($result->errorCode() !== '00000') throw new \Exception('Could not insert into ' . $this->table);
-		}
-		catch (\Exception $e) {
+			if ($result->errorCode() !== '00000') {
+				throw new \Exception('Could not insert into ' . $this->table);
+			}
+		} catch (\Exception $e) {
 			if ($tryagain) {
 				$this->adapter->alterDatabase($this->table, $this->primaryKey, $data);
 				$this->save($data, false);
+			} else {
+				throw $e;
 			}
-			else throw $e;
 		}
 
-		if ($new && count($this->primaryKey) == 1) $data->{$this->primaryKey[0]} = $this->adapter->lastInsertId();
+		if ($new && count($this->primaryKey) == 1) {
+			$data->{$this->primaryKey[0]} = $this->adapter->lastInsertId();
+		}
 		//Something has changed, clear any cached results as they may now be incorrect
 		$this->resultCache = [];
 		$this->updateCache($data);
@@ -162,21 +183,25 @@ 
         $updateWhere = $this->crudBuilder->update($this->table, $this->primaryKey, $data);
         $matched = $this->findByField($updateWhere->getArgs());
 
-        if (count($matched) == 0) throw new \InvalidArgumentException('Record inserted into table ' . $this->table . ' fails table constraints');
+        if (count($matched) == 0) {
+        	throw new \InvalidArgumentException('Record inserted into table ' . $this->table . ' fails table constraints');
+        }
     }
 
     private function updateCache($data) {
         $pkValue = $data->{$this->primaryKey[0]};
-		if (isset($this->cache[$pkValue])) $this->cache[$pkValue] = (object) array_merge((array)$this->cache[$pkValue], (array)$data);
-		else $this->cache[$pkValue] = $data;
+		if (isset($this->cache[$pkValue])) {
+			$this->cache[$pkValue] = (object) array_merge((array)$this->cache[$pkValue], (array)$data);
+		} else {
+			$this->cache[$pkValue] = $data;
+		}
     }
 
 	private function insert($table, array $primaryKey, $data) {
 		$error = 0;
 		try {
 			$result = $this->adapter->query($this->crudBuilder->insert($table, $data));
-		}
-		catch (\Exception $e) {
+		} catch (\Exception $e) {
 			$error = 1;
 		}
 
@@ -184,7 +209,9 @@ 
  			$result = $this->adapter->query($this->crudBuilder->update($table, $primaryKey, $data));
  		}
 
-        if ($result->rowCount() === 0) $this->checkIfUpdateWorked($data);
+        if ($result->rowCount() === 0) {
+        	$this->checkIfUpdateWorked($data);
+        }
 
 		return $result;
 	}