Level-2 /
Maphper
| Conditions | 20 |
| Paths | 166 |
| Total Lines | 59 |
| Code Lines | 42 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 6 | public function createSql($fields, $mode = \Maphper\Maphper::FIND_EXACT | \Maphper\Maphper::FIND_AND){ |
||
| 7 | $args = []; |
||
| 8 | $sql = []; |
||
| 9 | |||
| 10 | foreach ($fields as $key => $value) { |
||
| 11 | if ($value instanceof \DateTime) { |
||
| 12 | if ($value->format('H:i:s') == '00:00:00') $value = $value->format('Y-m-d'); |
||
| 13 | else $value = $value->format('Y-m-d H:i:s'); |
||
| 14 | } |
||
| 15 | |||
| 16 | if (is_object($value)) continue; |
||
| 17 | if (is_numeric($key) && is_array($value)) { |
||
| 18 | $result = $this->createSql($value, $key); |
||
| 19 | foreach ($result['args'] as $arg_key => $arg) $args[$arg_key] = $arg; |
||
| 20 | foreach ($result['sql'] as $arg) $sql[] = $arg; |
||
| 21 | } |
||
| 22 | else if (\Maphper\Maphper::FIND_BETWEEN & $mode) { |
||
| 23 | $sql[] = $key . '>= :' . $key . 'from'; |
||
| 24 | $sql[] = $key . ' <= :' . $key . 'to'; |
||
| 25 | |||
| 26 | $args[$key . 'from'] = $value[0]; |
||
| 27 | $args[$key . 'to'] = $value[1]; |
||
| 28 | } |
||
| 29 | else if (!is_numeric($key) && is_array($value)) { |
||
| 30 | $inSql = []; |
||
| 31 | $count = count($value); |
||
| 32 | for ($i = 0; $i < $count; $i++) { |
||
| 33 | $args[$key . $i] = $value[$i]; |
||
| 34 | $inSql[] = ':' . $key . $i; |
||
| 35 | } |
||
| 36 | if (count($inSql) == 0) return []; |
||
| 37 | else $sql[] = $key . ' IN ( ' . implode(', ', $inSql) . ')'; |
||
| 38 | } |
||
| 39 | else if ($value === NULL) { |
||
| 40 | $nullSql = $key . ' IS '; |
||
| 41 | if (\Maphper\Maphper::FIND_NOT & $mode) $nullSql .= 'NOT '; |
||
| 42 | $sql[] = $nullSql . 'NULL'; |
||
| 43 | } |
||
| 44 | else { |
||
| 45 | |||
| 46 | if (\Maphper\Maphper::FIND_LIKE & $mode) { |
||
| 47 | $operator = 'LIKE'; |
||
| 48 | $value = '%' . $value . '%'; |
||
| 49 | } |
||
| 50 | else if (\Maphper\Maphper::FIND_STARTS & $mode) { |
||
| 51 | $operator = 'LIKE'; |
||
| 52 | $value = $value . '%'; |
||
| 53 | } |
||
| 54 | else $operator = $this->getOperator($mode); |
||
| 55 | |||
| 56 | $args[$key] = $value; |
||
| 57 | $sql[] = $key . ' ' . $operator . ' :' . $key; |
||
| 58 | } |
||
| 59 | } |
||
| 60 | |||
| 61 | if (\Maphper\Maphper::FIND_OR & $mode) $query = implode(' OR ', $sql); |
||
| 62 | else $query = implode(' AND ', $sql); |
||
| 63 | if (!empty($query)) $query = '(' . $query . ')'; |
||
| 64 | return ['args' => $args, 'sql' => $query]; |
||
| 65 | } |
||
| 81 |
