Maphper\DataSource\MysqlAdapter

Complexity

Total Complexity

31

Size/Duplication

Total Lines	94
Duplicated Lines	14.89 %

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	quote()	0	2	1
A	createTable()	5	10	3
A	__construct()	0	4	1
A	addIndex()	0	9	3
A	query()	0	11	4
B	getType()	4	6	6
B	alterDatabase()	0	14	8
A	getCachedStmt()	5	8	3
A	lastInsertId()	0	2	1
A	optimiseColumns()	0	3	1

<?php
namespace Maphper\DataSource;
class MysqlAdapter implements DatabaseAdapter {
	private $pdo;
	private $queryCache = [];

	public function __construct(\PDO $pdo) {
		$this->pdo = $pdo;
		//Set to strict mode to detect 'out of range' errors, action at a distance but it needs to be set for all INSERT queries
		$this->pdo->query('SET sql_mode = STRICT_ALL_TABLES');
	}

	public function quote($str) {
		return '`' . str_replace('.', '`.`', trim($str, '`')) . '`';
	}

	private function getCachedStmt($sql) {
		$queryId = md5($sql);
		if (isset($this->queryCache[$queryId])) $stmt = $this->queryCache[$queryId];

This code seems to be duplicated across your project.

		else {
			$stmt = $this->pdo->prepare($sql, [\PDO::ATTR_CURSOR => \PDO::CURSOR_FWDONLY]);
			if ($stmt) $this->queryCache[$queryId] = $stmt;
		}
		return $stmt;
	}

	public function query(\Maphper\Lib\Query $query) {
		$stmt = $this->getCachedStmt($query->getSql());
		$args = $query->getArgs();
		foreach ($args as $name => &$arg) {
			if ($arg instanceof \DateTime) $arg = $arg->format('Y-m-d H:i:s');
		}

		$res = $stmt->execute($args);

The assignment to $res is dead and can be removed.

		if (strpos(trim($query->getSql()), 'SELECT') === 0) return $stmt->fetchAll(\PDO::FETCH_OBJ);
		else return $stmt;
	}

	private function getType($val) {
		if ($val instanceof \DateTime) return 'DATETIME';

This code seems to be duplicated across your project.

		else if (is_int($val)) return  'INT(11)';
		else if (is_double($val)) return 'DECIMAL(9,' . strlen($val) - strrpos($val, '.') - 1 . ')';
		else if (is_string($val)) return strlen($val) < 192 ? 'VARCHAR(191)' : 'LONGBLOB';
		return 'VARCHAR(191)';
	}

	//Alter the database so that it can store $data
	private function createTable($table, array $primaryKey, $data) {
		$parts = [];
		foreach ($primaryKey as $key) {

This code seems to be duplicated across your project.

			$pk = $data->$key;
			if ($pk == null) $parts[] = $key . ' INT(11) NOT NULL AUTO_INCREMENT';
			else $parts[] = $key . ' ' . $this->getType($pk) . ' NOT NULL';
		}

		$pkField = implode(', ', $parts) . ', PRIMARY KEY(' . implode(', ', $primaryKey) . ')';
		$this->pdo->query('CREATE TABLE IF NOT EXISTS ' . $table . ' (' . $pkField . ')');
	}

	public function alterDatabase($table, array $primaryKey, $data) {
		$this->createTable($table, $primaryKey, $data);

		foreach ($data as $key => $value) {
			if (is_array($value) || (is_object($value) && !($value instanceof \DateTime))) continue;
			if (in_array($key, $primaryKey)) continue;

			$type = $this->getType($value);

			try {
				if (!$this->pdo->query('ALTER TABLE ' . $table . ' ADD ' . $this->quote($key) . ' ' . $type)) throw new \Exception('Could not alter table');
			}
			catch (\Exception $e) {
				$this->pdo->query('ALTER TABLE ' . $table . ' MODIFY ' . $this->quote($key) . ' ' . $type);
			}
		}
	}

	public function lastInsertId() {
		return $this->pdo->lastInsertId();
	}

	public function addIndex($table, array $fields) {
		//Sort the fields so that the index is never created twice (col1, col2) then (col2, col1)
		sort($fields);
		$fields = array_map('strtolower', $fields);
		$fields = array_map('trim', $fields);
		$keyName = $this->quote(implode('_', $fields));

		$results = $this->pdo->query('SHOW INDEX FROM ' . $this->quote($table) . ' WHERE Key_Name = "' . $keyName . '"');
		if ($results && count($results->fetchAll()) == 0)  $this->pdo->query('CREATE INDEX ' . $keyName . ' ON ' . $this->quote($table) . ' (' . implode(', ', $fields) . ')');
	}

	public function optimiseColumns($table) {
		//TODO
		return;
	}
}