Maphper\Relation\Many

Complexity

Total Complexity

9

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getData()	0	5	2
A	overwrite()	0	6	5
A	__construct()	0	5	2

<?php 
namespace Maphper\Relation;
class Many implements \Maphper\Relation {
	private $mapper;
	private $parentField;
	private $localField;
	
	public function __construct(\Maphper\Maphper $mapper, $parentField, $localField, array $critiera = []) {
		if ($critiera) $mapper->filter($critiera);

The method filter() does not exist on Maphper\Maphper. Since you implemented __call, consider adding a @method annotation.

The expression $critiera of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

		$this->mapper = $mapper;
		$this->parentField = $parentField;
		$this->localField = $localField;		
	}
	
	
	public function getData($parentObject) {
		if (!isset($parentObject->{$this->parentField})) $mapper = $this->mapper;
		else $mapper = $this->mapper->filter([$this->localField => $parentObject->{$this->parentField}]);
		
		return $mapper;
	}

	
	public function overwrite($key, &$mapper) {
		if (!isset($key->{$this->parentField})) return false;
		foreach ($mapper as $k => $val) {
			if (!empty($val->{$this->localField}) && $val->{$this->localField} != $key->{$this->parentField}) continue;
			$val->{$this->localField} = $key->{$this->parentField};
			$this->mapper[] = $val;
		}
	}


}