Request::execute() - Code Metrics - Inspection of "Test for missing path" - Lenius/economic-php-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 553e74...c78a38 )

by Carsten

created 2018-10-30 18:56 UTC

Request::execute() B

↳ Parent: Request

Complexity

Conditions	6
Paths	7

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	6.6563

Importance

Changes

Metric	Value
dl	0
loc	55
ccs	14
cts	19
cp	0.7368
rs	8.3595
c	0
b	0
f	0
cc	6
nc	7
nop	3
crap	6.6563

How to fix Long Method

<?php

namespace Lenius\Economic\API;

use http\Exception\InvalidArgumentException;

/**
 * @class      Economic_Request
 */
class Request
{
    /**
     * Contains Economic_Client instance.
     */
    protected $client;

    /**
     * __construct function.
     *
     * Instantiates the object
     *
     * @param Client $client
     */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    /**
     * GET function.
     *
     * Performs an API GET request
     *
     * @param string $path
     * @param array  $query
     *
     * @throws Exception
     *
     * @return Response
     */
    public function get($path, $query = [])
    {
        // Add query parameters to $path?
        if (!empty($query)) {
            if (strpos($path, '?') === false) {
                $path .= '?'.http_build_query($query, '', '&');
            } else {
                $path .= ini_get('arg_separator.output').http_build_query($query, '', '&');
            }
        }

        // Start the request and return the response
        return $this->execute('GET', $path);
    }

    /**
     * POST function.
     *
     * Performs an API POST request
     *
     * @param string $path
     * @param array  $form
     *
     * @throws Exception
     *
     * @return Response
     */
    public function post($path, $form = [])
    {
        // Start the request and return the response
        return $this->execute('POST', $path, $form);
    }

    /**
     * PUT function.
     *
     * Performs an API PUT request
     *
     * @param string $path
     * @param array  $form
     *
     * @throws Exception
     *
     * @return Response
     */
    public function put($path, $form = [])
    {
        // Start the request and return the response
        return $this->execute('PUT', $path, $form);
    }

    /**
     * PATCH function.
     *
     * Performs an API PATCH request
     *
     * @param string $path
     * @param array  $form
     *
     * @throws Exception
     *
     * @return Response
     */
    public function patch($path, $form = [])
    {
        // Start the request and return the response
        return $this->execute('PATCH', $path, $form);
    }

    /**
     * DELETE function.
     *
     * Performs an API DELETE request
     *
     * @param string $path
     * @param array  $form
     *
     * @throws Exception
     *
     * @return Response
     */
    public function delete($path, $form = [])
    {
        // Start the request and return the response
        return $this->execute('DELETE', $path, $form);
    }

    /**
     * @param string $request_type
     * @param array $form
     *
     * @param string $path
     * @return Response
     * @throws Exception
     */
    protected function execute($request_type, $path, $form = [])
    {
        // Store received headers in temporary memory file, remember sent headers
        if (!$path) {
            throw new \InvalidArgumentException('Path is missing');
        }

        // Init client
        $this->client->create();

        // Set the request path
        curl_setopt($this->client->ch, CURLOPT_URL, Constants::API_URL.trim($path, '/'));

        // Set the HTTP request type
        curl_setopt($this->client->ch, CURLOPT_CUSTOMREQUEST, $request_type);

        // If additional data is delivered, we will send it along with the API request
        if (is_array($form) && !empty($form)) {
            $post = json_encode($form);
            curl_setopt($this->client->ch, CURLOPT_POSTFIELDS, $post);
        }

        // Store received headers in temporary memory file, remember sent headers
        if (!$fh_header = fopen('php://temp', 'w+')) {
            throw new Exception('Fail to create tmp');
        }

        curl_setopt($this->client->ch, CURLOPT_WRITEHEADER, $fh_header);
        curl_setopt($this->client->ch, CURLINFO_HEADER_OUT, true);

        // Execute the request
        $response_data = curl_exec($this->client->ch);

        if (curl_errno($this->client->ch) !== 0) {
            // An error occurred
            fclose($fh_header);

            throw new Exception(curl_error($this->client->ch), curl_errno($this->client->ch));
        }

        // Grab the headers
        $sent_headers = curl_getinfo($this->client->ch, CURLINFO_HEADER_OUT);
        rewind($fh_header);
        $received_headers = stream_get_contents($fh_header);
        fclose($fh_header);

        // Retrieve the HTTP response code
        $response_code = (int) curl_getinfo($this->client->ch, CURLINFO_HTTP_CODE);

        // Shutdown client
        $this->client->shutdown();

        // Return the response object.
        return new Response($response_code, $sent_headers, $received_headers, $response_data);
    }
}


1		<?php
2
3		namespace Lenius\Economic\API;
4
5		use http\Exception\InvalidArgumentException;
6
7		/**
8		* @class Economic_Request
9		*/
10		class Request
11		{
12		/**
13		* Contains Economic_Client instance.
14		*/
15		protected $client;
16
17		/**
18		* __construct function.
19		*
20	4	* Instantiates the object
21		*
22	4	* @param Client $client
23	4	*/
24		public function __construct(Client $client)
25		{
26		$this->client = $client;
27		}
28
29		/**
30		* GET function.
31		*
32		* Performs an API GET request
33		*
34		* @param string $path
35	4	* @param array $query
36		*
37		* @throws Exception
38	4	*
39		* @return Response
40		*/
41		public function get($path, $query = [])
42		{
43		// Add query parameters to $path?
44		if (!empty($query)) {
45		if (strpos($path, '?') === false) {
46		$path .= '?'.http_build_query($query, '', '&');
47	4	} else {
48		$path .= ini_get('arg_separator.output').http_build_query($query, '', '&');
49		}
50	4	}
51
52		// Start the request and return the response
53		return $this->execute('GET', $path);
54		}
55
56		/**
57		* POST function.
58		*
59		* Performs an API POST request
60		*
61		* @param string $path
62		* @param array $form
63		*
64		* @throws Exception
65		*
66		* @return Response
67		*/
68		public function post($path, $form = [])
69		{
70		// Start the request and return the response
71		return $this->execute('POST', $path, $form);
72		}
73
74		/**
75		* PUT function.
76		*
77		* Performs an API PUT request
78		*
79		* @param string $path
80		* @param array $form
81		*
82		* @throws Exception
83		*
84		* @return Response
85		*/
86		public function put($path, $form = [])
87		{
88		// Start the request and return the response
89		return $this->execute('PUT', $path, $form);
90		}
91
92		/**
93		* PATCH function.
94		*
95		* Performs an API PATCH request
96		*
97		* @param string $path
98		* @param array $form
99		*
100		* @throws Exception
101		*
102		* @return Response
103		*/
104		public function patch($path, $form = [])
105		{
106		// Start the request and return the response
107		return $this->execute('PATCH', $path, $form);
108		}
109
110		/**
111		* DELETE function.
112		*
113		* Performs an API DELETE request
114		*
115		* @param string $path
116		* @param array $form
117		*
118		* @throws Exception
119		*
120		* @return Response
121		*/
122		public function delete($path, $form = [])
123		{
124	4	// Start the request and return the response
125		return $this->execute('DELETE', $path, $form);
126	4	}
127	4
128		/**
129		* @param string $request_type
130		* @param array $form
131		*
132		* @param string $path
133		* @return Response
134		* @throws Exception
135		*/
136		protected function execute($request_type, $path, $form = [])
137	4	{
138		// Store received headers in temporary memory file, remember sent headers
139		if (!$path) {
140	4	throw new \InvalidArgumentException('Path is missing');
141		}
142
143	4	// Init client
144		$this->client->create();
145
146		// Set the request path
147		curl_setopt($this->client->ch, CURLOPT_URL, Constants::API_URL.trim($path, '/'));
148
149	4	// Set the HTTP request type
150	4	curl_setopt($this->client->ch, CURLOPT_CUSTOMREQUEST, $request_type);
151	4
152		// If additional data is delivered, we will send it along with the API request
153		if (is_array($form) && !empty($form)) {
154	4	$post = json_encode($form);
155		curl_setopt($this->client->ch, CURLOPT_POSTFIELDS, $post);
156	4	}
157
158		// Store received headers in temporary memory file, remember sent headers
159		if (!$fh_header = fopen('php://temp', 'w+')) {
160		throw new Exception('Fail to create tmp');
161		}
162
163	4	curl_setopt($this->client->ch, CURLOPT_WRITEHEADER, $fh_header);
164	4	curl_setopt($this->client->ch, CURLINFO_HEADER_OUT, true);
165	4
166	4	// Execute the request
167		$response_data = curl_exec($this->client->ch);
168
169	4	if (curl_errno($this->client->ch) !== 0) {
170		// An error occurred
171		fclose($fh_header);
172	4
173		throw new Exception(curl_error($this->client->ch), curl_errno($this->client->ch));
174		}
175
176		// Grab the headers
177		$sent_headers = curl_getinfo($this->client->ch, CURLINFO_HEADER_OUT);
178		rewind($fh_header);
179		$received_headers = stream_get_contents($fh_header);
180		fclose($fh_header);
181
182		// Retrieve the HTTP response code
183		$response_code = (int) curl_getinfo($this->client->ch, CURLINFO_HTTP_CODE);
184
185		// Shutdown client
186		$this->client->shutdown();
187
188		// Return the response object.
189		return new Response($response_code, $sent_headers, $received_headers, $response_data);
190		}
191		}
192

Lenius / economic-php-client

Push — master ( 553e74...c78a38 )

Request::execute() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like