BasketTest::testPriceOption() - Code Metrics - Inspection of "Fix tax" - Lenius/basket - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 9b693b...3fb0bb )

by Carsten

created 2017-09-17 19:54 UTC

BasketTest::testPriceOption() A

↳ Parent: BasketTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	14

Duplication

Lines	21
Ratio	100 %

Importance

Changes

Metric	Value
dl	21
loc	21
rs	9.3142
c	0
b	0
f	0
cc	1
eloc	14
nc	1
nop	0

<?php

/**
 * This file is part of Lenius Basket, a PHP package to handle
 * your shopping basket.
 *
 * Copyright (c) 2017 Lenius.
 * http://github.com/lenius/basket
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author Carsten Jonstrup<[email protected]>
 * @copyright 2017 Lenius.
 *
 * @version dev
 *
 * @link http://github.com/lenius/basket
 */
use Lenius\Basket\Basket;
use Lenius\Basket\Identifier\Runtime as RuntimeIdentifier;
use Lenius\Basket\Storage\Runtime as RuntimeStore;
use PHPUnit\Framework\TestCase;

class BasketTest extends TestCase
namespace YourVendor;

class YourClass { }
{
    public function setUp()
    {
        $this->basket = new Basket(new RuntimeStore(), new RuntimeIdentifier());
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function tearDown()
    {
        $this->basket->destroy();
    }

    public function testInsert()
    {
        $actualId = $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 1,
            'weight'   => 200,
        ]);

        $identifier = md5('foo'.serialize([]));

        $this->assertEquals($identifier, $actualId);
    }

    public function testInsertIncrements()
    {
        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 150,
            'quantity' => 1,
            'weight'   => 200,
        ]);

        $this->assertEquals($this->basket->total(), 150);

        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 150,
            'quantity' => 1,
            'weight'   => 200,
        ]);

        $this->assertEquals($this->basket->total(), 300);
    }

    public function testUpdate()

    {
        $actualId = $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 1,
            'weight'   => 200,
        ]);

        $this->basket->update($actualId, 'name', 'baz');

        $this->assertEquals($this->basket->item($actualId)->name, 'baz');
    }

    public function testMagicUpdate()

    {
        $actualId = $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 1,
            'weight'   => 200,
        ]);

        foreach ($this->basket->contents() as $item) {
            $item->name = 'bim';
        }

        $this->assertEquals($this->basket->item($actualId)->name, 'bim');
    }

    public function testOptions()
    {
        $actualId = $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 1,
            'weight'   => 200,
            'options'  => [
                'size' => 'L',
            ],
        ]);

        $item = $this->basket->item($actualId);

        $this->assertTrue($item->hasOptions());
        $this->assertNotEmpty($item->options);

        $item->options = [];

        $this->assertFalse($item->hasOptions());
        $this->assertEmpty($item->options);
    }

    public function testWeight()
    {
        $weight = rand(200, 300);

        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 1,
            'weight'   => $weight,
            'options'  => [
                'size' => 'L',
            ],
        ]);

        // Test that the total weight is being calculated successfully
        $this->assertEquals($this->basket->weight(), $weight);
    }

    public function testWeightOption()

    {
        $weight = rand(200, 300);
        $weight_option = rand(50, 800);
        $quantity = rand(1, 10);

        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => $quantity ,
            'weight'   => $weight,
            'options'  => [
                'size'   => 'L',
                'weight' => $weight_option,
            ],
        ]);

        // Test that the total weight is being calculated successfully
        $this->assertEquals($this->basket->weight(), ($weight + $weight_option) * $quantity );
    }

    public function testPriceOption()

    {
        $weight = rand(200, 300);
        $weight_option = rand(50, 800);
        $quantity = rand(1, 10);

        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => $quantity ,
            'weight'   => $weight,
            'options'  => [
                'size'   => 'L',
                'weight' => $weight_option,
            ],
        ]);

        // Test that the total weight is being calculated successfully
        $this->assertEquals($this->basket->weight(), ($weight + $weight_option) * $quantity );
    }

    public function testFind()
    {
        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 1,
            'weight'   => 200,
        ]);

        $this->assertInstanceOf('\Lenius\Basket\Item', $this->basket->find('foo'));
    }

    public function testTotals()
    {
        // Generate a random price and quantity
        $price = rand(20, 99999);
        $quantity = rand(1, 10);

        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => $price,
            'quantity' => $quantity,
            'weight'   => 200,
        ]);

        // Test that the total is being calculated successfully
        $this->assertEquals($this->basket->total(), $price * $quantity);
    }

    public function testTotalItems()
    {
        $adding = rand(1, 200);
        $actualTotal = 0;

        for ($i = 1; $i <= $adding; $i++) {
            $quantity = rand(1, 20);

            $this->basket->insert([
                'id'       => uniqid(),
                'name'     => 'bar',
                'price'    => 100,
                'quantity' => $quantity,
                'weight'   => 200,
            ]);

            $actualTotal += $quantity;
        }

        $this->assertEquals($this->basket->totalItems(), $actualTotal);
        $this->assertEquals($this->basket->totalItems(true), $adding);
    }

    public function testItemRemoval()

    {
        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 1,
            'weight'   => 200,
        ]);

        $contents = &$this->basket->contents();

        $this->assertNotEmpty($contents);

        foreach ($contents as $item) {
            $item->remove();
        }

        $this->assertEmpty($contents);
    }

    public function testAlternateItemRemoval()

    {
        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 1,
            'weight'   => 200,
        ]);

        $contents = &$this->basket->contents();

        $this->assertNotEmpty($contents);

        foreach ($contents as $identifier => $item) {
            $this->basket->remove($identifier);
        }

        $this->assertEmpty($contents);
    }

    public function testItemToArray()

    {
        $actualId = $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 1,
            'weight'   => 200,
        ]);

        $this->assertTrue(is_array($this->basket->item($actualId)->toArray()));
    }

    public function testbasketToArray()

    {
        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 1,
            'weight'   => 200,
        ]);

        foreach ($this->basket->contents(true) as $item) {
            $this->assertTrue(is_array($item));
        }
    }

    public function testTax()

    {
        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 1,
            'tax'      => 20,
            'weight'   => 200,
        ]);

        // Test that the tax is being calculated successfully
        $this->assertEquals($this->basket->total(), 120);

        // Test that the total method can also return the pre-tax price if false is passed
        $this->assertEquals($this->basket->total(false), 100);
    }

    public function testTaxMultiply()

    {
        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 2,
            'tax'      => 20,
            'weight'   => 200,
        ]);

        // Test that the tax is being calculated successfully
        $this->assertEquals($this->basket->total(), 240);

        // Test that the total method can also return the pre-tax price if false is passed
        $this->assertEquals($this->basket->total(false), 200);
    }

    public function testTaxUpdate()
    {
        $this->basket->insert([
            'id'       => 'foo',
            'name'     => 'bar',
            'price'    => 100,
            'quantity' => 1,
            'tax'      => 20,
            'weight'   => 200,
        ]);

        $identifier = md5('foo'.serialize([]));

        $item = $this->basket->item($identifier);

        // Test that the tax is being calculated successfully
        $item->tax = 0;
        $this->assertEquals($item->total(), 100);
        $this->assertEquals($item->total(false), 100);

        $item->tax = 20;
        $this->assertEquals($item->total(), 120);
        $this->assertEquals($item->total(false), 100);

        $item->update('tax', 0);
        $this->assertEquals($item->total(), 100);
        $this->assertEquals($item->total(false), 100);

        $item->update('tax', 20);
        $this->assertEquals($item->total(), 120);
        $this->assertEquals($item->total(false), 100);
    }
}


1		<?php
2
3		/**
4		* This file is part of Lenius Basket, a PHP package to handle
5		* your shopping basket.
6		*
7		* Copyright (c) 2017 Lenius.
8		* http://github.com/lenius/basket
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*
13		* @author Carsten Jonstrup<[email protected]>
14		* @copyright 2017 Lenius.
15		*
16		* @version dev
17		*
18		* @link http://github.com/lenius/basket
19		*/
20		use Lenius\Basket\Basket;
21		use Lenius\Basket\Identifier\Runtime as RuntimeIdentifier;
22		use Lenius\Basket\Storage\Runtime as RuntimeStore;
23		use PHPUnit\Framework\TestCase;
24
25		class BasketTest extends TestCase
		0 ignored issues – show Coding Style Compatibility introduced 2017-09-17 16:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
26		{
27		public function setUp()
28		{
29		$this->basket = new Basket(new RuntimeStore(), new RuntimeIdentifier());
		0 ignored issues – show Bug introduced 2016-07-21 20:49 UTC by Report Bug Copy Issue Report The property `basket` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30		}
31
32		public function tearDown()
33		{
34		$this->basket->destroy();
35		}
36
37		public function testInsert()
38		{
39		$actualId = $this->basket->insert([
40		'id' => 'foo',
41		'name' => 'bar',
42		'price' => 100,
43		'quantity' => 1,
44		'weight' => 200,
45		]);
46
47		$identifier = md5('foo'.serialize([]));
48
49		$this->assertEquals($identifier, $actualId);
50		}
51
52		public function testInsertIncrements()
53		{
54		$this->basket->insert([
55		'id' => 'foo',
56		'name' => 'bar',
57		'price' => 150,
58		'quantity' => 1,
59		'weight' => 200,
60		]);
61
62		$this->assertEquals($this->basket->total(), 150);
63
64		$this->basket->insert([
65		'id' => 'foo',
66		'name' => 'bar',
67		'price' => 150,
68		'quantity' => 1,
69		'weight' => 200,
70		]);
71
72		$this->assertEquals($this->basket->total(), 300);
73		}
74
75	View Code Duplication	public function testUpdate()
		1 ignored issue – show Duplication introduced 2017-09-17 16:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
76		{
77		$actualId = $this->basket->insert([
78		'id' => 'foo',
79		'name' => 'bar',
80		'price' => 100,
81		'quantity' => 1,
82		'weight' => 200,
83		]);
84
85		$this->basket->update($actualId, 'name', 'baz');
86
87		$this->assertEquals($this->basket->item($actualId)->name, 'baz');
88		}
89
90	View Code Duplication	public function testMagicUpdate()
		1 ignored issue – show Duplication introduced 2017-09-17 16:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91		{
92		$actualId = $this->basket->insert([
93		'id' => 'foo',
94		'name' => 'bar',
95		'price' => 100,
96		'quantity' => 1,
97		'weight' => 200,
98		]);
99
100		foreach ($this->basket->contents() as $item) {
101		$item->name = 'bim';
102		}
103
104		$this->assertEquals($this->basket->item($actualId)->name, 'bim');
105		}
106
107		public function testOptions()
108		{
109		$actualId = $this->basket->insert([
110		'id' => 'foo',
111		'name' => 'bar',
112		'price' => 100,
113		'quantity' => 1,
114		'weight' => 200,
115		'options' => [
116		'size' => 'L',
117		],
118		]);
119
120		$item = $this->basket->item($actualId);
121
122		$this->assertTrue($item->hasOptions());
123		$this->assertNotEmpty($item->options);
124
125		$item->options = [];
126
127		$this->assertFalse($item->hasOptions());
128		$this->assertEmpty($item->options);
129		}
130
131		public function testWeight()
132		{
133		$weight = rand(200, 300);
134
135		$this->basket->insert([
136		'id' => 'foo',
137		'name' => 'bar',
138		'price' => 100,
139		'quantity' => 1,
140		'weight' => $weight,
141		'options' => [
142		'size' => 'L',
143		],
144		]);
145
146		// Test that the total weight is being calculated successfully
147		$this->assertEquals($this->basket->weight(), $weight);
148		}
149
150	View Code Duplication	public function testWeightOption()
		0 ignored issues – show Duplication introduced 2017-09-17 19:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
151		{
152		$weight = rand(200, 300);
153		$weight_option = rand(50, 800);
154		$quantity = rand(1, 10);
155
156		$this->basket->insert([
157		'id' => 'foo',
158		'name' => 'bar',
159		'price' => 100,
160		'quantity' => $quantity ,
161		'weight' => $weight,
162		'options' => [
163		'size' => 'L',
164		'weight' => $weight_option,
165		],
166		]);
167
168		// Test that the total weight is being calculated successfully
169		$this->assertEquals($this->basket->weight(), ($weight + $weight_option) * $quantity );
170		}
171
172	View Code Duplication	public function testPriceOption()
		0 ignored issues – show Duplication introduced 2017-09-17 19:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
173		{
174		$weight = rand(200, 300);
175		$weight_option = rand(50, 800);
176		$quantity = rand(1, 10);
177
178		$this->basket->insert([
179		'id' => 'foo',
180		'name' => 'bar',
181		'price' => 100,
182		'quantity' => $quantity ,
183		'weight' => $weight,
184		'options' => [
185		'size' => 'L',
186		'weight' => $weight_option,
187		],
188		]);
189
190		// Test that the total weight is being calculated successfully
191		$this->assertEquals($this->basket->weight(), ($weight + $weight_option) * $quantity );
192		}
193
194		public function testFind()
195		{
196		$this->basket->insert([
197		'id' => 'foo',
198		'name' => 'bar',
199		'price' => 100,
200		'quantity' => 1,
201		'weight' => 200,
202		]);
203
204		$this->assertInstanceOf('\Lenius\Basket\Item', $this->basket->find('foo'));
205		}
206
207		public function testTotals()
208		{
209		// Generate a random price and quantity
210		$price = rand(20, 99999);
211		$quantity = rand(1, 10);
212
213		$this->basket->insert([
214		'id' => 'foo',
215		'name' => 'bar',
216		'price' => $price,
217		'quantity' => $quantity,
218		'weight' => 200,
219		]);
220
221		// Test that the total is being calculated successfully
222		$this->assertEquals($this->basket->total(), $price * $quantity);
223		}
224
225		public function testTotalItems()
226		{
227		$adding = rand(1, 200);
228		$actualTotal = 0;
229
230		for ($i = 1; $i <= $adding; $i++) {
231		$quantity = rand(1, 20);
232
233		$this->basket->insert([
234		'id' => uniqid(),
235		'name' => 'bar',
236		'price' => 100,
237		'quantity' => $quantity,
238		'weight' => 200,
239		]);
240
241		$actualTotal += $quantity;
242		}
243
244		$this->assertEquals($this->basket->totalItems(), $actualTotal);
245		$this->assertEquals($this->basket->totalItems(true), $adding);
246		}
247
248	View Code Duplication	public function testItemRemoval()
		1 ignored issue – show Duplication introduced 2017-09-17 16:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
249		{
250		$this->basket->insert([
251		'id' => 'foo',
252		'name' => 'bar',
253		'price' => 100,
254		'quantity' => 1,
255		'weight' => 200,
256		]);
257
258		$contents = &$this->basket->contents();
259
260		$this->assertNotEmpty($contents);
261
262		foreach ($contents as $item) {
263		$item->remove();
264		}
265
266		$this->assertEmpty($contents);
267		}
268
269	View Code Duplication	public function testAlternateItemRemoval()
		1 ignored issue – show Duplication introduced 2017-09-17 16:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
270		{
271		$this->basket->insert([
272		'id' => 'foo',
273		'name' => 'bar',
274		'price' => 100,
275		'quantity' => 1,
276		'weight' => 200,
277		]);
278
279		$contents = &$this->basket->contents();
280
281		$this->assertNotEmpty($contents);
282
283		foreach ($contents as $identifier => $item) {
284		$this->basket->remove($identifier);
285		}
286
287		$this->assertEmpty($contents);
288		}
289
290	View Code Duplication	public function testItemToArray()
		1 ignored issue – show Duplication introduced 2017-09-17 16:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
291		{
292		$actualId = $this->basket->insert([
293		'id' => 'foo',
294		'name' => 'bar',
295		'price' => 100,
296		'quantity' => 1,
297		'weight' => 200,
298		]);
299
300		$this->assertTrue(is_array($this->basket->item($actualId)->toArray()));
301		}
302
303	View Code Duplication	public function testbasketToArray()
		1 ignored issue – show Duplication introduced 2017-09-17 16:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
304		{
305		$this->basket->insert([
306		'id' => 'foo',
307		'name' => 'bar',
308		'price' => 100,
309		'quantity' => 1,
310		'weight' => 200,
311		]);
312
313		foreach ($this->basket->contents(true) as $item) {
314		$this->assertTrue(is_array($item));
315		}
316		}
317
318	View Code Duplication	public function testTax()
		1 ignored issue – show Duplication introduced 2017-09-17 19:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
319		{
320		$this->basket->insert([
321		'id' => 'foo',
322		'name' => 'bar',
323		'price' => 100,
324		'quantity' => 1,
325		'tax' => 20,
326		'weight' => 200,
327		]);
328
329		// Test that the tax is being calculated successfully
330		$this->assertEquals($this->basket->total(), 120);
331
332		// Test that the total method can also return the pre-tax price if false is passed
333		$this->assertEquals($this->basket->total(false), 100);
334		}
335
336	View Code Duplication	public function testTaxMultiply()
		1 ignored issue – show Duplication introduced 2017-09-17 19:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
337		{
338		$this->basket->insert([
339		'id' => 'foo',
340		'name' => 'bar',
341		'price' => 100,
342		'quantity' => 2,
343		'tax' => 20,
344		'weight' => 200,
345		]);
346
347		// Test that the tax is being calculated successfully
348		$this->assertEquals($this->basket->total(), 240);
349
350		// Test that the total method can also return the pre-tax price if false is passed
351		$this->assertEquals($this->basket->total(false), 200);
352		}
353
354		public function testTaxUpdate()
355		{
356		$this->basket->insert([
357		'id' => 'foo',
358		'name' => 'bar',
359		'price' => 100,
360		'quantity' => 1,
361		'tax' => 20,
362		'weight' => 200,
363		]);
364
365		$identifier = md5('foo'.serialize([]));
366
367		$item = $this->basket->item($identifier);
368
369		// Test that the tax is being calculated successfully
370		$item->tax = 0;
371		$this->assertEquals($item->total(), 100);
372		$this->assertEquals($item->total(false), 100);
373
374		$item->tax = 20;
375		$this->assertEquals($item->total(), 120);
376		$this->assertEquals($item->total(false), 100);
377
378		$item->update('tax', 0);
379		$this->assertEquals($item->total(), 100);
380		$this->assertEquals($item->total(false), 100);
381
382		$item->update('tax', 20);
383		$this->assertEquals($item->total(), 120);
384		$this->assertEquals($item->total(false), 100);
385		}
386		}
387

Lenius / basket

Push — master ( 9b693b...3fb0bb )

BasketTest::testPriceOption() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like