Complex classes like Article often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Article, and based on these observations, apply Extract Interface, too.
| 1 | <?php | ||
| 15 | class Article extends Base | ||
| 16 | { | ||
| 17 | /** | ||
| 18 | * @var int | ||
| 19 | */ | ||
| 20 | protected $id; | ||
| 21 | /** | ||
| 22 | * @var int | ||
| 23 | */ | ||
| 24 | protected $mainDetailId; | ||
| 25 | /** | ||
| 26 | * @var int | ||
| 27 | */ | ||
| 28 | protected $supplierId; | ||
| 29 | /** | ||
| 30 | * @var int | ||
| 31 | */ | ||
| 32 | protected $taxId; | ||
| 33 | /** | ||
| 34 | * @var int | ||
| 35 | */ | ||
| 36 | protected $priceGroupId; | ||
| 37 | /** | ||
| 38 | * @var int | ||
| 39 | */ | ||
| 40 | protected $filterGroupId; | ||
| 41 | /** | ||
| 42 | * @var int | ||
| 43 | */ | ||
| 44 | protected $configuratorSetId; | ||
| 45 | /** | ||
| 46 | * @var string | ||
| 47 | */ | ||
| 48 | protected $name; | ||
| 49 | /** | ||
| 50 | * @var string | ||
| 51 | */ | ||
| 52 | protected $description; | ||
| 53 | /** | ||
| 54 | * @var string | ||
| 55 | */ | ||
| 56 | protected $descriptionLong; | ||
| 57 | /** | ||
| 58 | * @var string | ||
| 59 | */ | ||
| 60 | protected $added; | ||
| 61 | /** | ||
| 62 | * @var bool | ||
| 63 | */ | ||
| 64 | protected $active; | ||
| 65 | /** | ||
| 66 | * @var int | ||
| 67 | */ | ||
| 68 | protected $pseudoSales; | ||
| 69 | /** | ||
| 70 | * @var bool | ||
| 71 | */ | ||
| 72 | protected $highlight; | ||
| 73 | /** | ||
| 74 | * @var string | ||
| 75 | */ | ||
| 76 | protected $keywords; | ||
| 77 | /** | ||
| 78 | * @var string | ||
| 79 | */ | ||
| 80 | protected $metaTitle; | ||
| 81 | /** | ||
| 82 | * @var string | ||
| 83 | */ | ||
| 84 | protected $changed; | ||
| 85 | /** | ||
| 86 | * @var bool | ||
| 87 | */ | ||
| 88 | protected $priceGroupActive; | ||
| 89 | /** | ||
| 90 | * @var bool | ||
| 91 | */ | ||
| 92 | protected $lastStock; | ||
| 93 | /** | ||
| 94 | * @var bool | ||
| 95 | */ | ||
| 96 | protected $crossBundleLook; | ||
| 97 | /** | ||
| 98 | * @var bool | ||
| 99 | */ | ||
| 100 | protected $notification; | ||
| 101 | /** | ||
| 102 | * @var string | ||
| 103 | */ | ||
| 104 | protected $template; | ||
| 105 | /** | ||
| 106 | * @var int | ||
| 107 | */ | ||
| 108 | protected $mode; | ||
| 109 | /** | ||
| 110 | * @var string | ||
| 111 | */ | ||
| 112 | protected $availableFrom; | ||
| 113 | /** | ||
| 114 | * @var string | ||
| 115 | */ | ||
| 116 | protected $availableTo; | ||
| 117 | /** | ||
| 118 | * @var ArticleAttribute | ||
| 119 | */ | ||
| 120 | protected $attribute; | ||
| 121 | |||
| 122 | /** | ||
| 123 | * @return int | ||
| 124 | */ | ||
| 125 | 4 | public function getId() | |
| 129 | |||
| 130 | /** | ||
| 131 | * @param int $id | ||
| 132 | * | ||
| 133 | * @return Article | ||
| 134 | */ | ||
| 135 | 5 | public function setId($id) | |
| 141 | |||
| 142 | /** | ||
| 143 | * @return int | ||
| 144 | */ | ||
| 145 | 2 | public function getMainDetailId() | |
| 149 | |||
| 150 | /** | ||
| 151 | * @param int $mainDetailId | ||
| 152 | * | ||
| 153 | * @return Article | ||
| 154 | */ | ||
| 155 | 5 | public function setMainDetailId($mainDetailId) | |
| 161 | |||
| 162 | /** | ||
| 163 | * @return int | ||
| 164 | */ | ||
| 165 | public function getSupplierId() | ||
| 169 | |||
| 170 | /** | ||
| 171 | * @param int $supplierId | ||
| 172 | * | ||
| 173 | * @return Article | ||
| 174 | */ | ||
| 175 | 5 | public function setSupplierId($supplierId) | |
| 181 | |||
| 182 | /** | ||
| 183 | * @return int | ||
| 184 | */ | ||
| 185 | public function getTaxId() | ||
| 189 | |||
| 190 | /** | ||
| 191 | * @param int $taxId | ||
| 192 | * | ||
| 193 | * @return Article | ||
| 194 | */ | ||
| 195 | 5 | public function setTaxId($taxId) | |
| 201 | |||
| 202 | /** | ||
| 203 | * @return int | ||
| 204 | */ | ||
| 205 | public function getPriceGroupId() | ||
| 209 | |||
| 210 | /** | ||
| 211 | * @param int $priceGroupId | ||
| 212 | * | ||
| 213 | * @return Article | ||
| 214 | */ | ||
| 215 | 5 | public function setPriceGroupId($priceGroupId) | |
| 221 | |||
| 222 | /** | ||
| 223 | * @return int | ||
| 224 | */ | ||
| 225 | public function getFilterGroupId() | ||
| 229 | |||
| 230 | /** | ||
| 231 | * @param int $filterGroupId | ||
| 232 | * | ||
| 233 | * @return Article | ||
| 234 | */ | ||
| 235 | 5 | public function setFilterGroupId($filterGroupId) | |
| 241 | |||
| 242 | /** | ||
| 243 | * @return int | ||
| 244 | */ | ||
| 245 | public function getConfiguratorSetId() | ||
| 249 | |||
| 250 | /** | ||
| 251 | * @param int $configuratorSetId | ||
| 252 | * | ||
| 253 | * @return Article | ||
| 254 | */ | ||
| 255 | 5 | public function setConfiguratorSetId($configuratorSetId) | |
| 261 | |||
| 262 | /** | ||
| 263 | * @return string | ||
| 264 | */ | ||
| 265 | 4 | public function getName() | |
| 269 | |||
| 270 | /** | ||
| 271 | * @param string $name | ||
| 272 | * | ||
| 273 | * @return Article | ||
| 274 | */ | ||
| 275 | 5 | public function setName($name) | |
| 281 | |||
| 282 | /** | ||
| 283 | * @return string | ||
| 284 | */ | ||
| 285 | public function getDescription() | ||
| 289 | |||
| 290 | /** | ||
| 291 | * @param string $description | ||
| 292 | * | ||
| 293 | * @return Article | ||
| 294 | */ | ||
| 295 | 5 | public function setDescription($description) | |
| 301 | |||
| 302 | /** | ||
| 303 | * @return string | ||
| 304 | */ | ||
| 305 | public function getDescriptionLong() | ||
| 309 | |||
| 310 | /** | ||
| 311 | * @param string $descriptionLong | ||
| 312 | * | ||
| 313 | * @return Article | ||
| 314 | */ | ||
| 315 | 5 | public function setDescriptionLong($descriptionLong) | |
| 321 | |||
| 322 | /** | ||
| 323 | * @return string | ||
| 324 | */ | ||
| 325 | public function getAdded() | ||
| 329 | |||
| 330 | /** | ||
| 331 | * @param string $added | ||
| 332 | * | ||
| 333 | * @return Article | ||
| 334 | */ | ||
| 335 | 5 | public function setAdded($added) | |
| 341 | |||
| 342 | /** | ||
| 343 | * @return bool | ||
| 344 | */ | ||
| 345 | 2 | public function isActive() | |
| 349 | |||
| 350 | /** | ||
| 351 | * @param bool $active | ||
| 352 | * | ||
| 353 | * @return Article | ||
| 354 | */ | ||
| 355 | 5 | public function setActive($active) | |
| 361 | |||
| 362 | /** | ||
| 363 | * @return int | ||
| 364 | */ | ||
| 365 | public function getPseudoSales() | ||
| 369 | |||
| 370 | /** | ||
| 371 | * @param int $pseudoSales | ||
| 372 | * | ||
| 373 | * @return Article | ||
| 374 | */ | ||
| 375 | 5 | public function setPseudoSales($pseudoSales) | |
| 381 | |||
| 382 | /** | ||
| 383 | * @return bool | ||
| 384 | */ | ||
| 385 | public function isHighlight() | ||
| 389 | |||
| 390 | /** | ||
| 391 | * @param bool $highlight | ||
| 392 | * | ||
| 393 | * @return Article | ||
| 394 | */ | ||
| 395 | 5 | public function setHighlight($highlight) | |
| 401 | |||
| 402 | /** | ||
| 403 | * @return string | ||
| 404 | */ | ||
| 405 | public function getKeywords() | ||
| 409 | |||
| 410 | /** | ||
| 411 | * @param string $keywords | ||
| 412 | * | ||
| 413 | * @return Article | ||
| 414 | */ | ||
| 415 | 5 | public function setKeywords($keywords) | |
| 421 | |||
| 422 | /** | ||
| 423 | * @return string | ||
| 424 | */ | ||
| 425 | public function getMetaTitle() | ||
| 429 | |||
| 430 | /** | ||
| 431 | * @param string $metaTitle | ||
| 432 | * | ||
| 433 | * @return Article | ||
| 434 | */ | ||
| 435 | 5 | public function setMetaTitle($metaTitle) | |
| 441 | |||
| 442 | /** | ||
| 443 | * @return string | ||
| 444 | */ | ||
| 445 | public function getChanged() | ||
| 449 | |||
| 450 | /** | ||
| 451 | * @param string $changed | ||
| 452 | * | ||
| 453 | * @return Article | ||
| 454 | */ | ||
| 455 | public function setChanged($changed) | ||
| 461 | |||
| 462 | /** | ||
| 463 | * @return bool | ||
| 464 | */ | ||
| 465 | public function isPriceGroupActive() | ||
| 469 | |||
| 470 | /** | ||
| 471 | * @param bool $priceGroupActive | ||
| 472 | * | ||
| 473 | * @return Article | ||
| 474 | */ | ||
| 475 | 5 | public function setPriceGroupActive($priceGroupActive) | |
| 481 | |||
| 482 | /** | ||
| 483 | * @return bool | ||
| 484 | */ | ||
| 485 | public function isLastStock() | ||
| 489 | |||
| 490 | /** | ||
| 491 | * @param bool $lastStock | ||
| 492 | * | ||
| 493 | * @return Article | ||
| 494 | */ | ||
| 495 | 5 | public function setLastStock($lastStock) | |
| 501 | |||
| 502 | /** | ||
| 503 | * @return bool | ||
| 504 | */ | ||
| 505 | public function isCrossBundleLook() | ||
| 509 | |||
| 510 | /** | ||
| 511 | * @param bool $crossBundleLook | ||
| 512 | * | ||
| 513 | * @return Article | ||
| 514 | */ | ||
| 515 | 5 | public function setCrossBundleLook($crossBundleLook) | |
| 521 | |||
| 522 | /** | ||
| 523 | * @return bool | ||
| 524 | */ | ||
| 525 | public function isNotification() | ||
| 529 | |||
| 530 | /** | ||
| 531 | * @param bool $notification | ||
| 532 | * | ||
| 533 | * @return Article | ||
| 534 | */ | ||
| 535 | 5 | public function setNotification($notification) | |
| 541 | |||
| 542 | /** | ||
| 543 | * @return string | ||
| 544 | */ | ||
| 545 | public function getTemplate() | ||
| 549 | |||
| 550 | /** | ||
| 551 | * @param string $template | ||
| 552 | * | ||
| 553 | * @return Article | ||
| 554 | */ | ||
| 555 | 5 | public function setTemplate($template) | |
| 561 | |||
| 562 | /** | ||
| 563 | * @return int | ||
| 564 | */ | ||
| 565 | public function getMode() | ||
| 569 | |||
| 570 | /** | ||
| 571 | * @param int $mode | ||
| 572 | * | ||
| 573 | * @return Article | ||
| 574 | */ | ||
| 575 | 5 | public function setMode($mode) | |
| 581 | |||
| 582 | /** | ||
| 583 | * @return string | ||
| 584 | */ | ||
| 585 | public function getAvailableFrom() | ||
| 589 | |||
| 590 | /** | ||
| 591 | * @param string $availableFrom | ||
| 592 | * | ||
| 593 | * @return Article | ||
| 594 | */ | ||
| 595 | 5 | public function setAvailableFrom($availableFrom) | |
| 601 | |||
| 602 | /** | ||
| 603 | * @return string | ||
| 604 | */ | ||
| 605 | public function getAvailableTo() | ||
| 609 | |||
| 610 | /** | ||
| 611 | * @param string $availableTo | ||
| 612 | * | ||
| 613 | * @return Article | ||
| 614 | */ | ||
| 615 | 5 | public function setAvailableTo($availableTo) | |
| 621 | |||
| 622 | /** | ||
| 623 | * @return array | ||
| 624 | */ | ||
| 625 | public function getAttributes() | ||
| 629 | |||
| 630 | /** | ||
| 631 | * @param ArticleAttribute $attributes | ||
| 632 | * | ||
| 633 | * @return Article | ||
| 634 | */ | ||
| 635 | public function setAttributes($attributes) | ||
| 641 | } | ||
| 642 |