Complex classes like Article often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Article, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | class Article extends Base |
||
| 16 | { |
||
| 17 | /** |
||
| 18 | * @var int |
||
| 19 | */ |
||
| 20 | protected $id; |
||
| 21 | /** |
||
| 22 | * @var int |
||
| 23 | */ |
||
| 24 | protected $mainDetailId; |
||
| 25 | /** |
||
| 26 | * @var int |
||
| 27 | */ |
||
| 28 | protected $supplierId; |
||
| 29 | /** |
||
| 30 | * @var int |
||
| 31 | */ |
||
| 32 | protected $taxId; |
||
| 33 | /** |
||
| 34 | * @var int |
||
| 35 | */ |
||
| 36 | protected $priceGroupId; |
||
| 37 | /** |
||
| 38 | * @var int |
||
| 39 | */ |
||
| 40 | protected $filterGroupId; |
||
| 41 | /** |
||
| 42 | * @var int |
||
| 43 | */ |
||
| 44 | protected $configuratorSetId; |
||
| 45 | /** |
||
| 46 | * @var string |
||
| 47 | */ |
||
| 48 | protected $name; |
||
| 49 | /** |
||
| 50 | * @var string |
||
| 51 | */ |
||
| 52 | protected $description; |
||
| 53 | /** |
||
| 54 | * @var string |
||
| 55 | */ |
||
| 56 | protected $descriptionLong; |
||
| 57 | /** |
||
| 58 | * @var string |
||
| 59 | */ |
||
| 60 | protected $added; |
||
| 61 | /** |
||
| 62 | * @var bool |
||
| 63 | */ |
||
| 64 | protected $active; |
||
| 65 | /** |
||
| 66 | * @var int |
||
| 67 | */ |
||
| 68 | protected $pseudoSales; |
||
| 69 | /** |
||
| 70 | * @var bool |
||
| 71 | */ |
||
| 72 | protected $highlight; |
||
| 73 | /** |
||
| 74 | * @var string |
||
| 75 | */ |
||
| 76 | protected $keywords; |
||
| 77 | /** |
||
| 78 | * @var string |
||
| 79 | */ |
||
| 80 | protected $metaTitle; |
||
| 81 | /** |
||
| 82 | * @var string |
||
| 83 | */ |
||
| 84 | protected $changed; |
||
| 85 | /** |
||
| 86 | * @var bool |
||
| 87 | */ |
||
| 88 | protected $priceGroupActive; |
||
| 89 | /** |
||
| 90 | * @var bool |
||
| 91 | */ |
||
| 92 | protected $lastStock; |
||
| 93 | /** |
||
| 94 | * @var bool |
||
| 95 | */ |
||
| 96 | protected $crossBundleLook; |
||
| 97 | /** |
||
| 98 | * @var bool |
||
| 99 | */ |
||
| 100 | protected $notification; |
||
| 101 | /** |
||
| 102 | * @var string |
||
| 103 | */ |
||
| 104 | protected $template; |
||
| 105 | /** |
||
| 106 | * @var int |
||
| 107 | */ |
||
| 108 | protected $mode; |
||
| 109 | /** |
||
| 110 | * @var string |
||
| 111 | */ |
||
| 112 | protected $availableFrom; |
||
| 113 | /** |
||
| 114 | * @var string |
||
| 115 | */ |
||
| 116 | protected $availableTo; |
||
| 117 | /** |
||
| 118 | * @var ArticleAttribute |
||
| 119 | */ |
||
| 120 | protected $attribute; |
||
| 121 | /** |
||
| 122 | * @var Category[] |
||
| 123 | */ |
||
| 124 | protected $categories; |
||
| 125 | |||
| 126 | /** |
||
| 127 | * @return int |
||
| 128 | */ |
||
| 129 | 4 | public function getId() |
|
| 133 | |||
| 134 | /** |
||
| 135 | * @param int $id |
||
| 136 | * |
||
| 137 | * @return Article |
||
| 138 | */ |
||
| 139 | 5 | public function setId($id) |
|
| 145 | |||
| 146 | /** |
||
| 147 | * @return int |
||
| 148 | */ |
||
| 149 | 2 | public function getMainDetailId() |
|
| 153 | |||
| 154 | /** |
||
| 155 | * @param int $mainDetailId |
||
| 156 | * |
||
| 157 | * @return Article |
||
| 158 | */ |
||
| 159 | 5 | public function setMainDetailId($mainDetailId) |
|
| 165 | |||
| 166 | /** |
||
| 167 | * @return int |
||
| 168 | */ |
||
| 169 | public function getSupplierId() |
||
| 173 | |||
| 174 | /** |
||
| 175 | * @param int $supplierId |
||
| 176 | * |
||
| 177 | * @return Article |
||
| 178 | */ |
||
| 179 | 5 | public function setSupplierId($supplierId) |
|
| 185 | |||
| 186 | /** |
||
| 187 | * @return int |
||
| 188 | */ |
||
| 189 | public function getTaxId() |
||
| 193 | |||
| 194 | /** |
||
| 195 | * @param int $taxId |
||
| 196 | * |
||
| 197 | * @return Article |
||
| 198 | */ |
||
| 199 | 5 | public function setTaxId($taxId) |
|
| 205 | |||
| 206 | /** |
||
| 207 | * @return int |
||
| 208 | */ |
||
| 209 | public function getPriceGroupId() |
||
| 213 | |||
| 214 | /** |
||
| 215 | * @param int $priceGroupId |
||
| 216 | * |
||
| 217 | * @return Article |
||
| 218 | */ |
||
| 219 | 5 | public function setPriceGroupId($priceGroupId) |
|
| 225 | |||
| 226 | /** |
||
| 227 | * @return int |
||
| 228 | */ |
||
| 229 | public function getFilterGroupId() |
||
| 233 | |||
| 234 | /** |
||
| 235 | * @param int $filterGroupId |
||
| 236 | * |
||
| 237 | * @return Article |
||
| 238 | */ |
||
| 239 | 5 | public function setFilterGroupId($filterGroupId) |
|
| 245 | |||
| 246 | /** |
||
| 247 | * @return int |
||
| 248 | */ |
||
| 249 | public function getConfiguratorSetId() |
||
| 253 | |||
| 254 | /** |
||
| 255 | * @param int $configuratorSetId |
||
| 256 | * |
||
| 257 | * @return Article |
||
| 258 | */ |
||
| 259 | 5 | public function setConfiguratorSetId($configuratorSetId) |
|
| 265 | |||
| 266 | /** |
||
| 267 | * @return string |
||
| 268 | */ |
||
| 269 | 4 | public function getName() |
|
| 273 | |||
| 274 | /** |
||
| 275 | * @param string $name |
||
| 276 | * |
||
| 277 | * @return Article |
||
| 278 | */ |
||
| 279 | 5 | public function setName($name) |
|
| 285 | |||
| 286 | /** |
||
| 287 | * @return string |
||
| 288 | */ |
||
| 289 | public function getDescription() |
||
| 293 | |||
| 294 | /** |
||
| 295 | * @param string $description |
||
| 296 | * |
||
| 297 | * @return Article |
||
| 298 | */ |
||
| 299 | 5 | public function setDescription($description) |
|
| 305 | |||
| 306 | /** |
||
| 307 | * @return string |
||
| 308 | */ |
||
| 309 | public function getDescriptionLong() |
||
| 313 | |||
| 314 | /** |
||
| 315 | * @param string $descriptionLong |
||
| 316 | * |
||
| 317 | * @return Article |
||
| 318 | */ |
||
| 319 | 5 | public function setDescriptionLong($descriptionLong) |
|
| 325 | |||
| 326 | /** |
||
| 327 | * @return string |
||
| 328 | */ |
||
| 329 | public function getAdded() |
||
| 333 | |||
| 334 | /** |
||
| 335 | * @param string $added |
||
| 336 | * |
||
| 337 | * @return Article |
||
| 338 | */ |
||
| 339 | 5 | public function setAdded($added) |
|
| 345 | |||
| 346 | /** |
||
| 347 | * @return bool |
||
| 348 | */ |
||
| 349 | 2 | public function isActive() |
|
| 353 | |||
| 354 | /** |
||
| 355 | * @param bool $active |
||
| 356 | * |
||
| 357 | * @return Article |
||
| 358 | */ |
||
| 359 | 5 | public function setActive($active) |
|
| 365 | |||
| 366 | /** |
||
| 367 | * @return int |
||
| 368 | */ |
||
| 369 | public function getPseudoSales() |
||
| 373 | |||
| 374 | /** |
||
| 375 | * @param int $pseudoSales |
||
| 376 | * |
||
| 377 | * @return Article |
||
| 378 | */ |
||
| 379 | 5 | public function setPseudoSales($pseudoSales) |
|
| 385 | |||
| 386 | /** |
||
| 387 | * @return bool |
||
| 388 | */ |
||
| 389 | public function isHighlight() |
||
| 393 | |||
| 394 | /** |
||
| 395 | * @param bool $highlight |
||
| 396 | * |
||
| 397 | * @return Article |
||
| 398 | */ |
||
| 399 | 5 | public function setHighlight($highlight) |
|
| 405 | |||
| 406 | /** |
||
| 407 | * @return string |
||
| 408 | */ |
||
| 409 | public function getKeywords() |
||
| 413 | |||
| 414 | /** |
||
| 415 | * @param string $keywords |
||
| 416 | * |
||
| 417 | * @return Article |
||
| 418 | */ |
||
| 419 | 5 | public function setKeywords($keywords) |
|
| 425 | |||
| 426 | /** |
||
| 427 | * @return string |
||
| 428 | */ |
||
| 429 | public function getMetaTitle() |
||
| 433 | |||
| 434 | /** |
||
| 435 | * @param string $metaTitle |
||
| 436 | * |
||
| 437 | * @return Article |
||
| 438 | */ |
||
| 439 | 5 | public function setMetaTitle($metaTitle) |
|
| 445 | |||
| 446 | /** |
||
| 447 | * @return string |
||
| 448 | */ |
||
| 449 | public function getChanged() |
||
| 453 | |||
| 454 | /** |
||
| 455 | * @param string $changed |
||
| 456 | * |
||
| 457 | * @return Article |
||
| 458 | */ |
||
| 459 | public function setChanged($changed) |
||
| 465 | |||
| 466 | /** |
||
| 467 | * @return bool |
||
| 468 | */ |
||
| 469 | public function isPriceGroupActive() |
||
| 473 | |||
| 474 | /** |
||
| 475 | * @param bool $priceGroupActive |
||
| 476 | * |
||
| 477 | * @return Article |
||
| 478 | */ |
||
| 479 | 5 | public function setPriceGroupActive($priceGroupActive) |
|
| 485 | |||
| 486 | /** |
||
| 487 | * @return bool |
||
| 488 | */ |
||
| 489 | public function isLastStock() |
||
| 493 | |||
| 494 | /** |
||
| 495 | * @param bool $lastStock |
||
| 496 | * |
||
| 497 | * @return Article |
||
| 498 | */ |
||
| 499 | 5 | public function setLastStock($lastStock) |
|
| 505 | |||
| 506 | /** |
||
| 507 | * @return bool |
||
| 508 | */ |
||
| 509 | public function isCrossBundleLook() |
||
| 513 | |||
| 514 | /** |
||
| 515 | * @param bool $crossBundleLook |
||
| 516 | * |
||
| 517 | * @return Article |
||
| 518 | */ |
||
| 519 | 5 | public function setCrossBundleLook($crossBundleLook) |
|
| 525 | |||
| 526 | /** |
||
| 527 | * @return bool |
||
| 528 | */ |
||
| 529 | public function isNotification() |
||
| 533 | |||
| 534 | /** |
||
| 535 | * @param bool $notification |
||
| 536 | * |
||
| 537 | * @return Article |
||
| 538 | */ |
||
| 539 | 5 | public function setNotification($notification) |
|
| 545 | |||
| 546 | /** |
||
| 547 | * @return string |
||
| 548 | */ |
||
| 549 | public function getTemplate() |
||
| 553 | |||
| 554 | /** |
||
| 555 | * @param string $template |
||
| 556 | * |
||
| 557 | * @return Article |
||
| 558 | */ |
||
| 559 | 5 | public function setTemplate($template) |
|
| 565 | |||
| 566 | /** |
||
| 567 | * @return int |
||
| 568 | */ |
||
| 569 | public function getMode() |
||
| 573 | |||
| 574 | /** |
||
| 575 | * @param int $mode |
||
| 576 | * |
||
| 577 | * @return Article |
||
| 578 | */ |
||
| 579 | 5 | public function setMode($mode) |
|
| 585 | |||
| 586 | /** |
||
| 587 | * @return string |
||
| 588 | */ |
||
| 589 | public function getAvailableFrom() |
||
| 593 | |||
| 594 | /** |
||
| 595 | * @param string $availableFrom |
||
| 596 | * |
||
| 597 | * @return Article |
||
| 598 | */ |
||
| 599 | 5 | public function setAvailableFrom($availableFrom) |
|
| 605 | |||
| 606 | /** |
||
| 607 | * @return string |
||
| 608 | */ |
||
| 609 | public function getAvailableTo() |
||
| 613 | |||
| 614 | /** |
||
| 615 | * @param string $availableTo |
||
| 616 | * |
||
| 617 | * @return Article |
||
| 618 | */ |
||
| 619 | 5 | public function setAvailableTo($availableTo) |
|
| 625 | |||
| 626 | /** |
||
| 627 | * @return array |
||
| 628 | */ |
||
| 629 | public function getAttributes() |
||
| 633 | |||
| 634 | /** |
||
| 635 | * @param ArticleAttribute $attributes |
||
| 636 | * |
||
| 637 | * @return Article |
||
| 638 | */ |
||
| 639 | public function setAttributes($attributes) |
||
| 645 | |||
| 646 | /** |
||
| 647 | * @return mixed |
||
| 648 | */ |
||
| 649 | public function getCategories() |
||
| 653 | |||
| 654 | /** |
||
| 655 | * @param Category[] $categories |
||
| 656 | * @return Article |
||
| 657 | */ |
||
| 658 | public function setCategories($categories) |
||
| 663 | |||
| 664 | } |
||
| 665 |