Complex classes like ArticleAttribute often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ArticleAttribute, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | class ArticleAttribute extends Base |
||
| 16 | { |
||
| 17 | /** |
||
| 18 | * @var mixed |
||
| 19 | */ |
||
| 20 | protected $attr1; |
||
| 21 | /** |
||
| 22 | * @var mixed |
||
| 23 | */ |
||
| 24 | protected $attr2; |
||
| 25 | /** |
||
| 26 | * @var mixed |
||
| 27 | */ |
||
| 28 | protected $attr3; |
||
| 29 | /** |
||
| 30 | * @var mixed |
||
| 31 | */ |
||
| 32 | protected $attr4; |
||
| 33 | /** |
||
| 34 | * @var mixed |
||
| 35 | */ |
||
| 36 | protected $attr5; |
||
| 37 | /** |
||
| 38 | * @var mixed |
||
| 39 | */ |
||
| 40 | protected $attr6; |
||
| 41 | /** |
||
| 42 | * @var mixed |
||
| 43 | */ |
||
| 44 | protected $attr7; |
||
| 45 | /** |
||
| 46 | * @var mixed |
||
| 47 | */ |
||
| 48 | protected $attr8; |
||
| 49 | /** |
||
| 50 | * @var mixed |
||
| 51 | */ |
||
| 52 | protected $attr9; |
||
| 53 | /** |
||
| 54 | * @var mixed |
||
| 55 | */ |
||
| 56 | protected $attr10; |
||
| 57 | /** |
||
| 58 | * @var mixed |
||
| 59 | */ |
||
| 60 | protected $attr11; |
||
| 61 | /** |
||
| 62 | * @var mixed |
||
| 63 | */ |
||
| 64 | protected $attr12; |
||
| 65 | /** |
||
| 66 | * @var mixed |
||
| 67 | */ |
||
| 68 | protected $attr13; |
||
| 69 | /** |
||
| 70 | * @var mixed |
||
| 71 | */ |
||
| 72 | protected $attr14; |
||
| 73 | /** |
||
| 74 | * @var mixed |
||
| 75 | */ |
||
| 76 | protected $attr15; |
||
| 77 | /** |
||
| 78 | * @var mixed |
||
| 79 | */ |
||
| 80 | protected $attr16; |
||
| 81 | /** |
||
| 82 | * @var mixed |
||
| 83 | */ |
||
| 84 | protected $attr17; |
||
| 85 | /** |
||
| 86 | * @var mixed |
||
| 87 | */ |
||
| 88 | protected $attr18; |
||
| 89 | /** |
||
| 90 | * @var mixed |
||
| 91 | */ |
||
| 92 | protected $attr19; |
||
| 93 | /** |
||
| 94 | * @var mixed |
||
| 95 | */ |
||
| 96 | protected $attr20; |
||
| 97 | /** |
||
| 98 | * @var int |
||
| 99 | */ |
||
| 100 | protected $articleId; |
||
| 101 | /** |
||
| 102 | * @var int |
||
| 103 | */ |
||
| 104 | protected $articleDetailId; |
||
| 105 | |||
| 106 | /** |
||
| 107 | * @return mixed |
||
| 108 | */ |
||
| 109 | public function getAttr1() |
||
| 113 | |||
| 114 | /** |
||
| 115 | * @param mixed $attr1 |
||
| 116 | * |
||
| 117 | * @return ArticleAttribute |
||
| 118 | */ |
||
| 119 | public function setAttr1($attr1) |
||
| 125 | |||
| 126 | /** |
||
| 127 | * @return mixed |
||
| 128 | */ |
||
| 129 | public function getAttr2() |
||
| 133 | |||
| 134 | /** |
||
| 135 | * @param mixed $attr2 |
||
| 136 | * |
||
| 137 | * @return ArticleAttribute |
||
| 138 | */ |
||
| 139 | public function setAttr2($attr2) |
||
| 145 | |||
| 146 | /** |
||
| 147 | * @return mixed |
||
| 148 | */ |
||
| 149 | public function getAttr3() |
||
| 153 | |||
| 154 | /** |
||
| 155 | * @param mixed $attr3 |
||
| 156 | * |
||
| 157 | * @return ArticleAttribute |
||
| 158 | */ |
||
| 159 | public function setAttr3($attr3) |
||
| 165 | |||
| 166 | /** |
||
| 167 | * @return mixed |
||
| 168 | */ |
||
| 169 | public function getAttr4() |
||
| 173 | |||
| 174 | /** |
||
| 175 | * @param mixed $attr4 |
||
| 176 | * |
||
| 177 | * @return ArticleAttribute |
||
| 178 | */ |
||
| 179 | public function setAttr4($attr4) |
||
| 185 | |||
| 186 | /** |
||
| 187 | * @return mixed |
||
| 188 | */ |
||
| 189 | public function getAttr5() |
||
| 193 | |||
| 194 | /** |
||
| 195 | * @param mixed $attr5 |
||
| 196 | * |
||
| 197 | * @return ArticleAttribute |
||
| 198 | */ |
||
| 199 | public function setAttr5($attr5) |
||
| 205 | |||
| 206 | /** |
||
| 207 | * @return mixed |
||
| 208 | */ |
||
| 209 | public function getAttr6() |
||
| 213 | |||
| 214 | /** |
||
| 215 | * @param mixed $attr6 |
||
| 216 | * |
||
| 217 | * @return ArticleAttribute |
||
| 218 | */ |
||
| 219 | public function setAttr6($attr6) |
||
| 225 | |||
| 226 | /** |
||
| 227 | * @return mixed |
||
| 228 | */ |
||
| 229 | public function getAttr7() |
||
| 233 | |||
| 234 | /** |
||
| 235 | * @param mixed $attr7 |
||
| 236 | * |
||
| 237 | * @return ArticleAttribute |
||
| 238 | */ |
||
| 239 | public function setAttr7($attr7) |
||
| 245 | |||
| 246 | /** |
||
| 247 | * @return mixed |
||
| 248 | */ |
||
| 249 | public function getAttr8() |
||
| 253 | |||
| 254 | /** |
||
| 255 | * @param mixed $attr8 |
||
| 256 | * |
||
| 257 | * @return ArticleAttribute |
||
| 258 | */ |
||
| 259 | public function setAttr8($attr8) |
||
| 265 | |||
| 266 | /** |
||
| 267 | * @return mixed |
||
| 268 | */ |
||
| 269 | public function getAttr9() |
||
| 273 | |||
| 274 | /** |
||
| 275 | * @param mixed $attr9 |
||
| 276 | * |
||
| 277 | * @return ArticleAttribute |
||
| 278 | */ |
||
| 279 | public function setAttr9($attr9) |
||
| 285 | |||
| 286 | /** |
||
| 287 | * @return mixed |
||
| 288 | */ |
||
| 289 | public function getAttr10() |
||
| 293 | |||
| 294 | /** |
||
| 295 | * @param mixed $attr10 |
||
| 296 | * |
||
| 297 | * @return ArticleAttribute |
||
| 298 | */ |
||
| 299 | public function setAttr10($attr10) |
||
| 305 | |||
| 306 | /** |
||
| 307 | * @return mixed |
||
| 308 | */ |
||
| 309 | public function getAttr11() |
||
| 313 | |||
| 314 | /** |
||
| 315 | * @param mixed $attr11 |
||
| 316 | * |
||
| 317 | * @return ArticleAttribute |
||
| 318 | */ |
||
| 319 | public function setAttr11($attr11) |
||
| 325 | |||
| 326 | /** |
||
| 327 | * @return mixed |
||
| 328 | */ |
||
| 329 | public function getAttr12() |
||
| 333 | |||
| 334 | /** |
||
| 335 | * @param mixed $attr12 |
||
| 336 | * |
||
| 337 | * @return ArticleAttribute |
||
| 338 | */ |
||
| 339 | public function setAttr12($attr12) |
||
| 345 | |||
| 346 | /** |
||
| 347 | * @return mixed |
||
| 348 | */ |
||
| 349 | public function getAttr13() |
||
| 353 | |||
| 354 | /** |
||
| 355 | * @param mixed $attr13 |
||
| 356 | * |
||
| 357 | * @return ArticleAttribute |
||
| 358 | */ |
||
| 359 | public function setAttr13($attr13) |
||
| 365 | |||
| 366 | /** |
||
| 367 | * @return mixed |
||
| 368 | */ |
||
| 369 | public function getAttr14() |
||
| 373 | |||
| 374 | /** |
||
| 375 | * @param mixed $attr14 |
||
| 376 | * |
||
| 377 | * @return ArticleAttribute |
||
| 378 | */ |
||
| 379 | public function setAttr14($attr14) |
||
| 385 | |||
| 386 | /** |
||
| 387 | * @return mixed |
||
| 388 | */ |
||
| 389 | public function getAttr15() |
||
| 393 | |||
| 394 | /** |
||
| 395 | * @param mixed $attr15 |
||
| 396 | * |
||
| 397 | * @return ArticleAttribute |
||
| 398 | */ |
||
| 399 | public function setAttr15($attr15) |
||
| 405 | |||
| 406 | /** |
||
| 407 | * @return mixed |
||
| 408 | */ |
||
| 409 | public function getAttr16() |
||
| 413 | |||
| 414 | /** |
||
| 415 | * @param mixed $attr16 |
||
| 416 | * |
||
| 417 | * @return ArticleAttribute |
||
| 418 | */ |
||
| 419 | public function setAttr16($attr16) |
||
| 425 | |||
| 426 | /** |
||
| 427 | * @return mixed |
||
| 428 | */ |
||
| 429 | public function getAttr17() |
||
| 433 | |||
| 434 | /** |
||
| 435 | * @param mixed $attr17 |
||
| 436 | * |
||
| 437 | * @return ArticleAttribute |
||
| 438 | */ |
||
| 439 | public function setAttr17($attr17) |
||
| 445 | |||
| 446 | /** |
||
| 447 | * @return mixed |
||
| 448 | */ |
||
| 449 | public function getAttr18() |
||
| 453 | |||
| 454 | /** |
||
| 455 | * @param mixed $attr18 |
||
| 456 | * |
||
| 457 | * @return ArticleAttribute |
||
| 458 | */ |
||
| 459 | public function setAttr18($attr18) |
||
| 465 | |||
| 466 | /** |
||
| 467 | * @return mixed |
||
| 468 | */ |
||
| 469 | public function getAttr19() |
||
| 473 | |||
| 474 | /** |
||
| 475 | * @param mixed $attr19 |
||
| 476 | * |
||
| 477 | * @return ArticleAttribute |
||
| 478 | */ |
||
| 479 | public function setAttr19($attr19) |
||
| 485 | |||
| 486 | /** |
||
| 487 | * @return mixed |
||
| 488 | */ |
||
| 489 | public function getAttr20() |
||
| 493 | |||
| 494 | /** |
||
| 495 | * @param mixed $attr20 |
||
| 496 | * |
||
| 497 | * @return ArticleAttribute |
||
| 498 | */ |
||
| 499 | public function setAttr20($attr20) |
||
| 505 | |||
| 506 | /** |
||
| 507 | * @return int |
||
| 508 | */ |
||
| 509 | public function getArticleId() |
||
| 513 | |||
| 514 | /** |
||
| 515 | * @param int $articleId |
||
| 516 | * |
||
| 517 | * @return ArticleAttribute |
||
| 518 | */ |
||
| 519 | public function setArticleId($articleId) |
||
| 525 | |||
| 526 | /** |
||
| 527 | * @return int |
||
| 528 | */ |
||
| 529 | public function getArticleDetailId() |
||
| 533 | |||
| 534 | /** |
||
| 535 | * @param int $articleDetailId |
||
| 536 | * |
||
| 537 | * @return ArticleAttribute |
||
| 538 | */ |
||
| 539 | public function setArticleDetailId($articleDetailId) |
||
| 545 | } |
||
| 546 |