DiscountParserTest::getProductResponseData() - Code Metrics - Inspection of "StudlyCaps Namespacing and Classes to PSR-1 standa..." - LauLamanApps/iZettleApi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

by Laurens

created 2017-10-24 16:02 UTC

DiscountParserTest::getProductResponseData() A

↳ Parent: DiscountParserTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	68
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	68
rs	9.2447
c	0
b	0
f	0
cc	1
eloc	50
nc	1
nop	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace LauLamanApps\IzettleApi\Tests\Unit\Client\Product;

use DateTime;
use LauLamanApps\IzettleApi\API\ImageCollection;
use LauLamanApps\IzettleApi\API\Product\Discount;
use LauLamanApps\IzettleApi\Client\Product\DiscountParser;
use Mockery;
use Money\Money;
use PHPUnit\Framework\TestCase;
use Psr\Http\Message\ResponseInterface;
use Ramsey\Uuid\Uuid;

/**
 * @small
 */
final class DiscountParserTest extends TestCase
{
    /**
     * @test
     * @dataProvider getProductResponseData
     */
    public function createFromResponse(ResponseInterface $response, $data)
    {
        /** @var Discount[] $discounts */
        $discounts = DiscountParser::createFromResponse($response);

        foreach ($discounts as $index => $discount) {
            self::assertInstanceOf(Discount::class, $discount);
            self::assertSame($data[$index]['uuid'], (string) $discount->getUuid());
            self::assertSame($data[$index]['name'], $discount->getName());
            self::assertSame($data[$index]['description'], $discount->getDescription());
            self::assertInstanceOf(ImageCollection::class, $discount->getImageCollection());
            self::assertSame($data[$index]['externalReference'], $discount->getExternalReference());
            self::assertSame($data[$index]['etag'], $discount->getEtag());
            self::assertEquals(new DateTime($data[$index]['updated']), $discount->getUpdatedAt());
            self::assertSame($data[$index]['updatedBy'], (string) $discount->getUpdatedBy());
            self::assertEquals(new DateTime($data[$index]['created']), $discount->getCreatedAt());

            if ($data[$index]['amount']) {
                self::assertInstanceOf(Money::class, $discount->getAmount());
                self::assertSame((string) $data[$index]['amount']['amount'], $discount->getAmount()->getAmount());
                self::assertSame($data[$index]['amount']['currencyId'], $discount->getAmount()->getCurrency()->getCode());
            } else {
                self::assertSame((float) $data[$index]['percentage'], $discount->getPercentage());
            }
        }
    }

    public function getProductResponseData(): array
    {
        $data1 = [[
            'uuid' => (string) Uuid::uuid1(),
            'name' => 'Some Product',
            'description' => 'description',
            'imageLookupKeys' => [
                'nice-image.jpeg',
            ],
            'amount' => ['amount' => 1000, 'currencyId' => 'EUR'],
            'percentage' => null,
            'externalReference' => 'externalReference',
            'etag' => 'B1C54B44DB967F4240B59AFA30B1AC5E',
            'updated' => '2017-12-06T13:21:59.722+0000',
            'updatedBy' => (string) Uuid::uuid1(),
            'created' => '2017-12-21T13:12:49.272+0000',
        ]];

        $mock1 = Mockery::mock(ResponseInterface::class);
        $mock1->shouldReceive('getBody')->andReturnSelf();
        $mock1->shouldReceive('getContents')->andReturn(json_encode(
            $data1
        ));

        $data2 = [
            [
                'uuid' => (string) Uuid::uuid1(),
                'name' => 'discount1',
                'description' => 'descriptionq',
                'imageLookupKeys' => [
                    'image1.jpeg',
                ],
                'amount' => ['amount' => 100, 'currencyId' => 'EUR'],
                'percentage' => null,
                'externalReference' => 'externalReference',
                'etag' => '93D4F5F748933923890C91056A6F0230',
                'updated' => '2017-12-06T13:21:59.722+0000',
                'updatedBy' => (string) Uuid::uuid1(),
                'created' => '2017-12-21T13:12:49.272+0000',
            ],
            [
                'uuid' => (string) Uuid::uuid1(),
                'name' => 'discount2',
                'description' => 'description2',
                'imageLookupKeys' => [
                    'image2.jpeg',
                ],
                'amount' => null,
                'percentage' => '10',
                'externalReference' => 'externalReference2',
                'etag' => '35D7775289BC0A05E580BE3B466C927B',
                'updated' => '2017-12-06T13:21:59.722+0000',
                'updatedBy' => (string) Uuid::uuid1(),
                'created' => '2017-12-21T13:12:49.272+0000',
            ]
        ];

        $mock2 = Mockery::mock(ResponseInterface::class);
        $mock2->shouldReceive('getBody')->andReturnSelf();
        $mock2->shouldReceive('getContents')->andReturn(json_encode(
            $data2
        ));

        return [
            'single discount' => [ $mock1, $data1 ],
            'multiple discount' => [ $mock2, $data2 ],
        ];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace LauLamanApps\IzettleApi\Tests\Unit\Client\Product;
6
7		use DateTime;
8		use LauLamanApps\IzettleApi\API\ImageCollection;
9		use LauLamanApps\IzettleApi\API\Product\Discount;
10		use LauLamanApps\IzettleApi\Client\Product\DiscountParser;
11		use Mockery;
12		use Money\Money;
13		use PHPUnit\Framework\TestCase;
14		use Psr\Http\Message\ResponseInterface;
15		use Ramsey\Uuid\Uuid;
16
17		/**
18		* @small
19		*/
20		final class DiscountParserTest extends TestCase
21		{
22		/**
23		* @test
24		* @dataProvider getProductResponseData
25		*/
26		public function createFromResponse(ResponseInterface $response, $data)
27		{
28		/** @var Discount[] $discounts */
29		$discounts = DiscountParser::createFromResponse($response);
30
31		foreach ($discounts as $index => $discount) {
32		self::assertInstanceOf(Discount::class, $discount);
33		self::assertSame($data[$index]['uuid'], (string) $discount->getUuid());
34		self::assertSame($data[$index]['name'], $discount->getName());
35		self::assertSame($data[$index]['description'], $discount->getDescription());
36		self::assertInstanceOf(ImageCollection::class, $discount->getImageCollection());
37		self::assertSame($data[$index]['externalReference'], $discount->getExternalReference());
38		self::assertSame($data[$index]['etag'], $discount->getEtag());
39		self::assertEquals(new DateTime($data[$index]['updated']), $discount->getUpdatedAt());
40		self::assertSame($data[$index]['updatedBy'], (string) $discount->getUpdatedBy());
41		self::assertEquals(new DateTime($data[$index]['created']), $discount->getCreatedAt());
42
43	View Code Duplication	if ($data[$index]['amount']) {
44		self::assertInstanceOf(Money::class, $discount->getAmount());
45		self::assertSame((string) $data[$index]['amount']['amount'], $discount->getAmount()->getAmount());
46		self::assertSame($data[$index]['amount']['currencyId'], $discount->getAmount()->getCurrency()->getCode());
47		} else {
48		self::assertSame((float) $data[$index]['percentage'], $discount->getPercentage());
49		}
50		}
51		}
52
53		public function getProductResponseData(): array
54		{
55		$data1 = [[
56		'uuid' => (string) Uuid::uuid1(),
57		'name' => 'Some Product',
58		'description' => 'description',
59		'imageLookupKeys' => [
60		'nice-image.jpeg',
61		],
62		'amount' => ['amount' => 1000, 'currencyId' => 'EUR'],
63		'percentage' => null,
64		'externalReference' => 'externalReference',
65		'etag' => 'B1C54B44DB967F4240B59AFA30B1AC5E',
66		'updated' => '2017-12-06T13:21:59.722+0000',
67		'updatedBy' => (string) Uuid::uuid1(),
68		'created' => '2017-12-21T13:12:49.272+0000',
69		]];
70
71		$mock1 = Mockery::mock(ResponseInterface::class);
72		$mock1->shouldReceive('getBody')->andReturnSelf();
73		$mock1->shouldReceive('getContents')->andReturn(json_encode(
74		$data1
75		));
76
77		$data2 = [
78		[
79		'uuid' => (string) Uuid::uuid1(),
80		'name' => 'discount1',
81		'description' => 'descriptionq',
82		'imageLookupKeys' => [
83		'image1.jpeg',
84		],
85		'amount' => ['amount' => 100, 'currencyId' => 'EUR'],
86		'percentage' => null,
87		'externalReference' => 'externalReference',
88		'etag' => '93D4F5F748933923890C91056A6F0230',
89		'updated' => '2017-12-06T13:21:59.722+0000',
90		'updatedBy' => (string) Uuid::uuid1(),
91		'created' => '2017-12-21T13:12:49.272+0000',
92		],
93		[
94		'uuid' => (string) Uuid::uuid1(),
95		'name' => 'discount2',
96		'description' => 'description2',
97		'imageLookupKeys' => [
98		'image2.jpeg',
99		],
100		'amount' => null,
101		'percentage' => '10',
102		'externalReference' => 'externalReference2',
103		'etag' => '35D7775289BC0A05E580BE3B466C927B',
104		'updated' => '2017-12-06T13:21:59.722+0000',
105		'updatedBy' => (string) Uuid::uuid1(),
106		'created' => '2017-12-21T13:12:49.272+0000',
107		]
108		];
109
110		$mock2 = Mockery::mock(ResponseInterface::class);
111		$mock2->shouldReceive('getBody')->andReturnSelf();
112		$mock2->shouldReceive('getContents')->andReturn(json_encode(
113		$data2
114		));
115
116		return [
117		'single discount' => [ $mock1, $data1 ],
118		'multiple discount' => [ $mock2, $data2 ],
119		];
120		}
121		}
122

LauLamanApps / iZettleApi

Pull Request — master (#6)

DiscountParserTest::getProductResponseData() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like