Conditions | 8 |
Paths | 44 |
Total Lines | 65 |
Code Lines | 51 |
Lines | 6 |
Ratio | 9.23 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
80 | private function assertPurchase($purchase, $data): void |
||
81 | { |
||
82 | self::assertInstanceOf(Purchase::class, $purchase); |
||
83 | self::assertSame($data['purchaseUUID'], $purchase->getUuid()); |
||
84 | self::assertSame($data['purchaseUUID1'], (string) $purchase->getUuid1()); |
||
85 | self::assertSame($data["amount"], (int) $purchase->getAmount()->getAmount()); |
||
86 | self::assertSame($data["vatAmount"], (int) $purchase->getVatAmount()->getAmount()); |
||
87 | self::assertSame($data["country"], $purchase->getCountry()); |
||
88 | self::assertSame($data["currency"], $purchase->getAmount()->getCurrency()->getCode()); |
||
89 | self::assertEquals(new DateTime($data["timestamp"]), $purchase->getTimestamp()); |
||
90 | self::assertSame($data["gpsCoordinates"]['latitude'], $purchase->getCoordinates()->getLatitude()); |
||
91 | self::assertSame($data["gpsCoordinates"]['longitude'], $purchase->getCoordinates()->getLongitude()); |
||
92 | self::assertSame((float) $data["gpsCoordinates"]['accuracyMeters'], $purchase->getCoordinates()->getAccuracyMeters()); |
||
93 | self::assertSame($data["purchaseNumber"], $purchase->getPurchaseNumber()); |
||
94 | self::assertSame($data["userDisplayName"], $purchase->getUser()->getDisplayName()); |
||
95 | self::assertSame($data["userId"], $purchase->getUser()->getId()); |
||
96 | self::assertSame($data["organizationId"], $purchase->getOrganizationId()); |
||
97 | |||
98 | foreach ($purchase->getProducts() as $index => $product) { |
||
99 | self::assertInstanceOf(Product::class, $product); |
||
100 | self::assertSame($data["products"][$index]['quantity'], (string)$product->getQuantity()); |
||
101 | self::assertSame((float) $data["products"][$index]['vatPercentage'], $product->getVatPercentage()); |
||
102 | self::assertSame($data["products"][$index]['unitPrice'], (int) $product->getUnitPrice()->getAmount()); |
||
103 | self::assertSame($data["products"][$index]['rowTaxableAmount'], (int) $product->getRowTaxableAmount()->getAmount()); |
||
104 | self::assertSame($data["products"][$index]['name'], $product->getName()); |
||
105 | self::assertSame($data["products"][$index]['variantName'], $product->getVariantName()); |
||
106 | self::assertSame($data["products"][$index]['autoGenerated'], $product->isAutoGenerated()); |
||
107 | self::assertSame($data["products"][$index]['libraryProduct'], $product->isLibraryProduct()); |
||
108 | } |
||
109 | |||
110 | foreach ($purchase->getPayments() as $index => $payment) { |
||
111 | self::assertInstanceOf(AbstractPayment::class, $payment); |
||
112 | self::assertSame($data["payments"][$index]['uuid'], (string) $payment->getUuid()); |
||
113 | self::assertSame($data["payments"][$index]['amount'], (int) $payment->getAmount()->getAmount()); |
||
114 | if ($payment instanceof CashPayment) { |
||
115 | self::assertSame($data['payments'][$index]['attributes']['handedAmount'], (int) $payment->getHandedAmount()->getAmount()); |
||
116 | } |
||
117 | if ($payment instanceof CardPayment) { |
||
118 | self::assertSame($data['payments'][$index]['attributes']['cardPaymentEntryMode'], $payment->getCardPaymentEntryMode()); |
||
119 | self::assertSame($data['payments'][$index]['attributes']['maskedPan'], $payment->getMaskedPan()); |
||
120 | self::assertSame($data['payments'][$index]['attributes']['referenceNumber'], $payment->getReferenceNumber()); |
||
121 | self::assertSame($data['payments'][$index]['attributes']['nrOfInstallments'], $payment->getNrOfInstallments()); |
||
122 | self::assertSame($data['payments'][$index]['attributes']['cardType'], $payment->getCardType()); |
||
123 | self::assertSame($data['payments'][$index]['attributes']['terminalVerificationResults'], $payment->getTerminalVerificationResults()); |
||
124 | View Code Duplication | if (array_key_exists('applicationIdentifier', $data['payments'][$index]['attributes'])) { |
|
125 | self::assertSame($data['payments'][$index]['attributes']['applicationIdentifier'], $payment->getApplicationIdentifier()); |
||
126 | } |
||
127 | View Code Duplication | if (array_key_exists('applicationName', $data['payments'][$index]['attributes'])) { |
|
128 | self::assertSame($data['payments'][$index]['attributes']['applicationName'], $payment->getApplicationName()); |
||
129 | } |
||
130 | } |
||
131 | } |
||
132 | |||
133 | self::assertSame($data["receiptCopyAllowed"], $purchase->isReceiptCopyAllowed()); |
||
134 | self::assertSame($data["published"], $purchase->getPublished()); |
||
135 | |||
136 | foreach ($purchase->getPayments() as $index => $payment) { |
||
137 | self::assertInstanceOf(AbstractPayment::class, $payment); |
||
138 | self::assertSame($data["payments"][$index]['uuid'], (string) $payment->getUuid()); |
||
139 | self::assertSame($data["payments"][$index]['amount'], (int) $payment->getAmount()->getAmount()); |
||
140 | } |
||
141 | |||
142 | self::assertSame($data["refund"], $purchase->isRefund()); |
||
143 | self::assertSame($data["refunded"], $purchase->isRefunded()); |
||
144 | } |
||
145 | |||
159 |