CategoryBuilder::build() - Code Metrics - Inspection of "refactor project" - LauLamanApps/iZettleApi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

by Laurens

created 2017-10-31 22:42 UTC

CategoryBuilder::build() A

↳ Parent: CategoryBuilder

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	1
crap	1

<?php

declare(strict_types=1);

namespace LauLamanApps\IzettleApi\Client\Product;

use DateTime;
use LauLamanApps\IzettleApi\API\Product\Category;
use LauLamanApps\IzettleApi\API\Product\CategoryCollection;
use Psr\Http\Message\ResponseInterface;
use Ramsey\Uuid\Uuid;

final class CategoryBuilder implements CategoryBuilderInterface
{
    /**
     * @return Category[]
     */
    public function buildFromJson(string $json): array
    {
        $categories = [];
        foreach (json_decode($json, true) as $category) {
            $categories[] = $this->build($category);
        }

        return $categories;
    }

    public function buildFromArray($categories): CategoryCollection
    {
        $collection = new CategoryCollection();

        foreach ($categories as $category) {
            $collection->add($this->build($category));
        }

        return $collection;
    }

    private function build(array $category): Category
    {
        return Category::create(
            Uuid::fromString($category['uuid']),
            $category['name'],
            $category['etag'],
            new DateTime($category['updated']),
            Uuid::fromString($category['updatedBy']),
            new DateTime($category['created'])
        );
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace LauLamanApps\IzettleApi\Client\Product;
6
7		use DateTime;
8		use LauLamanApps\IzettleApi\API\Product\Category;
9		use LauLamanApps\IzettleApi\API\Product\CategoryCollection;
10		use Psr\Http\Message\ResponseInterface;
11		use Ramsey\Uuid\Uuid;
12
13		final class CategoryBuilder implements CategoryBuilderInterface
14		{
15		/**
16		* @return Category[]
17		*/
18	2	public function buildFromJson(string $json): array
19		{
20	2	$categories = [];
21	2	foreach (json_decode($json, true) as $category) {
22	2	$categories[] = $this->build($category);
23		}
24
25	2	return $categories;
26		}
27
28	4	public function buildFromArray($categories): CategoryCollection
29		{
30	4	$collection = new CategoryCollection();
31
32	4	foreach ($categories as $category) {
33	2	$collection->add($this->build($category));
34		}
35
36	4	return $collection;
37		}
38
39	4	private function build(array $category): Category
40		{
41	4	return Category::create(
42	4	Uuid::fromString($category['uuid']),
43	4	$category['name'],
44	4	$category['etag'],
45	4	new DateTime($category['updated']),
46	4	Uuid::fromString($category['updatedBy']),
47	4	new DateTime($category['created'])
48		);
49		}
50		}
51

LauLamanApps / iZettleApi

Pull Request — master (#11)

CategoryBuilder::build() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like