Coordinates::isNumericInBounds() - Code Metrics - Inspection of "StudlyCaps Namespacing and Classes to PSR-1 stand..." - LauLamanApps/iZettleApi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9ff768...b736eb )

by Laurens

created 2017-10-24 16:11 UTC

Coordinates::isNumericInBounds() A

↳ Parent: Coordinates

Complexity

Conditions	3
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	4
nc	2
nop	3
crap	3

<?php

declare(strict_types=1);

namespace LauLamanApps\IzettleApi\API\Purchase;

use LauLamanApps\IzettleApi\API\Purchase\Exceptions\InvalidLatitudeException;
use LauLamanApps\IzettleApi\API\Purchase\Exceptions\InvalidLongitudeException;

final class Coordinates
{
    private $latitude;
    private $longitude;
    private $accuracyMeters;

    public function __construct(float $latitude, float $longitude, float $accuracyMeters)
    {
        $this->validateLatitude($latitude);
        $this->validateLongitude($longitude);
        $this->longitude = $longitude;
        $this->latitude = $latitude;
        $this->accuracyMeters = $accuracyMeters;
    }

    public function getLatitude(): float
    {
        return $this->latitude;
    }

    public function getLongitude(): float
    {
        return $this->longitude;
    }

    public function getAccuracyMeters(): float
    {
        return $this->accuracyMeters;
    }

    private function validateLatitude(float $latitude): void
    {
        if (!$this->isNumericInBounds($latitude, -90.0, 90.0)) {
            throw new InvalidLatitudeException(sprintf('%d is not a valid latitude', $latitude));
        }
    }

    private function validateLongitude(float $longitude): void
    {
        if (!$this->isNumericInBounds($longitude, -180.0, 180.0)) {
            throw new InvalidLongitudeException(sprintf('%d is not a valid longitude', $longitude));
        }
    }

    private function isNumericInBounds(float $value, float $min, float $max): bool
    {
        if ($value < $min || $value > $max) {
            return false;
        }

        return true;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace LauLamanApps\IzettleApi\API\Purchase;
6
7		use LauLamanApps\IzettleApi\API\Purchase\Exceptions\InvalidLatitudeException;
8		use LauLamanApps\IzettleApi\API\Purchase\Exceptions\InvalidLongitudeException;
9
10		final class Coordinates
11		{
12		private $latitude;
13		private $longitude;
14		private $accuracyMeters;
15
16	12	public function __construct(float $latitude, float $longitude, float $accuracyMeters)
17		{
18	12	$this->validateLatitude($latitude);
19	10	$this->validateLongitude($longitude);
20	8	$this->longitude = $longitude;
21	8	$this->latitude = $latitude;
22	8	$this->accuracyMeters = $accuracyMeters;
23	8	}
24
25	6	public function getLatitude(): float
26		{
27	6	return $this->latitude;
28		}
29
30	6	public function getLongitude(): float
31		{
32	6	return $this->longitude;
33		}
34
35	6	public function getAccuracyMeters(): float
36		{
37	6	return $this->accuracyMeters;
38		}
39
40	12	private function validateLatitude(float $latitude): void
41		{
42	12	if (!$this->isNumericInBounds($latitude, -90.0, 90.0)) {
43	2	throw new InvalidLatitudeException(sprintf('%d is not a valid latitude', $latitude));
44		}
45	10	}
46
47	10	private function validateLongitude(float $longitude): void
48		{
49	10	if (!$this->isNumericInBounds($longitude, -180.0, 180.0)) {
50	2	throw new InvalidLongitudeException(sprintf('%d is not a valid longitude', $longitude));
51		}
52	8	}
53
54	12	private function isNumericInBounds(float $value, float $min, float $max): bool
55		{
56	12	if ($value < $min \|\| $value > $max) {
57	4	return false;
58		}
59
60	10	return true;
61		}
62		}
63

LauLamanApps / iZettleApi

Push — master ( 9ff768...b736eb )

Coordinates::isNumericInBounds() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like