Issues in CustomerProxy.php (master) - Issues in master - LauLamanApps/ecurring-api - Measure and Improve Code Quality continuously with Scrutinizer

Issues (27)

src/Resource/Proxy/CustomerProxy.php (1 issue)

Labels

Severity

Major 1

<?php

declare(strict_types=1);

namespace LauLamanApps\eCurring\Resource\Proxy;

use DateTimeImmutable;
use LauLamanApps\eCurring\eCurringClientInterface;
use LauLamanApps\eCurring\Resource\Customer;
use LauLamanApps\eCurring\Resource\Customer\Gender;
use LauLamanApps\eCurring\Resource\Customer\VerificationMethod;
use LauLamanApps\eCurring\Resource\CustomerInterface;
use LauLamanApps\eCurring\Resource\Transaction\PaymentMethod;

/**
 * @method int getId()
 * @method Gender getGender()
 * @method string getFirstName()
 * @method string|null getMiddleName()
 * @method string getLastName()
 * @method string getCompanyName()
 * @method string getVatNumber()
 * @method PaymentMethod getPaymentType()
 * @method VerificationMethod|null getBankVerificationMethod()
 * @method string getCardHolder()
 * @method string getCardNumber()
 * @method string getPostalcode()
 * @method string getHouseNumber()
 * @method string|null getHouseNumberAdd()
 * @method string getStreet()
 * @method string getCity()
 * @method string getCountryCode()
 * @method string getLanguage()
 * @method string getEmail()
 * @method string getTelephone()
 * @method array getSubscriptions()
 * @method DateTimeImmutable getCreatedAt()
 * @method DateTimeImmutable getUpdatedAt()
 */
final class CustomerProxy extends AbstractProxy implements CustomerInterface
{
    /**
     * @return Customer
     */
    protected function __load(eCurringClientInterface $client, string $id)
    {
        return $client->getCustomer($id);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace LauLamanApps\eCurring\Resource\Proxy;
6
7			use DateTimeImmutable;
8			use LauLamanApps\eCurring\eCurringClientInterface;
9			use LauLamanApps\eCurring\Resource\Customer;
10			use LauLamanApps\eCurring\Resource\Customer\Gender;
11			use LauLamanApps\eCurring\Resource\Customer\VerificationMethod;
12			use LauLamanApps\eCurring\Resource\CustomerInterface;
13			use LauLamanApps\eCurring\Resource\Transaction\PaymentMethod;
14
15			/**
16			* @method int getId()
17			* @method Gender getGender()
18			* @method string getFirstName()
19			* @method string\|null getMiddleName()
20			* @method string getLastName()
21			* @method string getCompanyName()
22			* @method string getVatNumber()
23			* @method PaymentMethod getPaymentType()
24			* @method VerificationMethod\|null getBankVerificationMethod()
25			* @method string getCardHolder()
26			* @method string getCardNumber()
27			* @method string getPostalcode()
28			* @method string getHouseNumber()
29			* @method string\|null getHouseNumberAdd()
30			* @method string getStreet()
31			* @method string getCity()
32			* @method string getCountryCode()
33			* @method string getLanguage()
34			* @method string getEmail()
35			* @method string getTelephone()
36			* @method array getSubscriptions()
37			* @method DateTimeImmutable getCreatedAt()
38			* @method DateTimeImmutable getUpdatedAt()
39			*/
40			final class CustomerProxy extends AbstractProxy implements CustomerInterface
41			{
42			/**
43			* @return Customer
44			*/
45			protected function __load(eCurringClientInterface $client, string $id)
46			{
47			return $client->getCustomer($id);
			0 ignored issues – show Bug Best Practice introduced 2018-10-11 23:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $client->getCustomer($id)` returns the type `LauLamanApps\eCurring\Resource\Customer` which is incompatible with the return type mandated by `LauLamanApps\eCurring\Re...AbstractProxy::__load()` of `LauLamanApps\eCurring\Resource\Subscription`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
48			}
49			}
50

LauLamanApps / ecurring-api

Issues (27)

src/Resource/Proxy/CustomerProxy.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like