ProductProxy::__load() - Code Metrics - Inspection of "Merge branch 'master' of github.com:LauLamanApps/e..." - LauLamanApps/ecurring-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5d017b...8e35dd )

by Laurens

created 2018-10-25 13:05 UTC

ProductProxy::__load() A

↳ Parent: ProductProxy

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	2

<?php

declare(strict_types=1);

namespace LauLamanApps\eCurring\Resource\Proxy;

use DateTimeImmutable;
use LauLamanApps\eCurring\eCurringClientInterface;
use LauLamanApps\eCurring\Resource\Product;
use LauLamanApps\eCurring\Resource\Product\AuthenticationMethod;
use LauLamanApps\eCurring\Resource\Product\Status;
use LauLamanApps\eCurring\Resource\ProductInterface;
use LauLamanApps\eCurring\Resource\SubscriptionInterface;

/**
 * @method int getId()
 * @method string getName()
 * @method string getDescription()
 * @method DateTimeImmutable getStartDate()
 * @method Status getStatus()
 * @method AuthenticationMethod getMandateAuthenticationMethod()
 * @method bool isSendInvoice()
 * @method int getStornoRetries()
 * @method string|null getTerms()
 * @method SubscriptionInterface[] getSubscriptions()
 * @method DateTimeImmutable getCreatedAt()
 * @method DateTimeImmutable getUpdatedAt()
 */
final class ProductProxy extends AbstractProxy implements ProductInterface
{
    /**
     * @return Product
     */
    protected function __load(eCurringClientInterface $client, string $id)
    {
        return $client->getProduct($id);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace LauLamanApps\eCurring\Resource\Proxy;
6
7			use DateTimeImmutable;
8			use LauLamanApps\eCurring\eCurringClientInterface;
9			use LauLamanApps\eCurring\Resource\Product;
10			use LauLamanApps\eCurring\Resource\Product\AuthenticationMethod;
11			use LauLamanApps\eCurring\Resource\Product\Status;
12			use LauLamanApps\eCurring\Resource\ProductInterface;
13			use LauLamanApps\eCurring\Resource\SubscriptionInterface;
14
15			/**
16			* @method int getId()
17			* @method string getName()
18			* @method string getDescription()
19			* @method DateTimeImmutable getStartDate()
20			* @method Status getStatus()
21			* @method AuthenticationMethod getMandateAuthenticationMethod()
22			* @method bool isSendInvoice()
23			* @method int getStornoRetries()
24			* @method string\|null getTerms()
25			* @method SubscriptionInterface[] getSubscriptions()
26			* @method DateTimeImmutable getCreatedAt()
27			* @method DateTimeImmutable getUpdatedAt()
28			*/
29			final class ProductProxy extends AbstractProxy implements ProductInterface
30			{
31			/**
32			* @return Product
33			*/
34			protected function __load(eCurringClientInterface $client, string $id)
35			{
36			return $client->getProduct($id);
			0 ignored issues – show Bug Best Practice introduced 2018-10-25 13:10 UTC by Report Bug Copy Issue Report The expression `return $client->getProduct($id)` returns the type `LauLamanApps\eCurring\Resource\Product` which is incompatible with the return type mandated by `LauLamanApps\eCurring\Re...AbstractProxy::__load()` of `LauLamanApps\eCurring\Resource\Subscription`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
37			}
38			}
39

LauLamanApps / ecurring-api

Push — master ( 5d017b...8e35dd )

ProductProxy::__load() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like