ArticlesImport::getLatestBotArticles() - Code Metrics - Inspection of "Rename data providers import command" - LaravelRUS/laravel.ru - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature-laravel-5.4 ( 84c13d...c7e673 )

by Kirill

created 2017-03-01 01:26 UTC

ArticlesImport::getLatestBotArticles() A

↳ Parent: ArticlesImport

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	9
c	1
b	0
f	0
nc	3
nop	0
dl	0
loc	16
rs	9.4285

<?php

/**
 * This file is part of laravel.su package.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace App\Console\Commands;

use Carbon\Carbon;
use App\Models\Bot;
use App\Models\Article;
use Illuminate\Console\Command;
use App\Services\DataProviders\Manager;
use App\Services\DataProviders\ExternalArticle;
use App\Services\DataProviders\DataProviderInterface;
use Illuminate\Database\Eloquent\Relations\MorphMany;

/**
 * Class ArticlesImport.
 */
class ArticlesImport extends Command
{
    /**
     * The name and signature of the console command.
     * @var string
     */
    protected $signature = 'articles:import';

    /**
     * The console command description.
     * @var string
     */
    protected $description = 'Run import articles from external services';

    /**
     * @var array
     */
    private $published = [];

    /**
     * @param  Manager                   $manager
     * @throws \InvalidArgumentException
     */
    public function handle(Manager $manager)
    {
        $this->importPublished($manager);

        $this->importNotPublished($manager);
    }

    /**
     * @param  Manager                   $manager
     * @throws \InvalidArgumentException
     * @return void
     */
    private function importPublished(Manager $manager): void
    {
        /** @var Article $article */
        foreach ($this->getLatestBotArticles() as $article) {
            /** @var Bot $bot */
            $bot = $article->user;

            $this->import($article->published_at, $manager->get($bot->provider));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            $this->published[] = $bot->provider;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }

    /**
     * @return \Generator|Article[]
     */
    private function getLatestBotArticles(): \Generator
    {
        $bots = Bot::query()
            ->with(['articles' => function (MorphMany $relation) {
                return $relation->latest('published_at')->take(1);
            }])
            ->get();

        foreach ($bots as $bot) {
            $article = $bot->articles->first();

            if ($article) {
                yield $article;
            }
        }
    }

    /**
     * @param \DateTime             $time
     * @param DataProviderInterface $provider
     */
    private function import(\DateTime $time, DataProviderInterface $provider)
    {
        /** @var ExternalArticle[] $latest */
        $latest = $provider->getLatest($time);

        foreach ($latest as $external) {
            $article = new Article();

            $article->user_id = 1;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $article->user_type = Bot::class;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            $external->fill($article);

            $article->save();
        }
    }

    /**
     * @param  Manager $manager
     * @return void
     */
    private function importNotPublished(Manager $manager): void
    {
        foreach ($manager as $alias => $provider) {
            if (in_array($alias, $this->published, true)) {
                continue;
            }

            $this->import(Carbon::createFromTimestamp(0), $provider);
        }
    }
}


1			<?php
2
3			/**
4			* This file is part of laravel.su package.
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace App\Console\Commands;
11
12			use Carbon\Carbon;
13			use App\Models\Bot;
14			use App\Models\Article;
15			use Illuminate\Console\Command;
16			use App\Services\DataProviders\Manager;
17			use App\Services\DataProviders\ExternalArticle;
18			use App\Services\DataProviders\DataProviderInterface;
19			use Illuminate\Database\Eloquent\Relations\MorphMany;
20
21			/**
22			* Class ArticlesImport.
23			*/
24			class ArticlesImport extends Command
25			{
26			/**
27			* The name and signature of the console command.
28			* @var string
29			*/
30			protected $signature = 'articles:import';
31
32			/**
33			* The console command description.
34			* @var string
35			*/
36			protected $description = 'Run import articles from external services';
37
38			/**
39			* @var array
40			*/
41			private $published = [];
42
43			/**
44			* @param Manager $manager
45			* @throws \InvalidArgumentException
46			*/
47			public function handle(Manager $manager)
48			{
49			$this->importPublished($manager);
50
51			$this->importNotPublished($manager);
52			}
53
54			/**
55			* @param Manager $manager
56			* @throws \InvalidArgumentException
57			* @return void
58			*/
59			private function importPublished(Manager $manager): void
60			{
61			/** @var Article $article */
62			foreach ($this->getLatestBotArticles() as $article) {
63			/** @var Bot $bot */
64			$bot = $article->user;
65
66			$this->import($article->published_at, $manager->get($bot->provider));
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `provider` does not exist on `object<App\Models\Bot>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
67
68			$this->published[] = $bot->provider;
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `provider` does not exist on `object<App\Models\Bot>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
69			}
70			}
71
72			/**
73			* @return \Generator\|Article[]
74			*/
75			private function getLatestBotArticles(): \Generator
76			{
77			$bots = Bot::query()
78			->with(['articles' => function (MorphMany $relation) {
79			return $relation->latest('published_at')->take(1);
80			}])
81			->get();
82
83			foreach ($bots as $bot) {
84			$article = $bot->articles->first();
85
86			if ($article) {
87			yield $article;
88			}
89			}
90			}
91
92			/**
93			* @param \DateTime $time
94			* @param DataProviderInterface $provider
95			*/
96			private function import(\DateTime $time, DataProviderInterface $provider)
97			{
98			/** @var ExternalArticle[] $latest */
99			$latest = $provider->getLatest($time);
100
101			foreach ($latest as $external) {
102			$article = new Article();
103
104			$article->user_id = 1;
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `user_id` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
105			$article->user_type = Bot::class;
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `user_type` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
106
107			$external->fill($article);
108
109			$article->save();
110			}
111			}
112
113			/**
114			* @param Manager $manager
115			* @return void
116			*/
117			private function importNotPublished(Manager $manager): void
118			{
119			foreach ($manager as $alias => $provider) {
120			if (in_array($alias, $this->published, true)) {
121			continue;
122			}
123
124			$this->import(Carbon::createFromTimestamp(0), $provider);
125			}
126			}
127			}
128

LaravelRUS / laravel.ru

Push — feature-laravel-5.4 ( 84c13d...c7e673 )

ArticlesImport::getLatestBotArticles() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like