ExternalArticle::addImageUrl() - Code Metrics - Inspection of "Add data-providers" - LaravelRUS/laravel.ru - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — feature-laravel-5.4 ( 475d96...446986 )

by Kirill

created 2017-02-24 17:08 UTC

ExternalArticle::addImageUrl() A

↳ Parent: ExternalArticle

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * This file is part of laravel.su package.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace App\Services\DataProviders;

use App\Models\Article;
use Carbon\Carbon;
use Illuminate\Contracts\Support\Arrayable;

/**
 * Class ExternalArticle.
 */
class ExternalArticle implements Arrayable
{
    /**
     * @var string
     */
    private $title;

    /**
     * @var string
     */
    private $body;

    /**
     * @var string
     */
    private $url;

    /**
     * @var \DateTime
     */
    private $createdAt;

    /**
     * @var array|string[]
     */
    private $images = [];

    /**
     * ExternalArticle constructor.
     * @param string $title
     * @param string $body
     * @param string $url
     */
    public function __construct(string $title, string $body, string $url)
    {
        $this->title = $title;
        $this->body = $body;
        $this->url = $url;

        $this->createdAt = Carbon::now();
    }

    /**
     * @param string $image
     * @return $this
     */
    public function addImageUrl(string $image)
    {
        $this->images[] = $image;

        return $this;
    }

    /**
     * @return array
     */
    public function getImages(): array
    {
        return [];
    }

    /**
     * @return string
     */
    public function getTitle(): string
    {
        return $this->title;
    }

    /**
     * @return string
     */
    public function getBody(): string
    {
        return $this->body;
    }

    /**
     * @return string
     */
    public function getUrl(): string
    {
        return $this->url;
    }

    /**
     * @return \DateTime
     */
    public function getCreatedAt(): \DateTime
    {
        return $this->createdAt;
    }

    /**
     * @param \DateTime $createdAt
     * @return $this|ExternalArticle
     */
    public function setCreatedAt(\DateTime $createdAt)
    {
        $this->createdAt = $createdAt;

        return $this;
    }

    /**
     * @return array
     */
    public function toArray(): array
    {
        return [
            'title'      => $this->title,
            'url'        => $this->url,
            'images'     => $this->images,
            'content'    => $this->body,
            'created_at' => $this->createdAt,
        ];
    }

    /**
     * @param Article $article
     * @return Article
     */
    public function fill(Article $article): Article
    {
        $article->title = $this->title;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        //$article-
        $article->image = reset($this->images);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $article->content_source   = '';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $article->content_rendered = $this->body;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $article->published_at = $this->createdAt;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $article->status = Article\Status::PUBLISHED;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $article;
    }
}

1			<?php
2			/**
3			* This file is part of laravel.su package.
4			* For the full copyright and license information, please view the LICENSE
5			* file that was distributed with this source code.
6			*/
7			declare(strict_types=1);
8
9			namespace App\Services\DataProviders;
10
11			use App\Models\Article;
12			use Carbon\Carbon;
13			use Illuminate\Contracts\Support\Arrayable;
14
15			/**
16			* Class ExternalArticle.
17			*/
18			class ExternalArticle implements Arrayable
19			{
20			/**
21			* @var string
22			*/
23			private $title;
24
25			/**
26			* @var string
27			*/
28			private $body;
29
30			/**
31			* @var string
32			*/
33			private $url;
34
35			/**
36			* @var \DateTime
37			*/
38			private $createdAt;
39
40			/**
41			* @var array\|string[]
42			*/
43			private $images = [];
44
45			/**
46			* ExternalArticle constructor.
47			* @param string $title
48			* @param string $body
49			* @param string $url
50			*/
51			public function __construct(string $title, string $body, string $url)
52			{
53			$this->title = $title;
54			$this->body = $body;
55			$this->url = $url;
56
57			$this->createdAt = Carbon::now();
58			}
59
60			/**
61			* @param string $image
62			* @return $this
63			*/
64			public function addImageUrl(string $image)
65			{
66			$this->images[] = $image;
67
68			return $this;
69			}
70
71			/**
72			* @return array
73			*/
74			public function getImages(): array
75			{
76			return [];
77			}
78
79			/**
80			* @return string
81			*/
82			public function getTitle(): string
83			{
84			return $this->title;
85			}
86
87			/**
88			* @return string
89			*/
90			public function getBody(): string
91			{
92			return $this->body;
93			}
94
95			/**
96			* @return string
97			*/
98			public function getUrl(): string
99			{
100			return $this->url;
101			}
102
103			/**
104			* @return \DateTime
105			*/
106			public function getCreatedAt(): \DateTime
107			{
108			return $this->createdAt;
109			}
110
111			/**
112			* @param \DateTime $createdAt
113			* @return $this\|ExternalArticle
114			*/
115			public function setCreatedAt(\DateTime $createdAt)
116			{
117			$this->createdAt = $createdAt;
118
119			return $this;
120			}
121
122			/**
123			* @return array
124			*/
125			public function toArray(): array
126			{
127			return [
128			'title' => $this->title,
129			'url' => $this->url,
130			'images' => $this->images,
131			'content' => $this->body,
132			'created_at' => $this->createdAt,
133			];
134			}
135
136			/**
137			* @param Article $article
138			* @return Article
139			*/
140			public function fill(Article $article): Article
141			{
142			$article->title = $this->title;
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `title` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
143			//$article-
144			$article->image = reset($this->images);
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `image` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
145
146			$article->content_source = '';
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `content_source` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
147			$article->content_rendered = $this->body;
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `content_rendered` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
148
149			$article->published_at = $this->createdAt;
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `published_at` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
150
151			$article->status = Article\Status::PUBLISHED;
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `status` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
152
153			return $article;
154			}
155			}

LaravelRUS / laravel.ru

Push — feature-laravel-5.4 ( 475d96...446986 )

ExternalArticle::addImageUrl() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like