GravatarSupport::updateAvatar() - Code Metrics - Inspection of "Add gates support" - LaravelRUS/laravel.ru - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — feature-laravel-5.4 ( 1c0ad8...11ab58 )

by Kirill

created 2017-03-02 18:01 UTC

GravatarSupport::updateAvatar() A

↳ Parent: GravatarSupport

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	7
rs	9.4285

<?php
/**
 * This file is part of laravel.su package.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types = 1);

namespace App\Models\User;

use App\Models\User;
use Service\ImageUploader\UpdatableAvatar;
use Service\ImageUploader\Resolvers\GravatarSupports;

/**
 * Class GravatarSupport
 * @mixin User
 * @mixin UpdatableAvatar
 * @mixin GravatarSupports
 */
trait GravatarSupport
{
    /**
     * @return string
     */
    public function getEmailForGravatar(): string
    {
        return $this->email;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param string $avatar
     * @return UpdatableAvatar
     */
    public function updateAvatar(string $avatar): UpdatableAvatar
    {
        $this->avatar = $avatar;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this;
    }
}


1			<?php
2			/**
3			* This file is part of laravel.su package.
4			* For the full copyright and license information, please view the LICENSE
5			* file that was distributed with this source code.
6			*/
7			declare(strict_types = 1);
8
9			namespace App\Models\User;
10
11			use App\Models\User;
12			use Service\ImageUploader\UpdatableAvatar;
13			use Service\ImageUploader\Resolvers\GravatarSupports;
14
15			/**
16			* Class GravatarSupport
17			* @mixin User
18			* @mixin UpdatableAvatar
19			* @mixin GravatarSupports
20			*/
21			trait GravatarSupport
22			{
23			/**
24			* @return string
25			*/
26			public function getEmailForGravatar(): string
27			{
28			return $this->email;
			0 ignored issues – show Bug introduced 2017-03-02 18:05 UTC by Report Bug Copy Issue Report The property `email` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29			}
30
31			/**
32			* @param string $avatar
33			* @return UpdatableAvatar
34			*/
35			public function updateAvatar(string $avatar): UpdatableAvatar
36			{
37			$this->avatar = $avatar;
			0 ignored issues – show Bug introduced 2017-03-02 18:05 UTC by Report Bug Copy Issue Report The property `avatar` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
38			$this->save();
			0 ignored issues – show Bug introduced 2017-03-02 18:05 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
39
40			return $this;
41			}
42			}
43

LaravelRUS / laravel.ru

Push — feature-laravel-5.4 ( 1c0ad8...11ab58 )

GravatarSupport::updateAvatar() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like