ContentObserver - Code Metrics - Inspection of "Release laravel docs render" - LaravelRUS/laravel.ru - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — feature-laravel-5.4 ( 2b4b90...5bfdc4 )

by Kirill

created 2017-02-27 18:04 UTC

ContentObserver A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
dl	0
loc	49
rs	10
c	0
b	0
f	0
wmc	3
lcom	1
cbo	3

3 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
A	saving()	8	1
A	render()	8	1

<?php

/**
 * This file is part of laravel.su package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace App\Models\Docs;

use App\Models\Docs;
use App\Services\ContentRenderer\Anchors\Parser;
use App\Services\ContentRenderer\Anchors\ProcessedBody;
use App\Services\ContentRenderer\ContentRenderInterface;

/**
 * Class ContentObserver.
 */
class ContentObserver
{
    /**
     * @var ContentRenderInterface
     */
    private $renderer;

    /**
     * @var Parser
     */
    private $parser;

    /**
     * ContentObserver constructor.
     *
     * @param Parser                 $parser
     * @param ContentRenderInterface $renderer
     */
    public function __construct(Parser $parser, ContentRenderInterface $renderer)
    {
        $this->renderer = $renderer;
        $this->parser = $parser;
    }

    /**
     * @param Docs $docs
     */
    public function saving(Docs $docs): void
    {
        $body = $this->render((string) $docs->content_source);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // Update data
        $docs->nav = $body->getLinks();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $docs->content_rendered = (string) $body->getContent();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * @param string $body
     * @return ProcessedBody
     */
    private function render(string $body): ProcessedBody
    {
        // Parse markdown
        $rendered = $this->renderer->render($body);

        // Parse content headers
        return $this->parser->parse($rendered);
    }
}


1			<?php
2
3			/**
4			* This file is part of laravel.su package.
5			*
6			* For the full copyright and license information, please view the LICENSE
7			* file that was distributed with this source code.
8			*/
9			declare(strict_types=1);
10
11			namespace App\Models\Docs;
12
13			use App\Models\Docs;
14			use App\Services\ContentRenderer\Anchors\Parser;
15			use App\Services\ContentRenderer\Anchors\ProcessedBody;
16			use App\Services\ContentRenderer\ContentRenderInterface;
17
18			/**
19			* Class ContentObserver.
20			*/
21			class ContentObserver
22			{
23			/**
24			* @var ContentRenderInterface
25			*/
26			private $renderer;
27
28			/**
29			* @var Parser
30			*/
31			private $parser;
32
33			/**
34			* ContentObserver constructor.
35			*
36			* @param Parser $parser
37			* @param ContentRenderInterface $renderer
38			*/
39			public function __construct(Parser $parser, ContentRenderInterface $renderer)
40			{
41			$this->renderer = $renderer;
42			$this->parser = $parser;
43			}
44
45			/**
46			* @param Docs $docs
47			*/
48			public function saving(Docs $docs): void
49			{
50			$body = $this->render((string) $docs->content_source);
			0 ignored issues – show Documentation introduced 2017-02-27 18:07 UTC by Report Bug Copy Issue Report The property `content_source` does not exist on `object<App\Models\Docs>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
51
52			// Update data
53			$docs->nav = $body->getLinks();
			0 ignored issues – show Documentation introduced 2017-02-26 18:03 UTC by Report Bug Copy Issue Report The property `nav` does not exist on `object<App\Models\Docs>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
54			$docs->content_rendered = (string) $body->getContent();
			0 ignored issues – show Documentation introduced 2017-02-26 18:03 UTC by Report Bug Copy Issue Report The property `content_rendered` does not exist on `object<App\Models\Docs>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
55			}
56
57			/**
58			* @param string $body
59			* @return ProcessedBody
60			*/
61			private function render(string $body): ProcessedBody
62			{
63			// Parse markdown
64			$rendered = $this->renderer->render($body);
65
66			// Parse content headers
67			return $this->parser->parse($rendered);
68			}
69			}
70

LaravelRUS / laravel.ru

Push — feature-laravel-5.4 ( 2b4b90...5bfdc4 )

ContentObserver A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like