ExternalArticle - Code Metrics - Inspection of "Add description into imported news" - LaravelRUS/laravel.ru - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — feature-laravel-5.4 ( 2edebe...f95f7c )

by Kirill

created 2017-02-26 05:28 UTC

ExternalArticle A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	165
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	0
loc	165
rs	10
c	0
b	0
f	0
wmc	12
lcom	1
cbo	1

12 Methods

Rating	Name	Size	Complexity
A	__construct()	8	1
A	getPreview()	4	1
A	setPreview()	6	1
A	addImageUrl()	6	1
A	getImages()	4	1
A	getTitle()	4	1
A	getBody()	4	1
A	getUrl()	4	1
A	getCreatedAt()	4	1
A	setCreatedAt()	6	1
A	toArray()	10	1
A	fill()	18	1

<?php
/**
 * This file is part of laravel.su package.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace App\Services\DataProviders;

use Carbon\Carbon;
use App\Models\Article;
use Illuminate\Contracts\Support\Arrayable;

/**
 * Class ExternalArticle.
 */
class ExternalArticle implements Arrayable
{
    /**
     * @var string
     */
    private $title;

    /**
     * @var string
     */
    private $body;

    /**
     * @var string
     */
    private $preview = '';

    /**
     * @var string
     */
    private $url;

    /**
     * @var \DateTime
     */
    private $createdAt;

    /**
     * @var array|string[]
     */
    private $images = [];

    /**
     * ExternalArticle constructor.
     * @param string $title
     * @param string $body
     * @param string $url
     */
    public function __construct(string $title, string $body, string $url)
    {
        $this->title = $title;
        $this->body = $body;
        $this->url = $url;

        $this->createdAt = Carbon::now();
    }

    /**
     * @return string
     */
    public function getPreview(): string
    {
        return $this->preview;
    }

    /**
     * @param string $preview
     * @return $this|ExternalArticle
     */
    public function setPreview(string $preview): ExternalArticle
    {
        $this->preview = $preview;

        return $this;
    }

    /**
     * @param  string $image
     * @return $this
     */
    public function addImageUrl(string $image)
    {
        $this->images[] = $image;

        return $this;
    }

    /**
     * @return array
     */
    public function getImages(): array
    {
        return [];
    }

    /**
     * @return string
     */
    public function getTitle(): string
    {
        return $this->title;
    }

    /**
     * @return string
     */
    public function getBody(): string
    {
        return $this->body;
    }

    /**
     * @return string
     */
    public function getUrl(): string
    {
        return $this->url;
    }

    /**
     * @return \DateTime
     */
    public function getCreatedAt(): \DateTime
    {
        return $this->createdAt;
    }

    /**
     * @param  \DateTime             $createdAt
     * @return $this|ExternalArticle
     */
    public function setCreatedAt(\DateTime $createdAt)
    {
        $this->createdAt = $createdAt;

        return $this;
    }

    /**
     * @return array
     */
    public function toArray(): array
    {
        return [
            'title'      => $this->title,
            'url'        => $this->url,
            'images'     => $this->images,
            'content'    => $this->body,
            'created_at' => $this->createdAt,
        ];
    }

    /**
     * @param  Article $article
     * @return Article
     */
    public function fill(Article $article): Article
    {
        $article->title = $this->title;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        //$article-
        $article->image = reset($this->images);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $article->preview_source = '';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $article->preview_rendered = $this->preview;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $article->content_source = '';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $article->content_rendered = $this->body;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $article->published_at = $this->createdAt;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $article->status = Article\Status::PUBLISHED;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $article;
    }
}


1			<?php
2			/**
3			* This file is part of laravel.su package.
4			* For the full copyright and license information, please view the LICENSE
5			* file that was distributed with this source code.
6			*/
7			declare(strict_types=1);
8
9			namespace App\Services\DataProviders;
10
11			use Carbon\Carbon;
12			use App\Models\Article;
13			use Illuminate\Contracts\Support\Arrayable;
14
15			/**
16			* Class ExternalArticle.
17			*/
18			class ExternalArticle implements Arrayable
19			{
20			/**
21			* @var string
22			*/
23			private $title;
24
25			/**
26			* @var string
27			*/
28			private $body;
29
30			/**
31			* @var string
32			*/
33			private $preview = '';
34
35			/**
36			* @var string
37			*/
38			private $url;
39
40			/**
41			* @var \DateTime
42			*/
43			private $createdAt;
44
45			/**
46			* @var array\|string[]
47			*/
48			private $images = [];
49
50			/**
51			* ExternalArticle constructor.
52			* @param string $title
53			* @param string $body
54			* @param string $url
55			*/
56			public function __construct(string $title, string $body, string $url)
57			{
58			$this->title = $title;
59			$this->body = $body;
60			$this->url = $url;
61
62			$this->createdAt = Carbon::now();
63			}
64
65			/**
66			* @return string
67			*/
68			public function getPreview(): string
69			{
70			return $this->preview;
71			}
72
73			/**
74			* @param string $preview
75			* @return $this\|ExternalArticle
76			*/
77			public function setPreview(string $preview): ExternalArticle
78			{
79			$this->preview = $preview;
80
81			return $this;
82			}
83
84			/**
85			* @param string $image
86			* @return $this
87			*/
88			public function addImageUrl(string $image)
89			{
90			$this->images[] = $image;
91
92			return $this;
93			}
94
95			/**
96			* @return array
97			*/
98			public function getImages(): array
99			{
100			return [];
101			}
102
103			/**
104			* @return string
105			*/
106			public function getTitle(): string
107			{
108			return $this->title;
109			}
110
111			/**
112			* @return string
113			*/
114			public function getBody(): string
115			{
116			return $this->body;
117			}
118
119			/**
120			* @return string
121			*/
122			public function getUrl(): string
123			{
124			return $this->url;
125			}
126
127			/**
128			* @return \DateTime
129			*/
130			public function getCreatedAt(): \DateTime
131			{
132			return $this->createdAt;
133			}
134
135			/**
136			* @param \DateTime $createdAt
137			* @return $this\|ExternalArticle
138			*/
139			public function setCreatedAt(\DateTime $createdAt)
140			{
141			$this->createdAt = $createdAt;
142
143			return $this;
144			}
145
146			/**
147			* @return array
148			*/
149			public function toArray(): array
150			{
151			return [
152			'title' => $this->title,
153			'url' => $this->url,
154			'images' => $this->images,
155			'content' => $this->body,
156			'created_at' => $this->createdAt,
157			];
158			}
159
160			/**
161			* @param Article $article
162			* @return Article
163			*/
164			public function fill(Article $article): Article
165			{
166			$article->title = $this->title;
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `title` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
167			//$article-
168			$article->image = reset($this->images);
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `image` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
169
170			$article->preview_source = '';
			0 ignored issues – show Documentation introduced 2017-02-26 05:31 UTC by Report Bug Copy Issue Report The property `preview_source` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
171			$article->preview_rendered = $this->preview;
			0 ignored issues – show Documentation introduced 2017-02-26 05:31 UTC by Report Bug Copy Issue Report The property `preview_rendered` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
172
173			$article->content_source = '';
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `content_source` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
174			$article->content_rendered = $this->body;
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `content_rendered` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
175
176			$article->published_at = $this->createdAt;
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `published_at` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
177
178			$article->status = Article\Status::PUBLISHED;
			0 ignored issues – show Documentation introduced 2017-02-24 17:15 UTC by Report Bug Copy Issue Report The property `status` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
179
180			return $article;
181			}
182			}
183

LaravelRUS / laravel.ru

Push — feature-laravel-5.4 ( 2edebe...f95f7c )

ExternalArticle A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

12 Methods

Duplication Side-by-Side

Filter issues like