VersionObserver::saving() - Code Metrics - Inspection of "Add docs view" - LaravelRUS/laravel.ru - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — feature-laravel-5.4 ( dbda8c...02b5b6 )

by Kirill

created 2017-02-26 17:59 UTC

VersionObserver::saving() A

↳ Parent: VersionObserver

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	1
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * This file is part of laravel.su package.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace App\Models\Docs;

use App\Models\Docs;

/**
 * Class VersionObserver.
 */
class VersionObserver
{
    private const DEFAULT_LATEST_VERSION = '5.4';

    /**
     * @param Docs $docs
     */
    public function saving(Docs $docs): void
    {
        if (! $docs->version) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $docs->version = $this->getLatestAvailableVersion();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }

    /**
     * @return string
     */
    private function getLatestAvailableVersion(): string
    {
        return self::DEFAULT_LATEST_VERSION;
    }
}


1			<?php
2			/**
3			* This file is part of laravel.su package.
4			* For the full copyright and license information, please view the LICENSE
5			* file that was distributed with this source code.
6			*/
7			declare(strict_types=1);
8
9			namespace App\Models\Docs;
10
11			use App\Models\Docs;
12
13			/**
14			* Class VersionObserver.
15			*/
16			class VersionObserver
17			{
18			private const DEFAULT_LATEST_VERSION = '5.4';
19
20			/**
21			* @param Docs $docs
22			*/
23			public function saving(Docs $docs): void
24			{
25			if (! $docs->version) {
			0 ignored issues – show Documentation introduced 2017-02-26 14:04 UTC by Report Bug Copy Issue Report The property `version` does not exist on `object<App\Models\Docs>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
26			$docs->version = $this->getLatestAvailableVersion();
			0 ignored issues – show Documentation introduced 2017-02-26 14:04 UTC by Report Bug Copy Issue Report The property `version` does not exist on `object<App\Models\Docs>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
27			}
28			}
29
30			/**
31			* @return string
32			*/
33			private function getLatestAvailableVersion(): string
34			{
35			return self::DEFAULT_LATEST_VERSION;
36			}
37			}
38

LaravelRUS / laravel.ru

Push — feature-laravel-5.4 ( dbda8c...02b5b6 )

VersionObserver::saving() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like