ContentObserver::parseHeaders() - Code Metrics - Inspection of "Add docs view" - LaravelRUS/laravel.ru - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — feature-laravel-5.4 ( dbda8c...02b5b6 )

by Kirill

created 2017-02-26 17:59 UTC

ContentObserver::parseHeaders() A

↳ Parent: ContentObserver

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	4
loc	4
rs	10
c	0
b	0
f	0

<?php

/**
 * This file is part of laravel.su package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace App\Models\Docs;

use App\Models\Docs;
use App\Services\ContentRenderer\ContentHeadersRenderer;
use App\Services\ContentRenderer\ContentRenderInterface;

/**
 * Class ContentObserver.
 */
class ContentObserver

{
    /**
     * @var ContentRenderInterface
     */
    private $renderer;

    /**
     * ContentObserver constructor.
     *
     * @param ContentRenderInterface $renderer
     */
    public function __construct(ContentRenderInterface $renderer)
    {
        $this->renderer = $renderer;
    }

    /**
     * @param Docs $docs
     */
    public function saving(Docs $docs): void
    {
        // Parse markdown
        $rendered  = $this->renderer->renderBody((string) $docs->content_source);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // Parse content headers
        $parsed    = $this->parseHeaders($rendered);

        // Update data
        $docs->nav = $parsed->getLinks();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $docs->content_rendered = (string) $parsed->getContent();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * @param  string                 $content
     * @return ContentHeadersRenderer
     */
    private function parseHeaders(string $content): ContentHeadersRenderer
    {
        return (new ContentHeadersRenderer($content))->parse();
    }
}


1		<?php
2
3		/**
4		* This file is part of laravel.su package.
5		*
6		* For the full copyright and license information, please view the LICENSE
7		* file that was distributed with this source code.
8		*/
9		declare(strict_types=1);
10
11		namespace App\Models\Docs;
12
13		use App\Models\Docs;
14		use App\Services\ContentRenderer\ContentHeadersRenderer;
15		use App\Services\ContentRenderer\ContentRenderInterface;
16
17		/**
18		* Class ContentObserver.
19		*/
20	View Code Duplication	class ContentObserver
		0 ignored issues – show Duplication introduced 2017-02-26 14:04 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		{
22		/**
23		* @var ContentRenderInterface
24		*/
25		private $renderer;
26
27		/**
28		* ContentObserver constructor.
29		*
30		* @param ContentRenderInterface $renderer
31		*/
32		public function __construct(ContentRenderInterface $renderer)
33		{
34		$this->renderer = $renderer;
35		}
36
37		/**
38		* @param Docs $docs
39		*/
40		public function saving(Docs $docs): void
41		{
42		// Parse markdown
43		$rendered = $this->renderer->renderBody((string) $docs->content_source);
		0 ignored issues – show Documentation introduced 2017-02-26 14:04 UTC by Report Bug Copy Issue Report The property `content_source` does not exist on `object<App\Models\Docs>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
44
45		// Parse content headers
46		$parsed = $this->parseHeaders($rendered);
47
48		// Update data
49		$docs->nav = $parsed->getLinks();
		0 ignored issues – show Documentation introduced 2017-02-26 18:03 UTC by Report Bug Copy Issue Report The property `nav` does not exist on `object<App\Models\Docs>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
50		$docs->content_rendered = (string) $parsed->getContent();
		0 ignored issues – show Documentation introduced 2017-02-26 18:03 UTC by Report Bug Copy Issue Report The property `content_rendered` does not exist on `object<App\Models\Docs>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
51		}
52
53		/**
54		* @param string $content
55		* @return ContentHeadersRenderer
56		*/
57		private function parseHeaders(string $content): ContentHeadersRenderer
58		{
59		return (new ContentHeadersRenderer($content))->parse();
60		}
61		}
62

LaravelRUS / laravel.ru

Push — feature-laravel-5.4 ( dbda8c...02b5b6 )

ContentObserver::parseHeaders() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like