ArticlesSearchRepository::getName() - Code Metrics - Inspection of "Improve search kernel" - LaravelRUS/laravel.ru - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 2.0 ( d68ee5...a984b1 )

by Kirill

created 2017-03-13 00:36 UTC

ArticlesSearchRepository::getName() A

↳ Parent: ArticlesSearchRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php
/**
 * This file is part of laravel.ru package.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace App\Models\Article;

use App\Models\Article;
use Illuminate\Support\Collection;
use Service\SearchService\SearchResult;
use Service\SearchService\Repository\SearchRepositoryInterface;

/**
 * Class ArticlesSearchRepository
 * @package App\Models\Article
 */
class ArticlesSearchRepository implements SearchRepositoryInterface
{
    /**
     * @return string
     */
    public function getName(): string
    {
        return 'articles';
    }

    /**
     * @param string $query
     * @param int $limit
     * @return Collection|SearchResult[]
     */
    public function getSearchResults(string $query, int $limit = 10): Collection

    {
        return Article::query()
            ->where('content_source', 'LIKE', '%' . $query . '%')
            ->take($limit)
            ->get(['slug', 'title', 'content_rendered'])
            ->map(function (Article $model) {
                return $this->transform($model);
            });
    }

    /**
     * @param Article $article
     * @return SearchResult
     */
    private function transform(Article $article): SearchResult

    {
        $dto = new SearchResult();

        $dto->title = $article->title;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $dto->type = Article::class;

        $dto->url = route('articles.show', ['slug' => $article->slug]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $dto->slug = $article->slug;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $dto->body = $article->content_rendered;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $dto;
    }
}

1		<?php
2		/**
3		* This file is part of laravel.ru package.
4		* For the full copyright and license information, please view the LICENSE
5		* file that was distributed with this source code.
6		*/
7		declare(strict_types=1);
8
9		namespace App\Models\Article;
10
11		use App\Models\Article;
12		use Illuminate\Support\Collection;
13		use Service\SearchService\SearchResult;
14		use Service\SearchService\Repository\SearchRepositoryInterface;
15
16		/**
17		* Class ArticlesSearchRepository
18		* @package App\Models\Article
19		*/
20		class ArticlesSearchRepository implements SearchRepositoryInterface
21		{
22		/**
23		* @return string
24		*/
25		public function getName(): string
26		{
27		return 'articles';
28		}
29
30		/**
31		* @param string $query
32		* @param int $limit
33		* @return Collection\|SearchResult[]
34		*/
35	View Code Duplication	public function getSearchResults(string $query, int $limit = 10): Collection
		0 ignored issues – show Duplication introduced 2017-03-13 00:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		return Article::query()
38		->where('content_source', 'LIKE', '%' . $query . '%')
39		->take($limit)
40		->get(['slug', 'title', 'content_rendered'])
41		->map(function (Article $model) {
42		return $this->transform($model);
43		});
44		}
45
46		/**
47		* @param Article $article
48		* @return SearchResult
49		*/
50	View Code Duplication	private function transform(Article $article): SearchResult
		0 ignored issues – show Duplication introduced 2017-03-13 00:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		{
52		$dto = new SearchResult();
53
54		$dto->title = $article->title;
		0 ignored issues – show Documentation introduced 2017-03-13 00:39 UTC by Report Bug Copy Issue Report The property `title` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
55		$dto->type = Article::class;
56
57		$dto->url = route('articles.show', ['slug' => $article->slug]);
		0 ignored issues – show Documentation introduced 2017-03-13 00:39 UTC by Report Bug Copy Issue Report The property `slug` does not exist on `object<App\Models\Article>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
58		$dto->slug = $article->slug;
		0 ignored issues – show Documentation introduced 2017-03-13 00:39 UTC by Report Bug Copy Issue Report The property `slug` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
59		$dto->body = $article->content_rendered;
		0 ignored issues – show Documentation introduced 2017-03-13 00:39 UTC by Report Bug Copy Issue Report The property `content_rendered` does not exist on `object<App\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
60
61		return $dto;
62		}
63		}

LaravelRUS / laravel.ru

Push — 2.0 ( d68ee5...a984b1 )

ArticlesSearchRepository::getName() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like