Images::getValueFromModel() - Code Metrics - Inspection of "Apply fixes from StyleCI" - LaravelRUS/SleepingOwlAdmin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — analysis-d0YOlw ( 094a36 )

by butschster

created 2020-02-26 08:13 UTC

Images::getValueFromModel() A

↳ Parent: Images

Complexity

Conditions	5
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	8
nc	3
nop	0
dl	0
loc	14
rs	9.6111
c	0
b	0
f	0

<?php

namespace SleepingOwl\Admin\Form\Element;

use Illuminate\Http\Request;

class Images extends Image
{
    /**
     * @var string
     */
    protected $view = 'form.element.images';

    protected $draggable = true;

    /**
     * @return bool
     */
    public function getDraggable()
    {
        return (bool) $this->draggable;
    }

    /**
     * @param bool $draggable
     *
     * @return $this
     */
    public function setDraggable($draggable)
    {
        $this->draggable = $draggable;

        return $this;
    }

    /**
     * Store array of images as json string.
     * @return $this
     */
    public function storeAsJson()
    {
        $this->mutateValue(function ($value) {
            return json_encode($value);
        });

        return $this;
    }

    /**
     * Store array of images as coma separator.
     * @deprecated
     * @return $this
     */
    public function storeAsComaSeparatedValue()
    {
        /* deprecated this logic */
        // $this->mutateValue(function ($value) {

        //     return implode(',', $value);

        // });


        return $this;
    }

    /**
     * @return string
     */
    public function getValueFromModel()
    {
        $images = $value = parent::getValueFromModel();

        if (is_null($value)) {

            $images = [];
        } elseif (is_string($value)
            && (($images = json_decode($value)) === false
                || is_null($images))
        ) {
            $images = preg_split('/,/', $value, -1, PREG_SPLIT_NO_EMPTY);
        }

        return $images;
    }

    /**
     * @param \Illuminate\Http\Request $request
     *
     * @return void
     */
    public function save(Request $request)
    {
        $name = $this->getName();
        $value = $request->input($name, '');

        if (! empty($value)) {
            $value = explode(',', $value);
        } else {
            $value = [];
        }

        $request->merge([$name => $value]);

        parent::save($request);
    }

    /**
     * @return array
     */
    public function toArray()
    {
        return array_merge(parent::toArray(), [
            'draggable' => $this->getDraggable(),
        ]);

        return $return;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }
}


1			<?php
2
3			namespace SleepingOwl\Admin\Form\Element;
4
5			use Illuminate\Http\Request;
6
7			class Images extends Image
8			{
9			/**
10			* @var string
11			*/
12			protected $view = 'form.element.images';
13
14			protected $draggable = true;
15
16			/**
17			* @return bool
18			*/
19			public function getDraggable()
20			{
21			return (bool) $this->draggable;
22			}
23
24			/**
25			* @param bool $draggable
26			*
27			* @return $this
28			*/
29			public function setDraggable($draggable)
30			{
31			$this->draggable = $draggable;
32
33			return $this;
34			}
35
36			/**
37			* Store array of images as json string.
38			* @return $this
39			*/
40			public function storeAsJson()
41			{
42			$this->mutateValue(function ($value) {
43			return json_encode($value);
44			});
45
46			return $this;
47			}
48
49			/**
50			* Store array of images as coma separator.
51			* @deprecated
52			* @return $this
53			*/
54			public function storeAsComaSeparatedValue()
55			{
56			/* deprecated this logic */
57			// $this->mutateValue(function ($value) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2020-02-04 23:59 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
58			// return implode(',', $value);
			0 ignored issues – show Unused Code Comprehensibility introduced 2020-02-04 23:59 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
59			// });
			0 ignored issues – show Unused Code Comprehensibility introduced 2020-02-04 23:59 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
60
61			return $this;
62			}
63
64			/**
65			* @return string
66			*/
67			public function getValueFromModel()
68			{
69			$images = $value = parent::getValueFromModel();
70
71			if (is_null($value)) {
			0 ignored issues – show introduced 2019-03-13 14:44 UTC by Report Bug Copy Issue Report The condition `is_null($value)` is always `false`. Loading history...
72			$images = [];
73			} elseif (is_string($value)
74			&& (($images = json_decode($value)) === false
75			\|\| is_null($images))
76			) {
77			$images = preg_split('/,/', $value, -1, PREG_SPLIT_NO_EMPTY);
78			}
79
80			return $images;
81			}
82
83			/**
84			* @param \Illuminate\Http\Request $request
85			*
86			* @return void
87			*/
88			public function save(Request $request)
89			{
90			$name = $this->getName();
91			$value = $request->input($name, '');
92
93			if (! empty($value)) {
94			$value = explode(',', $value);
95			} else {
96			$value = [];
97			}
98
99			$request->merge([$name => $value]);
100
101			parent::save($request);
102			}
103
104			/**
105			* @return array
106			*/
107			public function toArray()
108			{
109			return array_merge(parent::toArray(), [
110			'draggable' => $this->getDraggable(),
111			]);
112
113			return $return;
			0 ignored issues – show Unused Code introduced 2020-02-26 08:21 UTC by Report Bug Copy Issue Report `return $return` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
114			}
115			}
116

LaravelRUS / SleepingOwlAdmin

GitHub Access Token became invalid

Push — analysis-d0YOlw ( 094a36 )

Images::getValueFromModel() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like