CreateSectionServiceProvider::install() - Code Metrics - Inspection of "Merge branch 'development'" - LaravelRUS/SleepingOwlAdmin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 414922...a9bc98 )

by butschster

created 2016-12-21 10:07 UTC

CreateSectionServiceProvider::install() A

↳ Parent: CreateSectionServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	8
nc	1
nop	0
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0

<?php

namespace SleepingOwl\Admin\Console\Installation;

class CreateSectionServiceProvider extends Installator
{
    /**
     * Вывод информации о текущей конфигурации.
     *
     * @return void
     */
    public function showInfo()
    {
        $this->command->line('Creating [AdminSectionsServiceProvider.php] file: <info>✔</info>');
    }

    /**
     * Установка компонентов текущей конфигурации.
     *
     * @return void
     */
    public function install()
    {
        $file = $this->getFilePath();
        $ns = rtrim($this->command->getLaravel()->getNamespace(), '\\');

        $contents = str_replace(
            '__NAMESPACE__',
            $ns,
            $this->command->files()->get(SLEEPINGOWL_STUB_PATH.'/provider.stub')
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        );

        $this->command->files()->put($file, $contents);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * При возврате методом true данный компонент будет пропущен.
     *
     * @return bool
     */
    public function installed()
    {
        return file_exists($this->getFilePath());
    }

    /**
     * @return string
     */
    protected function getFilePath()
    {
        return app_path('Providers/AdminSectionsServiceProvider.php');
    }
}


GitHub Access Token became invalid

Push — master ( 414922...a9bc98 )

CreateSectionServiceProvider::install() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace SleepingOwl\Admin\Console\Installation;
4
5			class CreateSectionServiceProvider extends Installator
6			{
7			/**
8			* Вывод информации о текущей конфигурации.
9			*
10			* @return void
11			*/
12			public function showInfo()
13			{
14			$this->command->line('Creating [AdminSectionsServiceProvider.php] file: <info>✔</info>');
15			}
16
17			/**
18			* Установка компонентов текущей конфигурации.
19			*
20			* @return void
21			*/
22			public function install()
23			{
24			$file = $this->getFilePath();
25			$ns = rtrim($this->command->getLaravel()->getNamespace(), '\\');
26
27			$contents = str_replace(
28			'__NAMESPACE__',
29			$ns,
30			$this->command->files()->get(SLEEPINGOWL_STUB_PATH.'/provider.stub')
			0 ignored issues – show Bug introduced 2016-12-21 10:19 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Illuminate\Console\Command` as the method `files()` does only exist in the following sub-classes of `Illuminate\Console\Command`: `SleepingOwl\Admin\Console\Commands\InstallCommand`, `SleepingOwl\Admin\Console\Commands\UpdateCommand`, `SleepingOwl\Admin\Console\Installation\Command`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
31			);
32
33			$this->command->files()->put($file, $contents);
			0 ignored issues – show Bug introduced 2016-12-21 10:19 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Illuminate\Console\Command` as the method `files()` does only exist in the following sub-classes of `Illuminate\Console\Command`: `SleepingOwl\Admin\Console\Commands\InstallCommand`, `SleepingOwl\Admin\Console\Commands\UpdateCommand`, `SleepingOwl\Admin\Console\Installation\Command`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
34			}
35
36			/**
37			* При возврате методом true данный компонент будет пропущен.
38			*
39			* @return bool
40			*/
41			public function installed()
42			{
43			return file_exists($this->getFilePath());
44			}
45
46			/**
47			* @return string
48			*/
49			protected function getFilePath()
50			{
51			return app_path('Providers/AdminSectionsServiceProvider.php');
52			}
53			}
54

LaravelRUS / SleepingOwlAdmin

GitHub Access Token became invalid

Push — master ( 414922...a9bc98 )

CreateSectionServiceProvider::install() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like