SleepingOwl\Admin\Traits\SmallDisplay

Complexity

Total Complexity

5

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Importance

Changes	2
Bugs	2	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setSmall()	0	6	1
A	getSmall()	0	7	2
A	getIsolated()	0	3	1
A	setIsolated()	0	5	1

<?php

namespace SleepingOwl\Admin\Traits;

trait SmallDisplay
{
    /**
     * @var string
     * @var bool
     */
    protected $small;
    protected $smallString = false;

    /**
     * @var bool
     */
    protected $isolated = true;

    /**
     * @return string
     */
    public function getSmall()
    {
        if ($this->smallString) {
            return $this->small;
        }

        return $this->getValueFromObject($this->getModel(), $this->small);

It seems like getModel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like getValueFromObject() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param string $small
     *
     * @return $this
     */
    public function setSmall($small, $smallString = false)
    {
        $this->small = $small;
        $this->smallString = $smallString;

        return $this;
    }

    /**
     * @param bool $isolated
     *
     * @return $this
     */
    public function setIsolated($isolated)
    {
        $this->isolated = $isolated;

        return $this;
    }

    /**
     * @return string
     */
    public function getIsolated()
    {
        return $this->isolated;

The expression return $this->isolated returns the type boolean which is incompatible with the documented return type string.

    }
}