LaravelRUS / SleepingOwlAdmin

src/Display/DisplayTabbed.php

Spacing +6 added lines, -6 removed lines

@@ -67,7 +67,7 @@ 
             }
         }
 
-        $activeTabs = $this->getTabs()->filter(function (TabInterface $tab) {
+        $activeTabs = $this->getTabs()->filter(function(TabInterface $tab) {
             return $tab->isActive();
         })->count();
 
@@ -95,7 +95,7 @@ 
      */
     public function setModelClass($class)
     {
-        $this->getTabs()->each(function (TabInterface $tab) use ($class) {
+        $this->getTabs()->each(function(TabInterface $tab) use ($class) {
             if ($tab instanceof DisplayInterface) {
                 $tab->setModelClass($class);
             }
@@ -179,7 +179,7 @@ 
      */
     public function setAction($action)
     {
-        $this->getTabs()->each(function (TabInterface $tab) use ($action) {
+        $this->getTabs()->each(function(TabInterface $tab) use ($action) {
             if ($tab instanceof FormInterface) {
                 $tab->setAction($action);
             }
@@ -195,7 +195,7 @@ 
      */
     public function setId($id)
     {
-        $this->getTabs()->each(function (TabInterface $tab) use ($id) {
+        $this->getTabs()->each(function(TabInterface $tab) use ($id) {
             if ($tab instanceof FormInterface) {
                 $tab->setId($id);
             }
@@ -212,7 +212,7 @@ 
      */
     public function validateForm(\Illuminate\Http\Request $request, ModelConfigurationInterface $model = null)
     {
-        $this->getTabs()->each(function ($tab) use ($request, $model) {
+        $this->getTabs()->each(function($tab) use ($request, $model) {
             $tabId = $request->get('sleeping_owl_tab_id');
 
             if ($tab instanceof FormInterface && $tab->getName() == $tabId) {
@@ -229,7 +229,7 @@ 
      */
     public function saveForm(\Illuminate\Http\Request $request, ModelConfigurationInterface $model = null)
     {
-        $this->getTabs()->each(function (TabInterface $tab) use ($request, $model) {
+        $this->getTabs()->each(function(TabInterface $tab) use ($request, $model) {
             $tabId = $request->get('sleeping_owl_tab_id');
 
             if ($tab instanceof FormInterface && $tab->getName() == $tabId) {

src/Display/Column/Editable/EditableColumn.php

Doc Comments +3 added lines, -5 removed lines

@@ -40,9 +40,8 @@ 
     }
 
     /**
-     * @param bool $sortable
      *
-     * @return $this
+     * @return string
      */
     public function getTitle()
     {
@@ -54,7 +53,6 @@ 
     }
 
     /**
-     * @param bool $sortable
      *
      * @return $this
      */
@@ -79,7 +77,7 @@ 
 
     /**
      * @param $url
-     * @return string
+     * @return EditableColumn
      */
     public function setUrl($url)
     {
@@ -98,7 +96,7 @@ 
 
     /**
      * @param $url
-     * @return string
+     * @return EditableColumn
      */
     public function setEditableMode($mode)
     {

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SleepingOwl\Admin\Display\Column\Editable;
 
-use Illuminate\Http\Request;
 use SleepingOwl\Admin\Display\Column\NamedColumn;
 
 class EditableColumn extends NamedColumn

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
      */
     public function getUrl()
     {
-        if (! $this->url) {
+        if (!$this->url) {
             return request()->url();
         }
 

src/Display/Column/NamedColumn.php

Doc Comments +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
     /**
      * Get column value from instance.
      *
-     * @param Collection|Model|Closure $instance
+     * @param Model $instance
      * @param string $name
      *
      * @return mixed

Spacing +4 added lines, -4 removed lines

@@ -75,8 +75,8 @@ 
      */
     public function setOrderable($orderable = true)
     {
-        if ($orderable !== false && ! $orderable instanceof OrderByClauseInterface) {
-            if (! is_string($orderable) && ! $orderable instanceof Closure) {
+        if ($orderable !== false && !$orderable instanceof OrderByClauseInterface) {
+            if (!is_string($orderable) && !$orderable instanceof Closure) {
                 $orderable = $this->getName();
             }
         }
@@ -144,11 +144,11 @@ 
             if ($instance === null) {
                 $instance = collect();
             }
-        } elseif (! is_null($instance)) {
+        } elseif (!is_null($instance)) {
             $instance = $instance->getAttribute($part);
         }
 
-        if (! empty($parts) && ! is_null($instance)) {
+        if (!empty($parts) && !is_null($instance)) {
             return $this->getValueFromObject($instance, implode('.', $parts));
         }
 

src/Form/FormDefault.php

Doc Comments +1 added lines, -1 removed lines

@@ -192,7 +192,7 @@
      * @deprecated 4.5.0
      * @see getElements()
      *
-     * @return Collection[]
+     * @return FormElementsCollection
      */
     public function getItems()
     {

Spacing +9 added lines, -9 removed lines

@@ -100,11 +100,11 @@ 
 
         parent::initialize();
 
-        if (! $this->hasHtmlAttribute('enctype')) {
+        if (!$this->hasHtmlAttribute('enctype')) {
             // Try to find upload element
-            $this->getElements()->each(function ($element) {
+            $this->getElements()->each(function($element) {
                 // Try to get nested - will be implemented
-                if ($element instanceof Upload && ! $this->hasHtmlAttribute('enctype')) {
+                if ($element instanceof Upload && !$this->hasHtmlAttribute('enctype')) {
                     $this->setHtmlAttribute('enctype', 'multipart/form-data');
                 }
             });
@@ -209,7 +209,7 @@ 
      */
     public function setItems($items)
     {
-        if (! is_array($items)) {
+        if (!is_array($items)) {
             $items = func_get_args();
         }
 
@@ -236,7 +236,7 @@ 
      */
     public function setId($id)
     {
-        if (is_null($this->id) && ! is_null($id) && ($model = $this->getRepository()->find($id))) {
+        if (is_null($this->id) && !is_null($id) && ($model = $this->getRepository()->find($id))) {
             $this->id = $id;
 
             parent::setModel($model);
@@ -297,7 +297,7 @@ 
      */
     public function saveForm(\Illuminate\Http\Request $request, ModelConfigurationInterface $modelConfiguration = null)
     {
-        if (! $this->validModelConfiguration($modelConfiguration)) {
+        if (!$this->validModelConfiguration($modelConfiguration)) {
             return false;
         }
 
@@ -337,7 +337,7 @@ 
     protected function saveBelongsToRelations(Model $model)
     {
         foreach ($model->getRelations() as $name => $relation) {
-            if ($model->{$name}() instanceof BelongsTo && ! is_null($relation)) {
+            if ($model->{$name}() instanceof BelongsTo && !is_null($relation)) {
                 $relation->save();
                 $model->{$name}()->associate($relation);
             }
@@ -352,7 +352,7 @@ 
     protected function saveHasOneRelations(Model $model)
     {
         foreach ($model->getRelations() as $name => $relation) {
-            if ($model->{$name}() instanceof HasOneOrMany && ! is_null($relation)) {
+            if ($model->{$name}() instanceof HasOneOrMany && !is_null($relation)) {
                 if (is_array($relation) || $relation instanceof \Traversable) {
                     $model->{$name}()->saveMany($relation);
                 } else {
@@ -370,7 +370,7 @@ 
      */
     public function validateForm(\Illuminate\Http\Request $request, ModelConfigurationInterface $modelConfiguration = null)
     {
-        if (! $this->validModelConfiguration($modelConfiguration)) {
+        if (!$this->validModelConfiguration($modelConfiguration)) {
             return;
         }
 

src/Http/Controllers/FormElementController.php

Doc Comments +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
 {
     /**
      * @param ModelConfigurationInterface $model
-     * @param null $id
+     * @param integer|null $id
      * @return JsonResponse|mixed
      */
     public function getModelLogic(ModelConfigurationInterface $model, $id = null)

Spacing +5 added lines, -5 removed lines

@@ -18,9 +18,9 @@ 
      */
     public function getModelLogic(ModelConfigurationInterface $model, $id = null)
     {
-        if (! is_null($id)) {
+        if (!is_null($id)) {
             $item = $model->getRepository()->find($id);
-            if (is_null($item) || ! $model->isEditable($item)) {
+            if (is_null($item) || !$model->isEditable($item)) {
                 return new JsonResponse([
                     'message' => trans('lang.message.access_denied'),
                 ], 403);
@@ -29,7 +29,7 @@ 
             return $model->fireEdit($id);
         }
 
-        if (! $model->isCreatable()) {
+        if (!$model->isCreatable()) {
             return new JsonResponse([
                 'message' => trans('lang.message.access_denied'),
             ], 403);
@@ -74,7 +74,7 @@ 
         }
 
         return new JsonResponse([
-            'output'   => collect($options)->map(function ($value, $key) {
+            'output'   => collect($options)->map(function($value, $key) {
                 return ['id' => $key, 'name' => $value];
             }),
             'selected' => $element->getValueFromModel(),
@@ -126,7 +126,7 @@ 
             return new JsonResponse(
                 $model::where($request->search, 'like', "%{$request->q}%")
                     ->get()
-                    ->map(function (Model $item) use ($field) {
+                    ->map(function(Model $item) use ($field) {
                         return [
                             'tag_name'    => $item->{$field},
                             'id'          => $item->id,

src/Navigation.php

Doc Comments +2 added lines, -2 removed lines

@@ -14,7 +14,7 @@ 
 
     /**
      * Overload current page.
-     * @return \KodiComponents\Navigation\Contracts\PageInterface|null
+     * @return PageInterface
      */
     public function getCurrentPage()
     {
@@ -50,7 +50,7 @@ 
 
     /**
      * @param Collection $pages
-     * @param $url
+     * @param string $url
      */
     protected function findPageByAliasId(Collection $pages, $url)
     {

Spacing +4 added lines, -4 removed lines

@@ -30,7 +30,7 @@ 
      */
     public function setAliasesId(Collection $pages)
     {
-        $pages->each(function (PageInterface $page) {
+        $pages->each(function(PageInterface $page) {
             $page->setAliasId();
 
             if ($page->getPages()->count()) {
@@ -54,7 +54,7 @@ 
      */
     protected function findPageByAliasId(Collection $pages, $url)
     {
-        $pages->each(function (PageInterface $page) use ($url) {
+        $pages->each(function(PageInterface $page) use ($url) {
             $urlPath = parse_url($url, PHP_URL_PATH);
 
             if (Route::current()) {
@@ -86,7 +86,7 @@ 
      */
     protected function findActivePage()
     {
-        if (! is_null($this->currentPage)) {
+        if (!is_null($this->currentPage)) {
             return true;
         }
 
@@ -96,7 +96,7 @@ 
 
         $this->findActive($url, $foundPages);
 
-        if (! is_null($this->currentPage)) {
+        if (!is_null($this->currentPage)) {
             $this->currentPage->setActive();
         }
 

src/Navigation/Page.php

Spacing +5 added lines, -5 removed lines

@@ -57,7 +57,7 @@ 
      */
     public function getModelConfiguration()
     {
-        if (! $this->hasModel()) {
+        if (!$this->hasModel()) {
             return;
         }
 
@@ -69,7 +69,7 @@ 
      */
     public function hasModel()
     {
-        return ! is_null($this->model) && class_exists($this->model);
+        return !is_null($this->model) && class_exists($this->model);
     }
 
     /**
@@ -113,9 +113,9 @@ 
      */
     public function getAccessLogic()
     {
-        if (! is_callable($this->accessLogic)) {
+        if (!is_callable($this->accessLogic)) {
             if ($this->hasModel()) {
-                return function () {
+                return function() {
                     return $this->getModelConfiguration()->isDisplayable();
                 };
             }
@@ -133,7 +133,7 @@ 
     {
         $data = $this->toArray();
 
-        if (! is_null($view)) {
+        if (!is_null($view)) {
             return view($view, $data)->render();
         }
 

src/Routing/ModelRouter.php

Spacing +2 added lines, -2 removed lines

@@ -59,7 +59,7 @@ 
      */
     protected function registerModelBindings(Collection $aliases)
     {
-        $this->router->bind('adminModel', function ($model, Route $route) use ($aliases) {
+        $this->router->bind('adminModel', function($model, Route $route) use ($aliases) {
             if (is_null($model = $aliases->get($model))) {
                 throw new ModelNotFoundException();
             }
@@ -85,7 +85,7 @@ 
      */
     protected function runCustomController(Route $route, $controller, $action)
     {
-        $route->uses(function () use ($route, $controller, $action) {
+        $route->uses(function() use ($route, $controller, $action) {
             return (new ControllerDispatcher($this->app))->dispatch(
                 $route, $this->app->make($controller), $action
             );

src/Traits/SelectOptionsFromModel.php

Spacing +5 added lines, -5 removed lines

@@ -64,7 +64,7 @@ 
             $modelForOptions = app($modelForOptions);
         }
 
-        if (! ($modelForOptions instanceof Model)) {
+        if (!($modelForOptions instanceof Model)) {
             throw new SelectException('Class must be instanced of Illuminate\Database\Eloquent\Model');
         }
 
@@ -121,7 +121,7 @@ 
      */
     public function setFetchColumns($columns)
     {
-        if (! is_array($columns)) {
+        if (!is_array($columns)) {
             $columns = func_get_args();
         }
 
@@ -216,7 +216,7 @@ 
 
         $options = $repository->getQuery();
 
-        if ($this->isEmptyRelation() && ! is_null($foreignKey = $this->getForeignKey())) {
+        if ($this->isEmptyRelation() && !is_null($foreignKey = $this->getForeignKey())) {
             $relation = $this->getModelAttributeKey();
             $model = $this->getModel();
 
@@ -232,7 +232,7 @@ 
         }
 
         // call the pre load options query preparer if has be set
-        if (! is_null($preparer = $this->getLoadOptionsQueryPreparer())) {
+        if (!is_null($preparer = $this->getLoadOptionsQueryPreparer())) {
             $options = $preparer($this, $options);
         }
 
@@ -246,7 +246,7 @@ 
 
             // iterate for all options and redefine it as
             // list of KEY and TEXT pair
-            $options = array_map(function ($opt) use ($key, $makeDisplay) {
+            $options = array_map(function($opt) use ($key, $makeDisplay) {
                 // get the KEY and make the display text
                 return [data_get($opt, $key), $makeDisplay($opt)];
             }, $options);