SectionProvider - Code Metrics - Inspection of "Merge branch 'development'" - LaravelRUS/SleepingOwlAdmin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f91a4c...f91a4c )

by Dave

created 2018-05-18 10:43 UTC

SectionProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	46
Duplicated Lines	47.83 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	4
lcom	0
cbo	2
dl	22
loc	46
ccs	0
cts	9
cp	0
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	fire()	11	11	2
A	handle()	11	11	2

How to fix Duplicated Code

<?php

namespace SleepingOwl\Admin\Console\Commands;

use Illuminate\Console\Command;
use Illuminate\Config\Repository;
use SleepingOwl\Admin\Console\Installation\CreateSectionServiceProvider;

class SectionProvider extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'sleepingowl:section:provider';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Create [AdminSectionsServiceProvider] class';

    /**
     * @param Repository $files
     */
    public function fire(Repository $files)

    {
        $installer = new CreateSectionServiceProvider($this, $files);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if ($installer->installed()) {
            $this->line('File <info>AdminSectionsServiceProvider</info> exists');

            return;
        }

        $installer->install();
    }

    /**
     * @param Repository $files
     */
    public function handle(Repository $files)

    {
        $installer = new CreateSectionServiceProvider($this, $files);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if ($installer->installed()) {
            $this->line('File <info>AdminSectionsServiceProvider</info> exists');

            return;
        }

        $installer->install();
    }
}


1		<?php
2
3		namespace SleepingOwl\Admin\Console\Commands;
4
5		use Illuminate\Console\Command;
6		use Illuminate\Config\Repository;
7		use SleepingOwl\Admin\Console\Installation\CreateSectionServiceProvider;
8
9		class SectionProvider extends Command
10		{
11		/**
12		* The console command name.
13		*
14		* @var string
15		*/
16		protected $name = 'sleepingowl:section:provider';
17
18		/**
19		* The console command description.
20		*
21		* @var string
22		*/
23		protected $description = 'Create [AdminSectionsServiceProvider] class';
24
25		/**
26		* @param Repository $files
27		*/
28	View Code Duplication	public function fire(Repository $files)
		0 ignored issues – show Duplication introduced 2018-05-18 11:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		{
30		$installer = new CreateSectionServiceProvider($this, $files);
		0 ignored issues – show Documentation introduced 2016-12-21 10:19 UTC by Report Bug Copy Issue Report `$this` is of type `this<SleepingOwl\Admin\C...mmands\SectionProvider>`, but the function expects a `object<SleepingOwl\Admin...ommands\InstallCommand>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
31		if ($installer->installed()) {
32		$this->line('File <info>AdminSectionsServiceProvider</info> exists');
33
34		return;
35		}
36
37		$installer->install();
38		}
39
40		/**
41		* @param Repository $files
42		*/
43	View Code Duplication	public function handle(Repository $files)
		0 ignored issues – show Duplication introduced 2018-05-18 11:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		$installer = new CreateSectionServiceProvider($this, $files);
		0 ignored issues – show Documentation introduced 2018-05-18 11:18 UTC by Report Bug Copy Issue Report `$this` is of type `this<SleepingOwl\Admin\C...mmands\SectionProvider>`, but the function expects a `object<SleepingOwl\Admin...ommands\InstallCommand>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
46		if ($installer->installed()) {
47		$this->line('File <info>AdminSectionsServiceProvider</info> exists');
48
49		return;
50		}
51
52		$installer->install();
53		}
54		}
55

LaravelRUS / SleepingOwlAdmin

GitHub Access Token became invalid

Push — master ( f91a4c...f91a4c )

SectionProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like