Tree::setView() - Code Metrics - Inspection of "Added trait Renderable" - LaravelRUS/SleepingOwlAdmin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — development (1ea943)

by butschster

created 2016-12-28 14:09 UTC

Tree::setView() A

↳ Parent: Tree::initialize()

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

namespace SleepingOwl\Admin\Display\Extension;

use Illuminate\Support\Collection;
use KodiComponents\Support\HtmlAttributes;
use Illuminate\Contracts\Support\Renderable;
use SleepingOwl\Admin\Display\Column\Control;
use SleepingOwl\Admin\Contracts\Initializable;
use SleepingOwl\Admin\Contracts\ColumnInterface;

class Tree extends Extension implements Initializable, Renderable
{
    use HtmlAttributes, \SleepingOwl\Admin\Traits\Renderable;

    /**
     * @var bool
     */
    protected $controlActive = true;

    /**
     * @var string|\Illuminate\View\View
     */
    protected $view = 'display.columns';

    /**
     * @var Control
     */
    protected $controlColumn;

    public function __construct()
    {
        $this->columns = new Collection();
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->setControlColumn(app('sleeping_owl.table.column')->treeControl());
    }

    /**
     * @param ColumnInterface $controlColumn
     *
     * @return $this
     */
    public function setControlColumn(ColumnInterface $controlColumn)
    {
        $this->controlColumn = $controlColumn;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}

        return $this;
    }

    /**
     * @return Control
     */
    public function getControlColumn()
    {
        return $this->controlColumn;
    }

    /**
     * @return bool
     */
    public function isControlActive()
    {
        return $this->controlActive;
    }

    /**
     * @return $this
     */
    public function enableControls()
    {
        $this->controlActive = true;

        return $this;
    }

    /**
     * @return $this
     */
    public function disableControls()
    {
        $this->controlActive = true;

        return $this;
    }

    /**
     * @return Collection|\SleepingOwl\Admin\Contracts\ColumnInterface[]
     */
    public function all()
    {
        return $this->columns;
    }

    /**
     * @return Collection|\SleepingOwl\Admin\Contracts\ColumnInterface[]
     */
    public function allWithControl()
    {
        $columns = $this->all();

        if ($this->isControlActive()) {
            $columns->push($this->getControlColumn());
        }

        return $columns;
    }

    /**
     * @param ColumnInterface $column
     *
     * @return $this
     */
    public function push(ColumnInterface $column)
    {
        $this->columns->push($column);

        return $this;
    }

    /**
     * Get the instance as an array.
     *
     * @return array
     */
    public function toArray()
    {
        return [
            'columns'    => $this->allWithControl(),
            'attributes' => $this->htmlAttributesToString(),
        ];
    }

    public function initialize()
    {
        $this->allWithControl()->each(function (ColumnInterface $column) {
            $column->initialize();
        });

        $this->setHtmlAttribute('class', 'table table-striped');
    }
}


1			<?php
2
3			namespace SleepingOwl\Admin\Display\Extension;
4
5			use Illuminate\Support\Collection;
6			use KodiComponents\Support\HtmlAttributes;
7			use Illuminate\Contracts\Support\Renderable;
8			use SleepingOwl\Admin\Display\Column\Control;
9			use SleepingOwl\Admin\Contracts\Initializable;
10			use SleepingOwl\Admin\Contracts\ColumnInterface;
11
12			class Tree extends Extension implements Initializable, Renderable
13			{
14			use HtmlAttributes, \SleepingOwl\Admin\Traits\Renderable;
15
16			/**
17			* @var bool
18			*/
19			protected $controlActive = true;
20
21			/**
22			* @var string\|\Illuminate\View\View
23			*/
24			protected $view = 'display.columns';
25
26			/**
27			* @var Control
28			*/
29			protected $controlColumn;
30
31			public function __construct()
32			{
33			$this->columns = new Collection();
			0 ignored issues – show Bug introduced 2016-07-15 12:17 UTC by Report Bug Copy Issue Report The property `columns` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
34
35			$this->setControlColumn(app('sleeping_owl.table.column')->treeControl());
36			}
37
38			/**
39			* @param ColumnInterface $controlColumn
40			*
41			* @return $this
42			*/
43			public function setControlColumn(ColumnInterface $controlColumn)
44			{
45			$this->controlColumn = $controlColumn;
			0 ignored issues – show Documentation Bug introduced 2016-07-15 12:17 UTC by Report Bug Copy Issue Report `$controlColumn` is of type `object<SleepingOwl\Admin...tracts\ColumnInterface>`, but the property `$controlColumn` was declared to be of type `object<SleepingOwl\Admin\Display\Column\Control>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
46
47			return $this;
48			}
49
50			/**
51			* @return Control
52			*/
53			public function getControlColumn()
54			{
55			return $this->controlColumn;
56			}
57
58			/**
59			* @return bool
60			*/
61			public function isControlActive()
62			{
63			return $this->controlActive;
64			}
65
66			/**
67			* @return $this
68			*/
69			public function enableControls()
70			{
71			$this->controlActive = true;
72
73			return $this;
74			}
75
76			/**
77			* @return $this
78			*/
79			public function disableControls()
80			{
81			$this->controlActive = true;
82
83			return $this;
84			}
85
86			/**
87			* @return Collection\|\SleepingOwl\Admin\Contracts\ColumnInterface[]
88			*/
89			public function all()
90			{
91			return $this->columns;
92			}
93
94			/**
95			* @return Collection\|\SleepingOwl\Admin\Contracts\ColumnInterface[]
96			*/
97			public function allWithControl()
98			{
99			$columns = $this->all();
100
101			if ($this->isControlActive()) {
102			$columns->push($this->getControlColumn());
103			}
104
105			return $columns;
106			}
107
108			/**
109			* @param ColumnInterface $column
110			*
111			* @return $this
112			*/
113			public function push(ColumnInterface $column)
114			{
115			$this->columns->push($column);
116
117			return $this;
118			}
119
120			/**
121			* Get the instance as an array.
122			*
123			* @return array
124			*/
125			public function toArray()
126			{
127			return [
128			'columns' => $this->allWithControl(),
129			'attributes' => $this->htmlAttributesToString(),
130			];
131			}
132
133			public function initialize()
134			{
135			$this->allWithControl()->each(function (ColumnInterface $column) {
136			$column->initialize();
137			});
138
139			$this->setHtmlAttribute('class', 'table table-striped');
140			}
141			}
142

LaravelRUS / SleepingOwlAdmin

GitHub Access Token became invalid

Branch — development (1ea943)

Tree::setView() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like