SleepingOwl\Admin\Traits\FormElementsRecursiveIterator

Complexity

Total Complexity

4

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	recursiveIterateElements()	0	18	4

<?php

namespace SleepingOwl\Admin\Traits;

use SleepingOwl\Admin\Contracts\Form\ElementsInterface;

trait FormElementsRecursiveIterator
{
    /**
     * @param \Closure $callback
     *
     * @return bool|void
     */
    public function recursiveIterateElements(\Closure $callback)
    {
        // If Callback function returns TRUE then recurse iterator should stop.
        $result = null;

        foreach ($this->getElements() as $element) {

It seems like getElements() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if ($element instanceof ElementsInterface) {
                $result = $element->recursiveIterateElements($callback);

The method recursiveIterateElements() does not exist on SleepingOwl\Admin\Contracts\Form\ElementsInterface. It seems like you code against a sub-type of said class. However, the method does not exist in SleepingOwl\Admin\Contracts\Form\FormInterface or SleepingOwl\Admin\Contracts\Form\Columns\ColumnInterface. Are you sure you never get one of those?

            } else {
                $result = $callback($element);
            }

            if ($result === true) {
                break;
            }
        }

        return $result;
    }
}